Re: Review Request 68763: Cleaned up residual containers when removing resource provider configs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68763/#review208828 --- PASS: Mesos patch 68763 was successfully built and tested. Review

Re: Review Request 68761: Made the actors in resource providers managed by libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68761/#review208825 --- FAIL: Failed to apply the current review. Failed command: `python

Re: Review Request 68763: Cleaned up residual containers when removing resource provider configs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68763/ --- (Updated Sept. 20, 2018, 11:21 p.m.) Review request for mesos, Benjamin Bannier

Re: Review Request 68763: WIP: Stopped resource providers when removing resource provider configs.

> On Sept. 19, 2018, 3:35 p.m., Benjamin Bannier wrote: > > src/resource_provider/daemon.cpp > > Lines 310-314 (patched) > > > > > > This is a pretty bare-bones API. I believe if we'd instead schedule > > removal on

Re: Review Request 68762: Tested container cleanup in `AgentResourceProviderConfigApiTest.Remove`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68762/ --- (Updated Sept. 20, 2018, 11:15 p.m.) Review request for mesos, Benjamin Bannier

Review Request 68790: Moved the container ID prefix generation to `LocalResourceProvider`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68790/ --- Review request for mesos, Benjamin Bannier, Jie Yu, and Jan Schlicht. Bugs: MES

Re: Review Request 68404: Updated XFS recovery tests with persistent volumes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68404/#review208819 --- src/tests/containerizer/xfs_quota_tests.cpp Lines 1260-1262 (patc

Re: Review Request 68404: Updated XFS recovery tests with persistent volumes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68404/#review208820 --- Ship it! Ship It! - Ilya Pronin On Aug. 16, 2018, 4:52 p.m.,

Re: Review Request 68403: Updated tests for XFS disk resource statistics.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68403/#review208818 --- Fix it, then Ship it! src/tests/containerizer/xfs_quota_tests.

Re: Review Request 68402: Added a test for XFS persistent volume isolation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68402/#review208813 --- src/tests/containerizer/xfs_quota_tests.cpp Lines 505 (patched) <

Re: Review Request 68639: Renamed `Resources::resources` vector and typedef its item type.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68639/#review208811 --- Fix it, then Ship it! Also, can you link this with a ticket for

Re: Review Request 68490: Optimized `class Resources` with copy-on-write.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68490/#review208810 --- Fix it, then Ship it! src/v1/resources.cpp Lines 1657-1675 (or

Re: Review Request 68773: Added more logging to `DynamicReservationFramework`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68773/#review208809 --- Ship it! Ship It! - Benjamin Mahler On Sept. 20, 2018, 5:03

Re: Review Request 68508: Added tracking of framework allocations in the allocator Slave class.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68508/#review208808 --- PASS: Mesos patch 68508 was successfully built and tested. Review

Re: Review Request 68773: Added more logging to `DynamicReservationFramework`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68773/#review208805 --- PASS: Mesos patch 68773 was successfully built and tested. Review

Review Request 68508: Added tracking of framework allocations in the allocator Slave class.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68508/ --- Review request for mesos, Benjamin Mahler and Gastón Kleiman. Bugs: MESOS-9182

Review Request 68507: Pulled out nested `Framework` and `Slave` classes in the allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68507/ --- Review request for mesos, Benjamin Mahler and Gastón Kleiman. Repository: mesos

Re: Review Request 68773: Added more logging to `DynamicReservationFramework`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68773/ --- (Updated Sept. 20, 2018, 10:03 a.m.) Review request for mesos, Alexander Ruklet

Re: Review Request 68773: Added more logging to `DynamicReservationFramework`.

> On Sept. 19, 2018, 11:53 p.m., Benjamin Mahler wrote: > > I left some comments about the state logging, but I think if we want to add > > that we can just do so in a separate patch and land the check logging more > > quickly in this patch. Yeah, removed them. I think the added logging should

Re: Review Request 68785: Added jsonschema.py for managing json-based configs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68785/#review208802 --- FAIL: Some of the unit tests failed. Please check the relevant log

Re: Review Request 68401: Added persistent volume support to the `disk/xfs` isolator.

> On Sept. 20, 2018, 12:59 a.m., Ilya Pronin wrote: > > src/slave/containerizer/mesos/isolators/xfs/disk.hpp > > Lines 83 (patched) > > > > > > Nit: `const`? Fixed. > On Sept. 20, 2018, 12:59 a.m., Ilya Pronin wrot

Re: Review Request 68785: Added jsonschema.py for managing json-based configs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68785/ --- (Updated Sept. 20, 2018, 3:43 p.m.) Review request for mesos, Armand Grillet, J

Review Request 68785: Added jsonschema.py for managing json-based configs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68785/ --- Review request for mesos, Armand Grillet, Jason Lai, and Kevin Klues. Repositor

Re: Review Request 68785: Added jsonschema.py for managing json-based configs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68785/ --- (Updated Sept. 20, 2018, 3:43 p.m.) Review request for mesos, Armand Grillet, J

Re: Review Request 68784: Fixed broken pipe error in IOSwitchboard.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68784/#review208800 --- PASS: Mesos patch 68784 was successfully built and tested. Review

Review Request 68784: Fixed broken pipe error in IOSwitchboard.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68784/ --- Review request for mesos and Alexander Rukletsov. Bugs: MESOS-8545 https://