Re: Review Request 68641: Added version check and bundling of libevent within libprocess.

2018-09-23 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68641/#review208937 --- PASS: Mesos patch 68641 was successfully built and tested.

Re: Review Request 68820: Bumped mesos-tidy to upstream release_70.

2018-09-23 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68820/#review208936 --- PASS: Mesos patch 68820 was successfully built and tested.

Re: Review Request 68818: Fixed accidental use-after-move.

2018-09-23 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68818/#review208935 --- PASS: Mesos patch 68818 was successfully built and tested.

Re: Review Request 68817: Prevented leaking files in some libprocess tests.

2018-09-23 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68817/#review208934 --- PASS: Mesos patch 68817 was successfully built and tested.

Re: Review Request 68819: Asserted element exists before accessing it.

2018-09-23 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68819/#review208933 --- PASS: Mesos patch 68819 was successfully built and tested.

Re: Review Request 68641: Added version check and bundling of libevent within libprocess.

2018-09-23 Thread Till Toenshoff via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68641/ --- (Updated Sept. 23, 2018, 8:44 p.m.) Review request for mesos, Benjamin

Re: Review Request 68816: Prevented leaking files in some stout tests.

2018-09-23 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68816/#review208932 --- FAIL: Some of the unit tests failed. Please check the relevant

Re: Review Request 68641: Added version check and bundling of libevent within libprocess.

2018-09-23 Thread James Peach
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68641/#review208931 --- 3rdparty/libprocess/configure.ac Line 804 (original), 804

Re: Review Request 68640: Added version check and bundling of libevent to autotools.

2018-09-23 Thread James Peach
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68640/#review208930 --- Ship it! Ship It! - James Peach On Sept. 22, 2018, 7:53

Re: Review Request 68809: Fixed a typo in `slave.cpp`.

2018-09-23 Thread James Peach
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68809/#review208929 --- Ship it! Ship It! - James Peach On Sept. 21, 2018, 11:14

Review Request 68816: Prevented leaking files in some stout tests.

2018-09-23 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68816/ --- Review request for mesos, Jan Schlicht and Till Toenshoff. Repository: mesos

Review Request 68820: Bumped mesos-tidy to upstream release_70.

2018-09-23 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68820/ --- Review request for mesos, Michael Park and Till Toenshoff. Repository: mesos

Review Request 68817: Prevented leaking files in some libprocess tests.

2018-09-23 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68817/ --- Review request for mesos, Benjamin Hindman and Till Toenshoff. Repository:

Review Request 68819: Asserted element exists before accessing it.

2018-09-23 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68819/ --- Review request for mesos, Daniel Pravat, Michael Park, and Till Toenshoff.

Review Request 68818: Fixed accidental use-after-move.

2018-09-23 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68818/ --- Review request for mesos, Benjamin Mahler and Meng Zhu. Repository: mesos

Re: Review Request 68813: Added support for `Option` / `Option`.

2018-09-23 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68813/#review208927 --- I am not convinced we should add this. The alternative of using