Re: Review Request 68872: Specified `--type=container` for `docker inspect` command.

2018-09-28 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68872/#review209115 --- PASS: Mesos patch 68872 was successfully built and tested.

Re: Review Request 68872: Specified `--type=container` for `docker inspect` command.

2018-09-28 Thread Qian Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68872/ --- (Updated Sept. 29, 2018, 11:22 a.m.) Review request for mesos and Gilbert

Review Request 68882: Updated mininal supported Docker version from 1.0.0 to 1.8.0.

2018-09-28 Thread Qian Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68882/ --- Review request for mesos and Gilbert Song. Bugs: MESOS-9231

Re: Review Request 68872: Specified `--type=container` for `docker inspect` command.

2018-09-28 Thread Qian Zhang
> On Sept. 29, 2018, 9:06 a.m., Gilbert Song wrote: > > Could we verify the minimum supported docker version? The `--type` option was added into `docker inspect` in Docker 1.8.0, see https://github.com/moby/moby/releases/tag/v1.8.0 for more details. - Qian

Re: Review Request 68872: Specified `--type=container` for `docker inspect` command.

2018-09-28 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68872/#review209113 --- Ship it! Could we verify the minimum supported docker version?

Re: Review Request 68880: Cached the cgroup results in Docker containerizer.

2018-09-28 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68880/#review209112 --- PASS: Mesos patch 68880 was successfully built and tested.

Re: Review Request 68880: Cached the cgroup results in Docker containerizer.

2018-09-28 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68880/#review209111 --- Ship it! Ship It! - Gilbert Song On Sept. 28, 2018, 4:09

Re: Review Request 68880: Cached the cgroup results in Docker containerizer.

2018-09-28 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68880/ --- (Updated Sept. 28, 2018, 11:09 p.m.) Review request for mesos, Gilbert Song,

Review Request 68880: Cached the cgroup results in Docker containerizer.

2018-09-28 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68880/ --- Review request for mesos, Gilbert Song, Greg Mann, and Vinod Kone. Repository:

Re: Review Request 68866: Waited for TEARDOWN response in v1 Java scheduler shim.

2018-09-28 Thread Alexander Rukletsov
> On Sept. 27, 2018, 6:23 p.m., Vinod Kone wrote: > > src/java/jni/org_apache_mesos_v1_scheduler_V1Mesos.cpp > > Lines 294 (patched) > > > > > > Looks like you are doing `call` here instead of `send` so that you

Re: Review Request 68872: Specified `--type=container` for `docker inspect` command.

2018-09-28 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68872/#review209089 --- FAIL: Some of the unit tests failed. Please check the relevant

Review Request 68872: Specified `--type=container` for `docker inspect` command.

2018-09-28 Thread Qian Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68872/ --- Review request for mesos and Gilbert Song. Bugs: MESOS-9231