Re: Review Request 69123: Fixed an early fd close in the cgroups event notifier.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69123/#review209910 --- PASS: Mesos patch 69123 was successfully built and tested.

Review Request 69123: Fixed an early fd close in the cgroups event notifier.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69123/ --- Review request for mesos and Qian Zhang. Repository: mesos Description

Re: Review Request 69036: WIP: Changed the semantics of `CREATE_DISK` and `DESTROY_DISK` operations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69036/ --- (Updated Oct. 23, 2018, 2:37 a.m.) Review request for mesos, Benjamin Bannier,

Re: Review Request 68957: Add documentation for per-framework metrics flag.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68957/#review209907 --- PASS: Mesos patch 68957 was successfully built and tested.

Re: Review Request 68956: Add a flag to toggle per-framework metrics.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68956/ --- (Updated Oct. 22, 2018, 11:53 p.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 68953: Refactor allocator configuration into a struct.

> On Oct. 22, 2018, 3:44 a.m., Greg Mann wrote: > > include/mesos/allocator/allocator.hpp > > Lines 55 (patched) > > > > > > Is this necessary in this patch, or should it be added in the child > > patch which adds

Re: Review Request 68957: Add documentation for per-framework metrics flag.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68957/ --- (Updated Oct. 22, 2018, 11:53 p.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 68953: Refactor allocator configuration into a struct.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68953/ --- (Updated Oct. 22, 2018, 11:52 p.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 68956: Add a flag to toggle per-framework metrics.

> On Oct. 22, 2018, 5:04 p.m., James Peach wrote: > > In the discussion on Slack we talked about adding some explanation of why > > we choose to omit publishing rathe than omit metrics collection altogether. > > I don't see an obvious, central place to capture that in a comment, so lets > >

Re: Review Request 68956: Add a flag to toggle per-framework metrics.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68956/ --- (Updated Oct. 22, 2018, 11:42 p.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 68957: Add documentation for per-framework metrics flag.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68957/ --- (Updated Oct. 22, 2018, 11:42 p.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 68957: Add documentation for per-framework metrics flag.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68957/#review209905 --- PASS: Mesos patch 68957 was successfully built and tested.

Re: Review Request 68022: Enabled Seccomp filter in the containerizer launcher.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68022/#review209904 --- Bad patch! Reviews applied: [68022, 68021, 68020, 68019, 68018,

Re: Review Request 69098: Added a benchmark to compare quota and nonquota allocation performance.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69098/ --- (Updated Oct. 22, 2018, 3:39 p.m.) Review request for mesos, Benjamin Mahler

Re: Review Request 69097: Added an allocator benchmark for quota performance.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69097/ --- (Updated Oct. 22, 2018, 3:32 p.m.) Review request for mesos, Benjamin Mahler

Re: Review Request 68957: Add documentation for per-framework metrics flag.

> On Oct. 22, 2018, 4:45 p.m., James Peach wrote: > > docs/configuration/master.md > > Lines 669 (patched) > > > > > > Since this is a boolean flag, it should be: > > ``` > >

Re: Review Request 68957: Add documentation for per-framework metrics flag.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68957/ --- (Updated Oct. 22, 2018, 10:05 p.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 68957: Add documentation for per-framework metrics flag.

> On Oct. 22, 2018, 4:42 p.m., James Peach wrote: > > docs/configuration/master.md > > Lines 672 (patched) > > > > > > I think that we should give the operator a bit more context here. Maybe > > something like

Re: Review Request 69115: Added test for interactive 'task exec'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69115/#review209902 --- Patch looks great! Reviews applied: [69114, 69048, 69119, 69049,

Re: Review Request 69009: Stout: Added a sync option for `write` and `rename`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69009/ --- (Updated Oct. 22, 2018, 9:21 p.m.) Review request for mesos, Andrew

Re: Review Request 69085: Stout: Always `fsync` created directories in POSIX `mkdir`.

> On Oct. 22, 2018, 6:05 p.m., Benjamin Bannier wrote: > > 3rdparty/stout/include/stout/os/posix/mkdir.hpp > > Lines 45 (patched) > > > > > > I wonder if this has issues with symlinks. > > > > Imagine e.g.,

Re: Review Request 69110: Added task health check definitions to master API responses.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69110/#review209896 --- PASS: Mesos patch 69110 was successfully built and tested.

Re: Review Request 69036: WIP: Updated the semantics of `CREATE_DISK` and `DESTROY_DISK` operations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69036/ --- (Updated Oct. 22, 2018, 6:50 p.m.) Review request for mesos, Benjamin Bannier,

Re: Review Request 68642: Added `lsof()` into stout.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68642/#review209891 --- Fix it, then Ship it!

Re: Review Request 69110: Added task health check definitions to master API responses.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69110/ --- (Updated Oct. 22, 2018, 6:37 p.m.) Review request for mesos, Alexander

Re: Review Request 69110: Added task health check definitions to master API responses.

> On Oct. 22, 2018, 8:42 a.m., Alexander Rukletsov wrote: > > include/mesos/mesos.proto > > Lines 2200-2201 (patched) > > > > > > Let's add a `TODO` here for `CheckInfo`. Here and below. I went ahead and modified

Re: Review Request 69110: Added task health check definitions to master API responses.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69110/ --- (Updated Oct. 22, 2018, 6:20 p.m.) Review request for mesos, Alexander

Re: Review Request 69085: Stout: Always `fsync` created directories in POSIX `mkdir`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69085/#review209889 --- 3rdparty/stout/include/stout/os/posix/mkdir.hpp Lines 45

Re: Review Request 68022: Enabled Seccomp filter in the containerizer launcher.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68022/#review209888 --- FAIL: Failed to apply the dependent review: 67844. Failed

Re: Review Request 69075: Updated docker image fetcher to enforce HTTP 1.1 where needed.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69075/#review209887 --- FAIL: Some of the unit tests failed. Please check the relevant

Re: Review Request 68017: Added Seccomp-related protobuf messages.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68017/#review209886 --- include/mesos/mesos.proto Lines 3085 (patched)

Re: Review Request 68018: Added `SeccompFilter` class.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68018/#review209885 --- src/linux/seccomp/seccomp.cpp Lines 21 (patched)

Re: Review Request 68956: Add a flag to toggle per-framework metrics.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68956/#review209878 --- In the discussion on Slack we talked about adding some

Re: Review Request 68019: Added a parser for the Docker Seccomp config format.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68019/ --- (Updated Oct. 22, 2018, 5:04 p.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 68016: Added libseccomp to the build.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68016/ --- (Updated Oct. 22, 2018, 5:04 p.m.) Review request for mesos, Andrew

Re: Review Request 68957: Add documentation for per-framework metrics flag.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68957/#review209877 --- docs/configuration/master.md Lines 669 (patched)

Re: Review Request 68957: Add documentation for per-framework metrics flag.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68957/#review209876 --- docs/configuration/master.md Lines 672 (patched)

Re: Review Request 69116: Added 'popen_tty' to test util functions for the new CLI.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69116/#review209874 --- Bad patch! Reviews applied: [69116] Failed command:

Re: Review Request 69075: Updated docker image fetcher to enforce HTTP 1.1.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69075/#review209873 --- Fix it, then Ship it! src/uri/fetchers/docker.cpp Lines 124

Re: Review Request 69115: Added test for interactive 'task exec'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69115/#review209871 --- PASS: Mesos patch 69115 was successfully built and tested.

Re: Review Request 69075: Updated docker image fetcher to enforce HTTP 1.1.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69075/ --- (Updated Oct. 22, 2018, 4:22 p.m.) Review request for mesos, Alexander

Re: Review Request 69075: Updated docker image fetcher to enforce HTTP 1.x.

> On Oct. 22, 2018, 4:03 p.m., James Peach wrote: > > src/uri/fetchers/docker.cpp > > Lines 123 (patched) > > > > > > If curl is so old that it doesn't accept the `--http1.1` flags, then > > it's not going to use

Re: Review Request 69075: Updated docker image fetcher to enforce HTTP 1.x.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69075/#review209868 --- src/uri/fetchers/docker.cpp Lines 123 (patched)

Re: Review Request 69110: Added task health check definitions to master API responses.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69110/#review209867 --- Patch looks great! Reviews applied: [69110] Passed command:

Re: Review Request 69115: Added test for interactive 'task exec'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69115/ --- (Updated Oct. 22, 2018, 4:40 p.m.) Review request for mesos and Kevin Klues.

Re: Review Request 69115: Added test for interactive 'task exec'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69115/#review209864 --- src/python/cli_new/lib/cli/tests/task.py Lines 113 (patched)

Re: Review Request 69049: Added test for 'task exec'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69049/#review209862 --- Ship it! Ship It! - Kevin Klues On Okt. 22, 2018, 2:13

Re: Review Request 69049: Added test for 'task exec'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69049/ --- (Updated Oct. 22, 2018, 4:13 p.m.) Review request for mesos and Kevin Klues.

Re: Review Request 69119: Added new CLI constants 'TEST_DIRECTORY' and 'TEST_DATA_DIRECTORY'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69119/#review209860 --- Ship it! Ship It! - Kevin Klues On Okt. 22, 2018, 2:12

Review Request 69119: Added new CLI constants 'TEST_DIRECTORY' and 'TEST_DATA_DIRECTORY'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69119/ --- Review request for mesos and Kevin Klues. Bugs: MESOS-9341

Re: Review Request 69049: Added test for 'task exec'.

> On Okt. 22, 2018, 1:45 nachm., Kevin Klues wrote: > > src/python/cli_new/lib/cli/tests/task.py > > Lines 41 (patched) > > > > > > It seems strange to just assume we are in the correct directory when > > this is

Re: Review Request 69049: Added test for 'task exec'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69049/#review209858 --- src/python/cli_new/lib/cli/tests/data/task/lorem-ipsum.txt Lines

Re: Review Request 69049: Added test for 'task exec'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69049/ --- (Updated Oct. 22, 2018, 3:41 p.m.) Review request for mesos and Kevin Klues.

Re: Review Request 69116: Added 'popen_tty' to test util functions for the new CLI.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69116/#review209855 --- FAIL: Failed to apply the current review. Failed command:

Re: Review Request 69075: Updated docker image fetcher to enforce HTTP 1.x.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69075/#review209854 --- PASS: Mesos patch 69075 was successfully built and tested.

Re: Review Request 69048: Added tenacity to 'pip-requirements' for new CLI.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69048/#review209853 --- Ship it! Ship It! - Kevin Klues On Okt. 22, 2018, 10:31

Re: Review Request 69115: Added test for interactive 'task exec'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69115/#review209852 --- PASS: Mesos patch 69115 was successfully built and tested.

Re: Review Request 69114: Added 'exec_command' to test util functions for the new CLI.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69114/#review209851 --- Ship it! Ship It! - Kevin Klues On Okt. 22, 2018, 1:26

Re: Review Request 69114: Added 'exec_command' to test util functions for the new CLI.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69114/ --- (Updated Oct. 22, 2018, 3:26 p.m.) Review request for mesos and Kevin Klues.

Re: Review Request 69114: Added 'exec_command' to test util functions for the new CLI.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69114/#review209850 --- src/python/cli_new/lib/cli/tests/base.py Lines 462 (patched)

Review Request 69116: Added 'popen_tty' to test util functions for the new CLI.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69116/ --- Review request for mesos and Kevin Klues. Bugs: MESOS-9343

Re: Review Request 69075: Updated docker image fetcher to enforce HTTP 1.x.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69075/#review209845 --- Ship it! Ship It! - Armand Grillet On Oct. 22, 2018, 1:22

Re: Review Request 69049: Added test for 'task exec'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69049/#review209844 --- PASS: Mesos patch 69049 was successfully built and tested.

Review Request 69115: Added test for interactive 'task exec'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69115/ --- Review request for mesos and Kevin Klues. Bugs: MESOS-9342

Re: Review Request 69075: Updated docker image fetcher to enforce HTTP 1.x.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69075/ --- (Updated Oct. 22, 2018, 11:22 a.m.) Review request for mesos, Alexander

Review Request 69049: Added test for 'task exec'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69049/ --- Review request for mesos and Kevin Klues. Bugs: MESOS-9341

Review Request 69048: Added tenacity to 'pip-requirements' for new CLI.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69048/ --- Review request for mesos and Kevin Klues. Bugs: MESOS-9341

Review Request 69114: Added 'exec_command' to test util functions for the new CLI.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69114/ --- Review request for mesos and Kevin Klues. Bugs: MESOS-9341

Re: Review Request 69110: Added task health check definitions to master API responses.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69110/#review209842 --- Fix it, then Ship it! Let's make sure we also add a test for

Re: Review Request 69110: Added task health check definitions to master API responses.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69110/#review209841 --- PASS: Mesos patch 69110 was successfully built and tested.