Re: Review Request 69360: Rewrote test `ConvertPreExistingVolume` for `CREATE_DISK`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69360/#review210592 --- src/tests/storage_local_resource_provider_tests.cpp Line 2655

Re: Review Request 69360: Rewrote test `ConvertPreExistingVolume` for `CREATE_DISK`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69360/#review210592 --- src/tests/storage_local_resource_provider_tests.cpp Line 2655

Re: Review Request 69360: Rewrote test `ConvertPreExistingVolume` for `CREATE_DISK`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69360/#review210592 --- src/tests/storage_local_resource_provider_tests.cpp Line 2655

Re: Review Request 69369: Added collectAuthorizations helper to master.hpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69369/#review210591 --- PASS: Mesos patch 69369 was successfully built and tested.

Re: Review Request 69366: Used `OperationID` instead of `string` in test helpers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69366/#review210590 --- FAIL: Some of the unit tests failed. Please check the relevant

Review Request 69369: Added collectAuthorizations helper to master.hpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69369/ --- Review request for mesos, Alexander Rukletsov, Alexander Rojas, and Benjamin

Review Request 69368: Added test reproducing crash on authorization failure.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69368/ --- Review request for mesos, Alexander Rukletsov, Alexander Rojas, and Benjamin

Re: Review Request 69359: Rewrote test `ReconcileDroppedOperation` for `CREATE_DISK`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69359/#review210588 --- FAIL: Some of the unit tests failed. Please check the relevant

Review Request 69364: Added the `--create_parameters` flag to the test CSI plugin.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69364/ --- Review request for mesos, Benjamin Bannier and Jie Yu. Bugs: MESOS-9275

Review Request 69366: Used `OperationID` instead of `string` in test helpers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69366/ --- Review request for mesos, Benjamin Bannier, Gastón Kleiman, and Greg Mann.

Review Request 69365: Recovered disk through `CREATE_DISK` in test `AgentRegisteredWithNewId`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69365/ --- Review request for mesos, Benjamin Bannier and Jie Yu. Bugs: MESOS-9275

Review Request 69363: Cleaned up `include/mesos/type_utils.hpp`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69363/ --- Review request for mesos and Benjamin Bannier. Bugs: MESOS-9275

Review Request 69362: Checkpointed creation parameters for CSI volumes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69362/ --- Review request for mesos, Benjamin Bannier and Jie Yu. Bugs: MESOS-9275

Review Request 69361: Implemented the new `CREATE_DISK`/`DESTROY_DISK` semantics in SLRP.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69361/ --- Review request for mesos, Benjamin Bannier and Jie Yu. Bugs: MESOS-9275

Review Request 69360: Rewrote test `ConvertPreExistingVolume` for `CREATE_DISK`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69360/ --- Review request for mesos, Benjamin Bannier, James DeFelice, and Jie Yu. Bugs:

Review Request 69359: Rewrote test `ReconcileDroppedOperation` for `CREATE_DISK`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69359/ --- Review request for mesos, Benjamin Bannier, Gastón Kleiman, and Greg Mann.

Re: Review Request 69036: Changed the semantics of `CREATE_DISK` and `DESTROY_DISK` operations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69036/ --- (Updated Nov. 15, 2018, 11:52 p.m.) Review request for mesos, Benjamin

Review Request 69357: Added profiles to storage pools in tests for `CREATE_DISK`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69357/ --- Review request for mesos, Benjamin Bannier, Greg Mann, and Jan Schlicht. Bugs:

Review Request 69356: Added valiadtion for `Offer.Operation.CreateDisk.target_profile`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69356/ --- Review request for mesos, Benjamin Bannier, James DeFelice, and Jie Yu. Bugs:

Re: Review Request 61128: Improved log messages in master when adding/removing tasks/executors.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61128/#review210585 --- FAIL: Some of the unit tests failed. Please check the relevant

Re: Review Request 61128: Improved log messages in master when adding/removing tasks/executors.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61128/ --- (Updated Nov. 15, 2018, 9:40 p.m.) Review request for mesos, Benno Evers and

Re: Review Request 69345: Made non-root containers can access SANDBOX volume of PARENT type.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69345/#review210580 --- PASS: Mesos patch 69345 was successfully built and tested.

Re: Review Request 69345: Made non-root containers can access SANDBOX volume of PARENT type.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69345/ --- (Updated Nov. 15, 2018, 10:51 p.m.) Review request for mesos, Gilbert Song,

Re: Review Request 69345: Made non-root containers can access SANDBOX volume of PARENT type.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69345/#review210575 --- FAIL: Some of the unit tests failed. Please check the relevant

Re: Review Request 69345: Made non-root containers can access SANDBOX volume of PARENT type.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69345/ --- (Updated Nov. 15, 2018, 9:55 p.m.) Review request for mesos, Gilbert Song,

Re: Review Request 69311: Enabled parallel test runner to cmake build.

> On Nov. 13, 2018, 10:48 a.m., Benno Evers wrote: > > src/tests/CMakeLists.txt > > Lines 365 (patched) > > > > > > Does this preserve user-specified `MESOS_GTEST_RUNNER_FLAGS`? Or, the > > other way round, will a

Re: Review Request 69345: Made non-root containers can access SANDBOX volume of PARENT type.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69345/#review210565 --- FAIL: Some of the unit tests failed. Please check the relevant

Re: Review Request 69344: Added volume gid manager to Mesos agent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69344/ --- (Updated Nov. 15, 2018, 5:25 p.m.) Review request for mesos, Gilbert Song,

Review Request 69345: Made non-root containers can access SANDBOX volume of PARENT type.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69345/ --- Review request for mesos, Gilbert Song, Greg Mann, Ilya Pronin, and Jie Yu.

Review Request 69344: Added volume gid manager to Mesos agent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69344/ --- Review request for mesos, Gilbert Song, Greg Mann, Ilya Pronin, and Jie Yu.

Review Request 69342: Added an agent flag `--volume_gid_range`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69342/ --- Review request for mesos, Gilbert Song, Greg Mann, Ilya Pronin, and Jie Yu.