Re: Review Request 69211: Improved the code comments for `getContainerDevicesPath`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69211/#review210618 --- PASS: Mesos patch 69211 was successfully built and tested.

Re: Review Request 69211: Improved the code comments for `getContainerDevicesPath`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69211/ --- (Updated Nov. 17, 2018, 12:50 a.m.) Review request for mesos, Gilbert Song,

Re: Review Request 69086: Moved container root construction to the isolators.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69086/ --- (Updated Nov. 17, 2018, 12:49 a.m.) Review request for mesos, Gilbert Song,

Re: Review Request 69210: Used the MS_SILENT mount flag to elide unwanted logging.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69210/ --- (Updated Nov. 17, 2018, 12:49 a.m.) Review request for mesos, Gilbert Song,

Re: Review Request 69373: Replaced a log consensus `CHECK()` with CHECK_GE()`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69373/#review210617 --- Patch looks great! Reviews applied: [69373] Passed command:

Re: Review Request 69255: Updated PyInstaller requirement for new CLI to support Python 3.7.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69255/#review210616 --- PASS: Mesos patch 69255 was successfully built and tested.

Review Request 69374: Updated new CLI test step to use binary created by PyInstaller.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69374/ --- Review request for mesos, Benjamin Bannier and Kevin Klues. Bugs: MESOS-9370

Re: Review Request 69373: Replaced a log consensus `CHECK()` with CHECK_GE()`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69373/#review210614 --- FAIL: Some of the unit tests failed. Please check the relevant

Re: Review Request 69373: Replaced a log consensus `CHECK()` with CHECK_GE()`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69373/#review210613 --- Ship it! Ship It! - Jiang Yan Xu On Nov. 16, 2018, 11:25

Review Request 69373: Replaced a log consensus `CHECK()` with CHECK_GE()`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69373/ --- Review request for mesos and Jiang Yan Xu. Repository: mesos Description

Re: Review Request 69363: Cleaned up `include/mesos/type_utils.hpp`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69363/#review210609 --- include/mesos/type_utils.hpp Lines 490 (patched)

Re: Review Request 69360: Rewrote test `ConvertPreExistingVolume` for `CREATE_DISK`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69360/#review210605 --- This test does not pass for me, could you fix that?

Re: Review Request 69356: Added valiadtion for `Offer.Operation.CreateDisk.target_profile`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69356/#review210601 --- This patch breaks a number of tests. Could you make sure that

Re: Review Request 69359: Rewrote test `ReconcileDroppedOperation` for `CREATE_DISK`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69359/#review210604 --- Please move these test fixes to the patches causing the failures

Re: Review Request 69357: Added profiles to storage pools in tests for `CREATE_DISK`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69357/#review210603 --- Can you make sure that this patch does not produce any failing

Re: Review Request 69369: Added collectAuthorizations helper to master.hpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69369/#review210598 --- Ship it! Ship It! - Alexander Rojas On Nov. 16, 2018, 2:54

Re: Review Request 69368: Added test reproducing crash on authorization failure.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69368/#review210597 --- Ship it! Ship It! src/tests/master_tests.cpp Lines 10095

Re: Review Request 69366: Used `OperationID` instead of `string` in test helpers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69366/#review210596 --- Fix it, then Ship it! The commit message talks about `profile`