Re: Review Request 69345: Made non-root containers can access SANDBOX_PATH volume of PARENT type.

2018-12-06 Thread Andrei Budnik
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69345/#review211092 --- src/slave/containerizer/mesos/containerizer.cpp Lines 418 (patche

Re: Review Request 67844: Bundled libseccomp v2.3.3 into 3rdparty libraries.

2018-12-06 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67844/#review211099 --- Ship it! Could you post this patch as a github PR? so that I co

Re: Review Request 69098: Added a benchmark to compare quota and nonquota allocation performance.

2018-12-06 Thread Meng Zhu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69098/ --- (Updated Dec. 6, 2018, 2:42 p.m.) Review request for mesos, Benjamin Mahler and

Re: Review Request 69098: Added a benchmark to compare quota and nonquota allocation performance.

2018-12-06 Thread Meng Zhu
> On Dec. 5, 2018, 3:39 p.m., Benjamin Mahler wrote: > > Thanks for updating the test comment and commit description! Much clearer > > now and I think I would understand the need for a separate benchmark it if > > I were coming in fresh. > > > > Did you happen to post perf stacks anywhere? Wi

Review Request 69516: Fixed a flaky test EndpointCreateThenOfferRemove.

2018-12-06 Thread Meng Zhu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69516/ --- Review request for mesos, Benjamin Mahler and Gastón Kleiman. Bugs: MESOS-7971

Re: Review Request 69516: Fixed a flaky test EndpointCreateThenOfferRemove.

2018-12-06 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69516/#review211105 --- PASS: Mesos patch 69516 was successfully built and tested. Review

Re: Review Request 69337: Garbage collected disappeared resource providers from master state.

2018-12-06 Thread Chun-Hung Hsiao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69337/#review211104 --- src/master/master.cpp Lines 8227 (patched)

Re: Review Request 69338: Change agent to not report disconnected resource providers.

2018-12-06 Thread Chun-Hung Hsiao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69338/#review211106 --- src/slave/slave.cpp Line 7595 (original), 7598 (patched)

Re: Review Request 69037: Added an optional `vendor` field to `Resource.DiskInfo.Source`.

2018-12-06 Thread Chun-Hung Hsiao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69037/ --- (Updated Dec. 7, 2018, 4:31 a.m.) Review request for mesos, Benjamin Bannier, J

Review Request 69520: Set up the `Resource.DiskInfo.Source.vendor` field in SLRP.

2018-12-06 Thread Chun-Hung Hsiao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69520/ --- Review request for mesos, Benjamin Bannier, Jie Yu, and Jan Schlicht. Bugs: MES

Review Request 69521: Fixed test `AgentResourceProviderConfigApiTest.Update` for the `vendor` field.

2018-12-06 Thread Chun-Hung Hsiao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69521/ --- Review request for mesos, Benjamin Bannier, Jie Yu, and Jan Schlicht. Bugs: MES

Review Request 69522: Tested the `Resource.DiskInfo.Source.vendor` field in related tests.

2018-12-06 Thread Chun-Hung Hsiao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69522/ --- Review request for mesos, Benjamin Bannier, Jie Yu, and Jan Schlicht. Bugs: MES

Re: Review Request 69522: Tested the `Resource.DiskInfo.Source.vendor` field in related tests.

2018-12-06 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69522/#review211108 --- PASS: Mesos patch 69522 was successfully built and tested. Review