Review Request 69603: Extended `min_allocatable_resources` flag to cover non-scalar resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69603/ --- Review request for mesos and Benjamin Mahler. Bugs: MESOS-9324

Re: Review Request 69541: Added volume gid manager.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69541/ --- (Updated Dec. 20, 2018, 9:35 a.m.) Review request for mesos, Andrei Budnik,

Re: Review Request 69543: Implemented recovery for volume gid manager.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69543/ --- (Updated Dec. 20, 2018, 9:36 a.m.) Review request for mesos, Andrei Budnik,

Re: Review Request 69398: Added validation for framework IDs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69398/#review211450 --- Ship it! Ship It! - Benjamin Mahler On Dec. 17, 2018, 8:43

Re: Review Request 69557: Tested framework subscription with set but empty ID.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69557/#review211449 --- Ship it! src/tests/master_tests.cpp Lines 6488-6490 (patched)

Review Request 69601: Added a `Resources` method `contains(ResourceQuantities)`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69601/ --- Review request for mesos and Benjamin Mahler. Repository: mesos Description

Review Request 69600: Added tests for class `Quantity` and `ResourceQuantities`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69600/ --- Review request for mesos and Benjamin Mahler. Repository: mesos Description

Review Request 69599: Added a new class `ResourceQuantities`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69599/ --- Review request for mesos and Benjamin Mahler. Repository: mesos Description

Re: Review Request 69588: Removed outdated authorization logic for offer operations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69588/ --- (Updated Dec. 19, 2018, 11:20 p.m.) Review request for mesos, Benjamin

Re: Review Request 69584: Relaxed matching criteria for test filters.

> On Dec. 18, 2018, 6:44 p.m., Meng Zhu wrote: > > Not quite sure about the false positive issue: > > > > "This change is also safe regarding false positives, since our > > naming conventions forbid the matched strings from appearing > > naturally in any test name." > > > > Ah, I wasn't aware

Re: Review Request 69588: Removed outdated authorization logic for offer operations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69588/#review211442 --- Thanks for the cleanup! I found some of the comments potentially

Review Request 69588: Removed outdated authorization logic for offer operations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69588/ --- Review request for mesos, Benjamin Bannier, Benjamin Mahler, Michael Park, and

Re: Review Request 69064: Added unit tests for Master HTTP endpoints.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69064/ --- (Updated Dec. 19, 2018, 6:39 p.m.) Review request for mesos, Alexander

Re: Review Request 69064: Added unit tests for Master HTTP endpoints.

> On Dec. 18, 2018, 8:32 a.m., Greg Mann wrote: > > src/tests/master_load_tests.cpp > > Lines 555 (patched) > > > > > > Can you use some other header to test this case, so that we don't need > > to disable the

Re: Review Request 69575: Send operation feedback when agent was marked as gone.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69575/ --- (Updated Dec. 19, 2018, 5:51 p.m.) Review request for mesos. Summary

Review Request 69597: Remove outstanding operations when removing agents.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69597/ --- Review request for mesos, Gastón Kleiman, Greg Mann, and Joseph Wu.

Re: Review Request 69591: Fixed allocator benchmark names to ensure proper filtering.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69591/#review211437 --- Ship it! Ship It! - Till Toenshoff On Dec. 19, 2018, 6:11

[GitHub] jpeach closed pull request #322: Renamed `CGROUPS_ROOT` to `ROOT_CGROUPS` in tests for consistency.

jpeach closed pull request #322: Renamed `CGROUPS_ROOT` to `ROOT_CGROUPS` in tests for consistency. URL: https://github.com/apache/mesos/pull/322 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance:

[GitHub] abudnik opened a new pull request #322: Renamed `CGROUPS_ROOT` to `ROOT_CGROUPS` in tests for consistency.

abudnik opened a new pull request #322: Renamed `CGROUPS_ROOT` to `ROOT_CGROUPS` in tests for consistency. URL: https://github.com/apache/mesos/pull/322 See summary. This is an automated message from the Apache Git Service.

Re: Review Request 69591: Fixed allocator benchmark names to ensure proper filtering.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69591/#review211434 --- Ship it! Ship It! - Benno Evers On Dec. 19, 2018, 6:11

Re: Review Request 69584: Relaxed matching criteria for test filters.

> On Dec. 18, 2018, 6:44 p.m., Meng Zhu wrote: > > Not quite sure about the false positive issue: > > > > "This change is also safe regarding false positives, since our > > naming conventions forbid the matched strings from appearing > > naturally in any test name." > > > > Ah, I wasn't aware

Re: Review Request 69064: Added unit tests for Master HTTP endpoints.

> On Dec. 18, 2018, 8:32 a.m., Greg Mann wrote: > > src/tests/master_load_tests.cpp > > Lines 555 (patched) > > > > > > Can you use some other header to test this case, so that we don't need > > to disable the

Re: Review Request 69064: Added unit tests for Master HTTP endpoints.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69064/#review211429 --- src/tests/master_load_tests.cpp Lines 555-556 (patched)

Re: Review Request 69064: Added unit tests for Master HTTP endpoints.

> On Dec. 18, 2018, 8:32 a.m., Greg Mann wrote: > > src/tests/master_load_tests.cpp > > Lines 555 (patched) > > > > > > Can you use some other header to test this case, so that we don't need > > to disable the