Re: Review Request 68016: Added libseccomp to the build.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68016/#review211773 --- src/CMakeLists.txt Lines 55 (patched)

Re: Review Request 69689: Fixed a flaky master volume authorization failure test.

> On Jan. 8, 2019, 12:01 a.m., Meng Zhu wrote: > > Thanks for fixing this! Can you describe what made the test flaky and how > > the patch fixes the issue (similar to your comment in the code)? Thanks for asking for this, I've updated the summary with an explanation of the issue and the fix

Re: Review Request 69689: Fixed a flaky master volume authorization failure test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69689/ --- (Updated Jan. 9, 2019, 2:53 a.m.) Review request for mesos and Meng Zhu.

Review Request 69695: Fixed compile error with Clang 3.5.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69695/ --- Review request for mesos, Chun-Hung Hsiao, Greg Mann, and Vinod Kone.

Re: Review Request 69684: Fixed the FD leak if containerizer::_launch() failed or discarded.

> On Jan. 8, 2019, 5:01 p.m., Meng Zhu wrote: > > > the FD used for signaling from the container process to the IOSB finish > > > redirect will be leaked > > > > Is this description right? I thought what "leaked" are those std* in the > > container IO, not `unblockFds`. IIUC, `unblockFds`

Re: Review Request 69684: Fixed the FD leak if containerizer::_launch() failed or discarded.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69684/#review211770 --- > the FD used for signaling from the container process to the

Review Request 69694: Tester.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69694/ --- Review request for mesos. Repository: mesos Description --- Dont review

Re: Review Request 69684: Fixed the FD leak if containerizer::_launch() failed or discarded.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69684/#review211769 --- Fix it, then Ship it!

Re: Review Request 69064: Added unit tests for Master HTTP endpoints.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69064/ --- (Updated Jan. 8, 2019, 5:01 p.m.) Review request for mesos, Alexander

Re: Review Request 69669: Notified frameworks when operations are marked as unreachable.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69669/#review211765 --- src/master/master.hpp Lines 904 (patched)

Re: Review Request 69582: Added a test to verify a bug fix for the master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69582/#review211764 --- Ship it! Looks good to me, except that the commit message

Re: Review Request 69684: Fixed the FD leak if containerizer::_launch() failed or discarded.

> On Jan. 8, 2019, 8:22 a.m., Gilbert Song wrote: > > src/slave/containerizer/mesos/containerizer.cpp > > Lines 1372 (patched) > > > > > > Two cases: > > > > 1) if `prepare(containerId, None())` fails,

Re: Review Request 69684: Fixed the FD leak if containerizer::_launch() failed or discarded.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69684/#review211756 --- This is a cleaner solution, but a little more implicit. Need