Review Request 69814: Improved the default actions of the mock CSI plugin.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69814/ --- Review request for mesos, Benjamin Bannier, Jie Yu, and Jan Schlicht. Bugs: MES

Re: Review Request 69493: Documented the `linux/seccomp` isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69493/#review212225 --- Fix it, then Ship it! docs/isolators/linux-seccomp.md Lines 44

Review Request 69815: WIP: Added a unit test for RPC retry in SLRP.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69815/ --- Review request for mesos, Benjamin Bannier, Jie Yu, and Jan Schlicht. Bugs: MES

Re: Review Request 69787: Added a proxy mode to the test CSI plugin.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69787/ --- (Updated Jan. 23, 2019, 7:13 a.m.) Review request for mesos, Benjamin Bannier a

Re: Review Request 69787: Added a proxy mode to the test CSI plugin.

> On Jan. 18, 2019, 11:03 a.m., Benjamin Bannier wrote: > > src/examples/test_csi_plugin.cpp > > Lines 970 (patched) > > > > > > Could we give this a better name, e.g., `completionQueue`? That would > > be less gRPC

Review Request 69813: Improved error printing for gRPC statuses.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69813/ --- Review request for mesos, Benjamin Bannier, Jie Yu, and Jan Schlicht. Bugs: MES

Review Request 69812: Implemented the RPC retry logic for SLRP.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69812/ --- Review request for mesos, Benjamin Bannier, Jie Yu, and Jan Schlicht. Bugs: MES

Review Request 69811: Preliminary SLRP refactoring for RPC retry.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69811/ --- Review request for mesos, Benjamin Bannier, Jie Yu, and Jan Schlicht. Bugs: MES

Re: Review Request 69420: Added Seccomp isolator tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69420/#review212216 --- Fix it, then Ship it! src/tests/containerizer/linux_seccomp_is

Re: Review Request 69810: Fixed some typo in agent reboot tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69810/#review212218 --- PASS: Mesos patch 69810 was successfully built and tested. Review

Re: Review Request 69409: Added Seccomp parser tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69409/#review212215 --- Ship it! Ship It! - Qian Zhang On Nov. 20, 2018, 8:21 p.m.,

Re: Review Request 68022: Enabled Seccomp filter in the containerizer launcher.

> On Jan. 22, 2019, 12:31 a.m., Qian Zhang wrote: > > src/slave/containerizer/mesos/launch.cpp > > Line 945 (original), 1028 (patched) > > > > > > So we call `calculateCapabilities` twice in this file, can we merge

Re: Review Request 68022: Enabled Seccomp filter in the containerizer launcher.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68022/#review212210 --- Fix it, then Ship it! src/slave/containerizer/mesos/launch.cpp

Re: Review Request 69809: Fixed a test flakiness in ROOT_CleanupAfterReboot.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69809/#review212211 --- Ship it! Ship It! - Jie Yu On Jan. 23, 2019, 1:15 a.m., Gilb

Review Request 69810: Fixed some typo in agent reboot tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69810/ --- Review request for mesos, Andrei Budnik, Jie Yu, and Qian Zhang. Repository: me

Review Request 69809: Fixed a test flakiness in ROOT_CleanupAfterReboot.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69809/ --- Review request for mesos, Andrei Budnik, Jie Yu, and Qian Zhang. Bugs: MESOS-95

Re: Review Request 69775: Updated master fail() logging from FATAL to ERROR.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69775/#review212209 --- PASS: Mesos patch 69775 was successfully built and tested. Review

Re: Review Request 69792: Added an ostream operator for `Operation`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69792/#review212204 --- src/common/type_utils.cpp Lines 782 (patched)

Re: Review Request 69776: Fixed flakiness by adding per agent config dir for mesos test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69776/ --- (Updated Jan. 22, 2019, 3 p.m.) Review request for mesos, Andrei Budnik, Greg M

Re: Review Request 69793: Added the `ResourceState` agent protobuf message.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69793/#review212205 --- src/Makefile.am Lines 980 (patched)

Re: Review Request 69791: Made it possible to checkpoint resources without downgrading them.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69791/#review212203 --- In commit message: s/atomically checkpoint/atomically checkpointin

Re: Review Request 69790: Fixed a typo.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69790/#review212202 --- Ship it! Ship It! - Greg Mann On Jan. 18, 2019, 10:54 p.m.,

Re: Review Request 69805: Fixed a minor coding error in `createSandboxDirectory`.

> On Jan. 22, 2019, 1:53 p.m., Benjamin Bannier wrote: > > Do you plan to backport this? I am not sure this is a minor error like in > > stated in the comment since it could lead to leaking of private data (see > > comment right above). We should probably also have a proper ticket for this. It

Re: Review Request 69805: Fixed a minor coding error in `createSandboxDirectory`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69805/#review212199 --- Do you plan to backport this? I am not sure this is a minor error

Re: Review Request 69805: Fixed a minor coding error in `createSandboxDirectory`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69805/#review212197 --- Ship it! Ship It! - Gilbert Song On Jan. 22, 2019, 12:58 a.m

Re: Review Request 68021: Added `linux/seccomp` isolator.

> On Jan. 19, 2019, 1:05 a.m., Gilbert Song wrote: > > src/slave/containerizer/mesos/isolators/linux/seccomp.cpp > > Lines 62-63 (patched) > > > > > > I would cache it and just parse the default profile once. Let's

Re: Review Request 69805: Fixed a minor coding error in `createSandboxDirectory`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69805/#review212194 --- PASS: Mesos patch 69805 was successfully built and tested. Review

Re: Review Request 69409: Added Seccomp parser tests.

> On Dec. 28, 2018, 9:39 a.m., Qian Zhang wrote: > > src/tests/containerizer/linux_seccomp_parser_tests.cpp > > Lines 359 (patched) > > > > > > Just a question, where do we check the name of the syscall? It seems >

Review Request 69805: Fixed a minor coding error in `createSandboxDirectory`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69805/ --- Review request for mesos and Gilbert Song. Repository: mesos Description

Re: Review Request 68022: Enabled Seccomp filter in the containerizer launcher.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68022/#review212191 --- src/slave/containerizer/mesos/launch.cpp Line 945 (original), 102