Re: Review Request 70054: Added FrameworkInfo.offer_filters to multi-scheduler scalability docs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70054/#review213208 --- Fix it, then Ship it! docs/app-framework-development-guide.md

Re: Review Request 70054: Added FrameworkInfo.offer_filters to multi-scheduler scalability docs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70054/#review213206 --- Patch looks great! Reviews applied: [70054] Passed command: expo

Re: Review Request 69978: Added garbage collection of terminated operations status update streams.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69978/#review213204 --- Ship it! Ship It! - Greg Mann On Feb. 23, 2019, 1:28 a.m., G

Re: Review Request 68163: Added a test `UNPRIVILEGED_USER_SharedPersistentVolume`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68163/ --- (Updated Feb. 26, 2019, 11:06 a.m.) Review request for mesos, Andrei Budnik, Gi

Re: Review Request 69613: Added tests for volume gid manager.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69613/ --- (Updated Feb. 26, 2019, 11:09 a.m.) Review request for mesos, Andrei Budnik, Gi

Re: Review Request 69676: Implemented recovery for volume gid manager.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69676/ --- (Updated Feb. 26, 2019, 11:02 a.m.) Review request for mesos. Changes ---

Re: Review Request 69579: Added a test `ROOT_UNPRIVILEGED_USER_TaskSandboxLocalPersistentVolume`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69579/ --- (Updated Feb. 26, 2019, 11:08 a.m.) Review request for mesos, Andrei Budnik, Gi

Re: Review Request 69547: Added a test `ROOT_UNPRIVILEGED_USER_TaskSandboxSharedPersistentVolume`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69547/ --- (Updated Feb. 26, 2019, 11:07 a.m.) Review request for mesos, Andrei Budnik, Gi

Re: Review Request 68162: Added a test `ROOT_UNPRIVILEGED_USER_SharedPersistentVolume`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68162/ --- (Updated Feb. 26, 2019, 11:05 a.m.) Review request for mesos, Andrei Budnik, Gi

Re: Review Request 67997: Added a test `ROOT_UNPRIVILEGED_USER_ParentTypeDifferentUser`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67997/ --- (Updated Feb. 26, 2019, 11:03 a.m.) Review request for mesos, Andrei Budnik, Gi

Re: Review Request 69544: Made non-root containers can access shared persistent volume.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69544/ --- (Updated Feb. 26, 2019, 11:01 a.m.) Review request for mesos, Andrei Budnik, Gi

Re: Review Request 69342: Added an agent flag `--volume_gid_range`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69342/ --- (Updated Feb. 26, 2019, 10:50 a.m.) Review request for mesos, Andrei Budnik, Gi

Re: Review Request 69345: Made non-root containers can access PARENT type SANDBOX_PATH volume.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69345/ --- (Updated Feb. 26, 2019, 10:54 a.m.) Review request for mesos, Andrei Budnik, Gi

Re: Review Request 70047: Updated build specific artefact generation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70047/ --- (Updated Feb. 26, 2019, 2:20 a.m.) Review request for mesos, Benjamin Bannier a

Re: Review Request 70047: Updated build specific artefact generation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70047/ --- (Updated Feb. 26, 2019, 2:18 a.m.) Review request for mesos, Benjamin Bannier a

Re: Review Request 70054: Added FrameworkInfo.offer_filters to multi-scheduler scalability docs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70054/#review213202 --- Patch looks great! Reviews applied: [70054] Passed command: expo

Re: Review Request 70053: Used std::string as buffer instead of manually managed dynamic array.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70053/#review213196 --- Patch looks great! Reviews applied: [70046, 70053] Passed comman

Re: Review Request 70016: Supported CUDA 10+ images that are based on nvidia-container-runtime.

> On Feb. 25, 2019, 5:24 p.m., Jie Yu wrote: > > src/slave/containerizer/mesos/isolators/gpu/volume.cpp > > Lines 493 (patched) > > > > > > Can you also add a TODO here about relying on > > `NVIDIA_DRIVER_CAPABILITI

Re: Review Request 70055: Output Review Request URL in Reviewbot output.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70055/#review213194 --- Ship it! Ship It! - Till Toenshoff On Feb. 25, 2019, 11:44 p

Re: Review Request 70053: Used std::string as buffer instead of manually managed dynamic array.

> On Feb. 25, 2019, 10:05 p.m., Benjamin Mahler wrote: > > 3rdparty/stout/include/stout/os/posix/mktemp.hpp > > Lines 39-57 (original), 39-57 (patched) > > > > > > From what I understand, C++11 already guarantees for

Re: Review Request 70053: Used std::string as buffer instead of manually managed dynamic array.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70053/#review213192 --- Patch looks great! Reviews applied: [70046, 70053] Passed comman

Review Request 70055: Output Review Request URL in Reviewbot output.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70055/ --- Review request for mesos, Benjamin Bannier and Till Toenshoff. Repository: meso

Re: Review Request 70040: Added test for terminal operation updates after master failover.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70040/#review213190 --- Patch looks great! Reviews applied: [69968, 69960, 69961, 69962,

Re: Review Request 70040: Added test for terminal operation updates after master failover.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70040/#review213189 --- Fix it, then Ship it! src/tests/storage_local_resource_provide

Review Request 70054: Added FrameworkInfo.offer_filters to multi-scheduler scalability docs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70054/ --- Review request for mesos, Benjamin Bannier and Meng Zhu. Bugs: MESOS-9578 h

Re: Review Request 70053: Used std::string as buffer instead of manually managed dynamic array.

> On Feb. 25, 2019, 11:05 p.m., Benjamin Mahler wrote: > > 3rdparty/stout/include/stout/os/posix/mktemp.hpp > > Lines 39-57 (original), 39-57 (patched) > > > > > > From what I understand, C++11 already guarantees for

Re: Review Request 70053: Used std::string as buffer instead of manually managed dynamic array.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70053/#review213187 --- 3rdparty/stout/include/stout/os/posix/mktemp.hpp Lines 39-57 (ori

Re: Review Request 70046: Prevented closing invalid file descriptors.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70046/#review213186 --- Ship it! Ship It! - Benjamin Mahler On Feb. 25, 2019, 9:19 p

Review Request 70053: Used std::string as buffer instead of manually managed dynamic array.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70053/ --- Review request for mesos and Benjamin Mahler. Repository: mesos Description -

Re: Review Request 70046: Prevented closing invalid file descriptors.

> On Feb. 25, 2019, 6:06 p.m., Benjamin Mahler wrote: > > 3rdparty/stout/include/stout/os/posix/mktemp.hpp > > Line 47 (original), 47 (patched) > > > > > > Can we just simplify this by returning early? > > > >

Re: Review Request 70046: Prevented closing invalid file descriptors.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70046/ --- (Updated Feb. 25, 2019, 10:19 p.m.) Review request for mesos, Benjamin Mahler a

Re: Review Request 70040: Added test for terminal operation updates after master failover.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70040/ --- (Updated Feb. 25, 2019, 1 p.m.) Review request for mesos, Benno Evers, Gastón K

Re: Review Request 69869: Added test for tearing down frameworks while creating disks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69869/ --- (Updated Feb. 25, 2019, 1 p.m.) Review request for mesos, Benno Evers, Gastón K

Re: Review Request 69869: Added test for tearing down frameworks while creating disks.

> On Feb. 25, 2019, 10:59 a.m., Greg Mann wrote: > > src/tests/storage_local_resource_provider_tests.cpp > > Lines 5130 (patched) > > > > > > LAUNCH_GROUP isn't a non-speculative operation; it uses `addTask()` > >

Re: Review Request 69544: Made non-root containers can access shared persistent volume.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69544/#review213182 --- Ship it! Ship It! - Gilbert Song On Jan. 6, 2019, 4:49 p.m.,

Re: Review Request 69345: Made non-root containers can access PARENT type SANDBOX_PATH volume.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69345/#review213181 --- Ship it! Ship It! - Gilbert Song On Jan. 28, 2019, 11:34 p.m

Re: Review Request 69675: Added volume gid manager.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69675/#review213180 --- Ship it! Ship It! - Gilbert Song On Jan. 6, 2019, 4:25 p.m.,

Re: Review Request 69869: Added test for tearing down frameworks while creating disks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69869/#review213179 --- src/tests/storage_local_resource_provider_tests.cpp Lines 5130 (p

Re: Review Request 69872: Accounted for possible lack of OperationID in RP responses.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69872/#review213178 --- Ship it! Ship It! - Greg Mann On Feb. 22, 2019, 12:08 a.m.,

Re: Review Request 70014: Removed operations when removing resource providers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70014/#review213177 --- Ship it! Ship It! - Greg Mann On Feb. 22, 2019, 12:07 a.m.,

Re: Review Request 69980: Modified when master responds to operation status updates.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69980/#review213176 --- Ship it! Ship It! - Greg Mann On Feb. 22, 2019, 12:07 a.m.,

Re: Review Request 69962: Added cleanup logic for orphaned operations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69962/#review213175 --- Ship it! Ship It! - Greg Mann On Feb. 22, 2019, 12:06 a.m.,

Re: Review Request 69960: Added the concept of "orphaned operations" to the master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69960/#review213174 --- Ship it! Ship It! - Greg Mann On Feb. 22, 2019, 12:06 a.m.,

Re: Review Request 70017: Added a unit test to run Tensorflow on a GPU.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70017/#review213172 --- Ship it! Ship It! - Jie Yu On Feb. 20, 2019, 6:27 a.m., Chun

Re: Review Request 70018: Avoided waiting for 180s when test `NvidiaDockerImage` fails.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70018/#review213173 --- Ship it! Ship It! - Jie Yu On Feb. 20, 2019, 6:27 a.m., Chun

Re: Review Request 70016: Supported CUDA 10+ images that are based on nvidia-container-runtime.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70016/#review213171 --- Fix it, then Ship it! src/slave/containerizer/mesos/isolators/

Re: Review Request 70046: Prevented closing invalid file descriptors.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70046/#review213170 --- 3rdparty/stout/include/stout/os/posix/mktemp.hpp Line 47 (origina

Re: Review Request 69544: Made non-root containers can access shared persistent volume.

> On Feb. 25, 2019, 11:43 a.m., Gilbert Song wrote: > > src/slave/containerizer/mesos/isolators/filesystem/linux.cpp > > Lines 889 (patched) > > > > > > we called update in multiple places in slave.cpp, is it true th

Re: Review Request 69675: Added volume gid manager.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69675/#review213164 --- How is this patch related to https://reviews.apache.org/r/69541/ a

Re: Review Request 69676: Implemented recovery for volume gid manager.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69676/#review213166 --- How is this patch related to https://reviews.apache.org/r/69543/?

Re: Review Request 69345: Made non-root containers can access PARENT type SANDBOX_PATH volume.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69345/#review213165 --- How is this patch related to https://reviews.apache.org/r/69542/?

Re: Review Request 69345: Made non-root containers can access PARENT type SANDBOX_PATH volume.

> On Feb. 25, 2019, 11:33 a.m., Gilbert Song wrote: > > src/slave/containerizer/mesos/containerizer.cpp > > Lines 2684 (patched) > > > > > > IIRC, this is because we want to do GID deallocate based on the PARENT >

Re: Review Request 69675: Added volume gid manager.

> On Feb. 23, 2019, 3:02 p.m., Gilbert Song wrote: > > src/slave/volume_gid_manager/volume_gid_manager.cpp > > Lines 212-237 (patched) > > > > > > could we tweak a little bit? > > > > ``` > > for (au