Re: Review Request 69588: Removed outdated authorization logic for offer operations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69588/ --- (Updated March 3, 2019, 6:21 a.m.) Review request for mesos, Benjamin Bannier,

Re: Review Request 69588: Removed outdated authorization logic for offer operations.

> On Jan. 28, 2019, 11:12 a.m., Benjamin Bannier wrote: > > It looks like this patch does clean up semantics around unset role values. > > Looking at e.g., the authz for `UNRESERVE`, when previously a resource was > > unreserved (neither `reservations` nor `role`), we would authorize a > >

Re: Review Request 69588: Removed outdated authorization logic for offer operations.

> On Jan. 15, 2019, 7:27 p.m., Benjamin Mahler wrote: > > src/master/master.cpp > > Line 3818 (original), 3826-3829 (patched) > > > > > > Can you use `Resources::reservationRole` for this? I guess `*` is > >

Re: Review Request 70091: WIP: Added tox invocation to test stage.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70091/#review213360 --- Patch looks great! Reviews applied: [70088, 70089, 70090, 70092,

Re: Review Request 70102: Moved NULL check from cpplint into clang-tidy.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70102/#review213359 --- Patch looks great! Reviews applied: [70088, 70089, 70090, 70092,

Re: Review Request 70088: Initialized pointers with `nullptr` instead of `0`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70088/#review213358 --- Ship it! I'm not sure that `nullptr` makes any difference

Re: Review Request 70085: Fixed a link error on Windows caused by volume gid manager.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70085/#review213357 --- Ship it! Ship It! - Gilbert Song On March 1, 2019, 4:58

Review Request 70102: Moved NULL check from cpplint into clang-tidy.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70102/ --- Review request for mesos, Benjamin Mahler and Tomasz Janiszewski. Repository:

Review Request 70089: Removed non-ascii source code characters.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70089/ --- Review request for mesos and Till Toenshoff. Repository: mesos Description

Review Request 70101: Removed manual author list cpplint.patch.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70101/ --- Review request for mesos and Benjamin Mahler. Repository: mesos Description

Review Request 70097: Reverted untracked and unneeded cpplint modification.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70097/ --- Review request for mesos and Armand Grillet. Repository: mesos Description

Review Request 70099: Parameterized cpplint extension list via config instead of via patch.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70099/ --- Review request for mesos and Benjamin Mahler. Repository: mesos Description

Review Request 70091: WIP: Added tox invocation to test stage.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70091/ --- Review request for mesos and Armand Grillet. Repository: mesos Description

Review Request 70100: Skipped pylint for cpplint.py per config instead of per patch.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70100/ --- Review request for mesos, Armand Grillet and Kevin Klues. Repository: mesos

Review Request 70098: Made cpplint.patch reflect our modifications.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70098/ --- Review request for mesos and Armand Grillet. Repository: mesos Description

Review Request 70096: Moved cpplint configuration into dedicated file.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70096/ --- Review request for mesos and Benjamin Mahler. Repository: mesos Description

Review Request 70093: Added license header to some Python source files.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70093/ --- Review request for mesos, Armand Grillet, haosdent huang, and Steve Niemitz.

Review Request 70095: Fixed cpplint issues in the Java bindings.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70095/ --- Review request for mesos and Gastón Kleiman. Repository: mesos Description

Review Request 70090: Addressed issues flagged by pylint-2.3.0.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70090/ --- Review request for mesos and Armand Grillet. Repository: mesos Description

Review Request 70094: Fixed garbled license header.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70094/ --- Review request for mesos, Jie Yu, Jojy Varghese, and Till Toenshoff.

Review Request 70088: Initialized pointers with `nullptr` instead of `0`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70088/ --- Review request for mesos and James Peach. Repository: mesos Description

Review Request 70092: Updated to pylint-2.3.0.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70092/ --- Review request for mesos and Armand Grillet. Repository: mesos Description

Re: Review Request 70084: Avoid dereferencing removed executors and launching containers for them.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70084/#review213356 --- Patch looks great! Reviews applied: [70080, 70081, 70084]

Re: Review Request 70085: Fixed a link error on Windows caused by volume gid manager.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70085/#review213355 --- Patch looks great! Reviews applied: [70085] Passed command:

Re: Review Request 70082: Converted `UUID` proto messages to `id::UUID` in the RP manager.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70082/#review213354 --- Patch looks great! Reviews applied: [70080, 70081, 70082]

Re: Review Request 54987: Updated `docs/monitoring/md` for new agent event queue metrics.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54987/#review213352 --- Ship it! Simply documenting these is an improvement, so I'm in

Re: Review Request 69971: Removed an outdated comment in SLRP.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69971/#review213351 --- Patch looks great! Reviews applied: [69970, 69971] Passed

Re: Review Request 70067: Added star operator for `Result`, `Try` and `Option`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70067/#review213350 --- 3rdparty/stout/include/stout/result.hpp Lines 142 (patched)

Re: Review Request 69955: Added SLRP unit tests for destroying unpublished persistent volumes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69955/#review213349 --- Bad review! Reviews applied: [69955, 69954, 69403, 69905, 69904,

Re: Review Request 68301: Changed `DEFAULT_EXECUTOR_INFO` to use `default:id`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68301/#review213348 --- Patch looks great! Reviews applied: [68420, 68422, 68375, 68297,

Re: Review Request 68123: Avoided unnecessary `Resources::allocations()` call in the allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68123/#review213347 --- Patch looks great! Reviews applied: [68122, 68123] Passed

Re: Review Request 66881: Added benchmark test for master metrics.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66881/#review213346 --- Bad review! Reviews applied: [66881, 66847, 66846, 66825, 66845]