Re: Review Request 70268: Removed `limits` from `QuotaInfo` and `QuotaRequest` protobuf.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70268/#review213909 --- PASS: Mesos patch 70268 was successfully built and tested. Review

Re: Review Request 70268: Removed `limits` from `QuotaInfo` and `QuotaRequest` protobuf.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70268/#review213911 --- Patch looks great! Reviews applied: [70266, 70267, 70268] Passed

Re: Review Request 70248: Adapted the unversioned `VolumeCapability`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70248/#review213912 --- Bad review! Reviews applied: [70248, 70258, 70247, 70225, 70223,

Re: Review Request 70214: Added skeleton code for v0 `VolumeManager`.

> On March 19, 2019, 3:57 p.m., Benjamin Bannier wrote: > > src/csi/v0_volume_manager.hpp > > Lines 100 (patched) > > > > > > Does it make sense to move this into the process? It would lead to > > simpler dispatch i

Review Request 70275: Added a test ensuring quota capacity check includes disconnected agents.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70275/ --- Review request for mesos and Meng Zhu. Bugs: MESOS-6840 https://issues.apac

Review Request 70279: Updated quota overcommit message to include total quota and capacity.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70279/ --- Review request for mesos, Benno Evers and Meng Zhu. Bugs: MESOS-9292 https:

Review Request 70274: Updated quota capacity check to not exclude disconnected agents.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70274/ --- Review request for mesos and Meng Zhu. Bugs: MESOS-6840 https://issues.apac

Review Request 70272: Eliminate a copy of the master's quota during quota validation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70272/ --- Review request for mesos and Meng Zhu. Repository: mesos Description ---

Review Request 70276: Included RP resources / static reservations in quota capacity check.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70276/ --- Review request for mesos and Meng Zhu. Bugs: MESOS-7883 https://issues.apac

Review Request 70277: Added a test to ensure quota capacity check includes reservations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70277/ --- Review request for mesos and Meng Zhu. Bugs: MESOS-7883 https://issues.apac

Review Request 70278: Added an << operator for ResourceQuantities.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70278/ --- Review request for mesos and Meng Zhu. Repository: mesos Description ---

Review Request 70273: Refactored the quota capcity heuristic check to be a static function.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70273/ --- Review request for mesos and Meng Zhu. Bugs: MESOS-6840 https://issues.apac

Re: Review Request 70266: Removed a lambda to simplify `__allocate()`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70266/#review213915 --- Fix it, then Ship it! src/master/allocator/mesos/hierarchical.

Re: Review Request 70268: Removed `limits` from `QuotaInfo` and `QuotaRequest` protobuf.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70268/#review213916 --- Ship it! Ship It! - Benjamin Mahler On March 22, 2019, 6:13

Re: Review Request 70267: Added more arithmetic operations in class `ResourceQuantities`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70267/#review213917 --- Ship it! Ship It! - Benjamin Mahler On March 22, 2019, 6:13

[GitHub] [mesos] asekretenko opened a new pull request #327: Updated glog to 0.3.5 and then to 0.4.0, added microseconds to LogSink::send().

asekretenko opened a new pull request #327: Updated glog to 0.3.5 and then to 0.4.0, added microseconds to LogSink::send(). URL: https://github.com/apache/mesos/pull/327 Also replaced the `os.path.exists()`-based logic in `ext_modules.py.in` with logic based on automake substitutes. -

Review Request 70282: Added new example framework for operation feedback.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70282/ --- Review request for mesos, Gastón Kleiman, Greg Mann, and Joseph Wu. Repository:

Review Request 70281: Added stream operator overload for OperationStatus messages.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70281/ --- Review request for mesos, Gastón Kleiman, Greg Mann, and Joseph Wu. Repository:

Re: Review Request 70279: Updated quota overcommit message to include total quota and capacity.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70279/#review213922 --- PASS: Mesos patch 70279 was successfully built and tested. Review

Re: Review Request 70279: Updated quota overcommit message to include total quota and capacity.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70279/#review213923 --- Patch looks great! Reviews applied: [70272, 70273, 70274, 70275,

Re: Review Request 70168: Refactored SLRP with `ServiceManager` to manage container lifecycles.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70168/ --- (Updated March 22, 2019, 6:36 p.m.) Review request for mesos, Benjamin Bannier,

Re: Review Request 70282: Added new example framework for operation feedback.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70282/#review213924 --- FAIL: Some of the unit tests failed. Please check the relevant log

Re: Review Request 70248: Adapted the unversioned `VolumeCapability`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70248/#review213925 --- FAIL: Failed to apply the dependent review: 70222. Failed command

Re: Review Request 70169: Refactored SLRP to use `ServiceManager`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70169/#review213926 --- FAIL: Failed to apply the current review. Failed command: `python

Re: Review Request 70214: Added skeleton code for v0 `VolumeManager`.

> On March 19, 2019, 2:57 p.m., Benjamin Bannier wrote: > > src/csi/v0_volume_manager.hpp > > Lines 100 (patched) > > > > > > Does it make sense to move this into the process? It would lead to > > simpler dispatch i

Re: Review Request 70282: Added new example framework for operation feedback.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70282/#review213929 --- Patch looks great! Reviews applied: [70281, 70282] Passed comman

Review Request 70283: Improved handling of resources consumed by orphan operations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70283/ --- Review request for mesos, Benjamin Bannier, Greg Mann, Joseph Wu, and Meng Zhu.

Re: Review Request 70248: Adapted the unversioned `VolumeCapability`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70248/#review213930 --- Bad review! Reviews applied: [70248, 70258, 70247, 70225, 70223,

Re: Review Request 70243: Improved operation reconciliation for unsubscribed resource providers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70243/ --- (Updated March 22, 2019, 9:09 p.m.) Review request for mesos, Benjamin Bannier,

Re: Review Request 70243: Improved operation reconciliation for unsubscribed resource providers.

> On March 21, 2019, 11:18 p.m., Joseph Wu wrote: > > src/resource_provider/manager.cpp > > Lines 626-628 (patched) > > > > > > Is the `SlaveID` field here meant to be blank? I thought only external > > resource pr

Re: Review Request 70243: Improved operation reconciliation for unsubscribed resource providers.

> On March 22, 2019, 1:24 a.m., Gastón Kleiman wrote: > > include/mesos/resource_provider/resource_provider.proto > > Lines 101-104 (patched) > > > > > > I think we should document somewhere (either protos or in the

Re: Review Request 70283: Improved handling of resources consumed by orphan operations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70283/#review213931 --- PASS: Mesos patch 70283 was successfully built and tested. Review

Re: Review Request 70244: Added new operation reconciliation tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70244/#review213932 --- Patch looks great! Reviews applied: [70264, 70242, 70243, 70244]

Re: Review Request 70244: Added new operation reconciliation tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70244/#review213934 --- FAIL: Some of the unit tests failed. Please check the relevant log

Re: Review Request 70216: Cleanup the recovery logic for refactoring SLRP.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70216/ --- (Updated March 22, 2019, 11:31 p.m.) Review request for mesos, Benjamin Bannier

Re: Review Request 70217: Cleanup volume creation, validation and deletion for SLRP.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70217/ --- (Updated March 22, 2019, 11:33 p.m.) Review request for mesos, Benjamin Bannier

Review Request 70284: Cleanup volume and storage pool listing.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70284/ --- Review request for mesos, Benjamin Bannier, Jie Yu, and Jan Schlicht. Bugs: MES

Review Request 70285: Implemented the remaining methods of v0 `VolumeManager`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70285/ --- Review request for mesos, Benjamin Bannier, Jie Yu, and Jan Schlicht. Bugs: MES

Re: Review Request 70248: Adapted the unversioned `VolumeCapability`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70248/#review213936 --- Bad review! Reviews applied: [70248, 70258, 70247, 70225, 70223,

Re: Review Request 70215: Cleanup volume attaching and publishing for SLRP.

> On March 19, 2019, 5:06 p.m., Benjamin Bannier wrote: > > src/csi/v0_volume_manager.cpp > > Lines 146 (patched) > > > > > > `s/sequentialized/serialized/` here and below? > > > > _attaching_ to be consiste

Re: Review Request 70248: Adapted the unversioned `VolumeCapability`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70248/#review213937 --- FAIL: Failed to apply the dependent review: 70222. Failed command

Re: Review Request 70248: Adapted the unversioned `VolumeCapability`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70248/ --- (Updated March 22, 2019, 11:39 p.m.) Review request for mesos, Benjamin Bannier

Re: Review Request 70222: Refactored SLRP to use v0 `VolumeManager`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70222/ --- (Updated March 22, 2019, 11:41 p.m.) Review request for mesos, Benjamin Bannier

Re: Review Request 70283: Improved handling of resources consumed by orphan operations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70283/#review213938 --- As pointed out by Greg earlier, this patch violates the comment he

Re: Review Request 70248: Adapted the unversioned `VolumeCapability`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70248/#review213939 --- PASS: Mesos patch 70248 was successfully built and tested. Review

Re: Review Request 70284: Cleanup volume and storage pool listing.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70284/#review213940 --- PASS: Mesos patch 70284 was successfully built and tested. Review

Re: Review Request 70283: Improved handling of resources consumed by orphan operations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70283/#review213941 --- Patch looks great! Reviews applied: [70283] Passed command: expo

Re: Review Request 70243: Improved operation reconciliation for unsubscribed resource providers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70243/ --- (Updated March 23, 2019, 2:25 a.m.) Review request for mesos, Benjamin Bannier,

Re: Review Request 70244: Added new operation reconciliation tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70244/ --- (Updated March 23, 2019, 2:35 a.m.) Review request for mesos, Benjamin Bannier,

Re: Review Request 70244: Added new operation reconciliation tests.

> On March 21, 2019, 11:39 p.m., Joseph Wu wrote: > > src/tests/operation_reconciliation_tests.cpp > > Lines 1706-1707 (patched) > > > > > > I'm not seeing a clear race in the test body. > > > > The `Update

Re: Review Request 70244: Added new operation reconciliation tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70244/#review213943 --- Patch looks great! Reviews applied: [70264, 70242, 70243, 70244]

Re: Review Request 70244: Added new operation reconciliation tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70244/#review213944 --- PASS: Mesos patch 70244 was successfully built and tested. Review

Re: Review Request 70248: Adapted the unversioned `VolumeCapability`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70248/#review213945 --- Patch looks great! Reviews applied: [70245, 70168, 70213, 70214,