Re: Review Request 70287: Added 'prettyjws' option to docker manifest V2 Schema1 accept header.

2019-03-24 Thread Qian Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70287/#review213968 --- Ship it! Ship It! - Qian Zhang On March 24, 2019, 12:31 p.m.

Re: Review Request 70279: Updated quota overcommit message to include total quota and capacity.

2019-03-24 Thread Meng Zhu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70279/#review213962 --- Fix it, then Ship it! src/master/quota_handler.cpp Lines 223-2

Re: Review Request 70277: Added a test to ensure quota capacity check includes reservations.

2019-03-24 Thread Meng Zhu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70277/#review213960 --- Fix it, then Ship it! In the description: s/This is done by ha

Re: Review Request 70278: Added an << operator for ResourceQuantities.

2019-03-24 Thread Meng Zhu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70278/#review213961 --- Ship it! - Meng Zhu On March 22, 2019, 8:54 a.m., Benjamin Ma

Re: Review Request 70276: Included RP resources / static reservations in quota capacity check.

2019-03-24 Thread Meng Zhu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70276/#review213959 --- Fix it, then Ship it! src/master/master.hpp Lines 1195-1199 (o

Re: Review Request 70275: Added a test ensuring quota capacity check includes disconnected agents.

2019-03-24 Thread Meng Zhu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70275/#review213958 --- Ship it! - Meng Zhu On March 22, 2019, 8:54 a.m., Benjamin Ma

Re: Review Request 70273: Refactored the quota capcity heuristic check to be a static function.

2019-03-24 Thread Meng Zhu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70273/#review213956 --- Ship it! src/master/quota_handler.cpp Lines 226-247 (original)

Re: Review Request 70274: Updated quota capacity check to not exclude disconnected agents.

2019-03-24 Thread Meng Zhu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70274/#review213957 --- Ship it! - Meng Zhu On March 22, 2019, 8:54 a.m., Benjamin Ma

Re: Review Request 70272: Eliminate a copy of the master's quota during quota validation.

2019-03-24 Thread Meng Zhu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70272/#review213955 --- Ship it! Thanks for the cleanup. I think ideally we should jus

Re: Review Request 70291: Added gcr registry test.

2019-03-24 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70291/#review213953 --- FAIL: Some of the unit tests failed. Please check the relevant log