Re: Review Request 70248: Adapted the unversioned `VolumeCapability`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70248/#review214030 --- PASS: Mesos patch 70248 was successfully built and tested. Review

Review Request 70305: Added a `sum` method for `ResourceQuantities`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70305/ --- Review request for mesos and Benjamin Mahler. Repository: mesos Description -

Review Request 70302: Adjusted CSI v0 proto compilation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70302/ --- Review request for mesos, Benjamin Bannier and Joseph Wu. Bugs: MESOS-9624

Re: Review Request 70247: Added an "unversioned" `VolumeCapability`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70247/ --- (Updated March 26, 2019, 5:10 a.m.) Review request for mesos, Benjamin Bannier,

Re: Review Request 70222: Refactored SLRP to use v0 `VolumeManager`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70222/ --- (Updated March 26, 2019, 5:08 a.m.) Review request for mesos, Benjamin Bannier,

Re: Review Request 70248: Adapted the unversioned `VolumeCapability`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70248/#review214027 --- FAIL: Failed to apply the dependent review: 70222. Failed command

Re: Review Request 70214: Added skeleton code for v0 `VolumeManager`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70214/ --- (Updated March 26, 2019, 5:06 a.m.) Review request for mesos, Benjamin Bannier,

Re: Review Request 70213: Added the `VolumeManager` interface to manage CSI volumes.

> On March 19, 2019, 2:42 p.m., Benjamin Bannier wrote: > > src/csi/volume_manager.hpp > > Lines 74-75 (patched) > > > > > > Do we have a chance here to translate from CSI semantics to our own > > semantics instead o

Re: Review Request 70168: Refactored SLRP with `ServiceManager` to manage container lifecycles.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70168/ --- (Updated March 26, 2019, 5 a.m.) Review request for mesos, Benjamin Bannier, Ji

Re: Review Request 70268: Removed `limits` from `QuotaInfo` and `QuotaRequest` protobuf.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70268/#review214021 --- PASS: Mesos patch 70268 was successfully built and tested. Review

Re: Review Request 70295: Enabled launcher sealing for RPM packages.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70295/#review214019 --- support/packaging/centos/mesos.spec Lines 94 (patched)

Re: Review Request 70244: Added new operation reconciliation tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70244/#review214018 --- Ship it! Ship It! - Joseph Wu On March 22, 2019, 7:35 p.m.,

Re: Review Request 70243: Improved operation reconciliation for unsubscribed resource providers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70243/#review214017 --- Ship it! Logically looks sound. Two of the same style nit. s

Re: Review Request 70266: Removed a lambda to simplify `__allocate()`.

> On March 22, 2019, 9 a.m., Benjamin Mahler wrote: > > src/master/allocator/mesos/hierarchical.cpp > > Line 1725 (original), 1711-1712 (patched) > > > > > > Do we need to say tracked by the quota role sorter? The c

Re: Review Request 70279: Updated quota overcommit message to include total quota and capacity.

> On March 24, 2019, 5:08 p.m., Meng Zhu wrote: > > src/master/quota_handler.cpp > > Lines 223-225 (original), 223-228 (patched) > > > > > > The TODO is a good point, I think we can just include the existing > > por

Re: Review Request 70276: Included RP resources / static reservations in quota capacity check.

> On March 24, 2019, 5:06 p.m., Meng Zhu wrote: > > src/master/master.hpp > > Lines 1195-1199 (original), 1195-1199 (patched) > > > > > > Why cut the comments here? I think we should at least mention what we > > ar

Re: Review Request 70242: Tracked operation IDs in the agent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70242/#review214012 --- Ship it! Ship It! - Joseph Wu On March 21, 2019, 3:23 p.m.,

Re: Review Request 70264: Reordered hash definitions in the type utils.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70264/#review214011 --- Ship it! Ship It! - Joseph Wu On March 21, 2019, 3:25 p.m.,

Re: Review Request 70295: Enabled launcher sealing for RPM packages.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70295/#review214010 --- Is our script also building centos6 rpm? Centos 6 does not have th

Re: Review Request 70279: Updated quota overcommit message to include total quota and capacity.

> On March 25, 2019, 12:08 a.m., Meng Zhu wrote: > > src/master/quota_handler.cpp > > Lines 223-225 (original), 223-228 (patched) > > > > > > The TODO is a good point, I think we can just include the existing > > po

Re: Review Request 70276: Included RP resources / static reservations in quota capacity check.

> On March 25, 2019, 12:06 a.m., Meng Zhu wrote: > > src/master/master.hpp > > Lines 1195-1199 (original), 1195-1199 (patched) > > > > > > Why cut the comments here? I think we should at least mention what we > > a

Re: Review Request 70273: Refactored the quota capcity heuristic check to be a static function.

> On March 25, 2019, midnight, Meng Zhu wrote: > > src/master/quota_handler.cpp > > Lines 226-247 (original), 222-243 (patched) > > > > > > We should be able to avoid the copies of agent resources and contains > > c

Re: Review Request 70300: Cleaned up CMakeLists.txt.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70300/#review214004 --- Bad review! Reviews applied: [] Error: No reviewers specified. P

Re: Review Request 70282: Added new example framework for operation feedback.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70282/#review214002 --- Patch looks great! Reviews applied: [70281, 70282] Passed comman

Re: Review Request 70282: Added new example framework for operation feedback.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70282/#review213987 --- Thanks Benno, this looks great!! Some comments below, but the stru

Re: Review Request 70300: Cleaned up CMakeLists.txt.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70300/#review213998 --- FAIL: Failed to apply the dependent review: 70296. Failed command

Re: Review Request 70295: Enabled launcher sealing for RPM packages.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70295/#review213997 --- Patch looks great! Reviews applied: [70295] Passed command: expo

Review Request 70300: Cleaned up CMakeLists.txt.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70300/ --- Review request for mesos. Repository: mesos Description --- Cleaned up C

Review Request 70299: Added microseconds to the LogSink interface.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70299/ --- Review request for mesos. Repository: mesos Description --- Added micros

Review Request 70298: Updated glog to 0.4.0.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70298/ --- Review request for mesos. Repository: mesos Description --- Updated glog

Review Request 70297: Replaced os.path.exists() with a proper check of automake flags.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70297/ --- Review request for mesos. Repository: mesos Description --- Replaced os.

Review Request 70296: Updated glog to 0.3.5 with usecs patch.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70296/ --- Review request for mesos. Repository: mesos Description --- Updated glog

Re: Review Request 70295: Enabled launcher sealing for RPM packages.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70295/#review213996 --- PASS: Mesos patch 70295 was successfully built and tested. Review

Re: Review Request 70217: Cleanup volume creation, validation and deletion for SLRP.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70217/#review213994 --- Ship it! Ship It! - Benjamin Bannier On March 23, 2019, 12:3

Re: Review Request 70294: Removed comment about multiple attempts to remove agents.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70294/#review213993 --- Patch looks great! Reviews applied: [70294] Passed command: expo

Re: Review Request 70294: Removed comment about multiple attempts to remove agents.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70294/#review213992 --- PASS: Mesos patch 70294 was successfully built and tested. Review

Re: Review Request 70272: Eliminate a copy of the master's quota during quota validation.

> On March 24, 2019, 7:46 p.m., Meng Zhu wrote: > > Thanks for the cleanup. > > > > I think ideally we should just keep the `quotaTree` in memory and remove > > the master `quotas` struct (the `quotaTree` could just output a flat > > hashmap if needed e.g. when recovering the allocator). > > W

Re: Review Request 70282: Added new example framework for operation feedback.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70282/#review213990 --- PASS: Mesos patch 70282 was successfully built and tested. Review

Re: Review Request 70215: Cleanup volume attaching and publishing for SLRP.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70215/#review213981 --- Fix it, then Ship it! src/resource_provider/storage/provider.c

Review Request 70295: Enabled launcher sealing for RPM packages.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70295/ --- Review request for mesos, Gilbert Song, Joseph Wu, and Till Toenshoff. Reposito

Re: Review Request 70117: Added unit tests for offer operation feedback metrics.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70117/#review213986 --- PASS: Mesos patch 70117 was successfully built and tested. Review

[GitHub] [mesos] asekretenko commented on a change in pull request #327: Updated glog to 0.3.5 and then to 0.4.0, added microseconds to LogSink::send().

asekretenko commented on a change in pull request #327: Updated glog to 0.3.5 and then to 0.4.0, added microseconds to LogSink::send(). URL: https://github.com/apache/mesos/pull/327#discussion_r268676159 ## File path: src/python/native_common/ext_modules.py.in ## @@ -71,75

[GitHub] [mesos] asekretenko commented on a change in pull request #327: Updated glog to 0.3.5 and then to 0.4.0, added microseconds to LogSink::send().

asekretenko commented on a change in pull request #327: Updated glog to 0.3.5 and then to 0.4.0, added microseconds to LogSink::send(). URL: https://github.com/apache/mesos/pull/327#discussion_r268674917 ## File path: src/python/native_common/ext_modules.py.in ## @@ -22,6

[GitHub] [mesos] asekretenko commented on a change in pull request #327: Updated glog to 0.3.5 and then to 0.4.0, added microseconds to LogSink::send().

asekretenko commented on a change in pull request #327: Updated glog to 0.3.5 and then to 0.4.0, added microseconds to LogSink::send(). URL: https://github.com/apache/mesos/pull/327#discussion_r268674213 ## File path: src/python/native_common/ext_modules.py.in ## @@ -71,75

Re: Review Request 70117: Added unit tests for offer operation feedback metrics.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70117/#review213985 --- Patch looks great! Reviews applied: [70115, 70156, 70185, 70116,

Re: Review Request 70282: Added new example framework for operation feedback.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70282/ --- (Updated March 25, 2019, 1:50 p.m.) Review request for mesos, Gastón Kleiman, G

[GitHub] [mesos] asekretenko commented on a change in pull request #327: Updated glog to 0.3.5 and then to 0.4.0, added microseconds to LogSink::send().

asekretenko commented on a change in pull request #327: Updated glog to 0.3.5 and then to 0.4.0, added microseconds to LogSink::send(). URL: https://github.com/apache/mesos/pull/327#discussion_r268630055 ## File path: 3rdparty/CMakeLists.txt ## @@ -379,18 +379,11 @@ if (WI

Review Request 70294: Removed comment about multiple attempts to remove agents.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70294/ --- Review request for mesos, Greg Mann and Neil Conway. Repository: mesos Descri

Re: Review Request 70293: Clarified timeline for advanced contributions.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70293/#review213983 --- PASS: Mesos patch 70293 was successfully built and tested. Review

Re: Review Request 70293: Clarified timeline for advanced contributions.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70293/#review213982 --- Ship it! Ship It! - Jan Schlicht On March 25, 2019, 11:58 a.

[GitHub] [mesos] asekretenko commented on a change in pull request #327: Updated glog to 0.3.5 and then to 0.4.0, added microseconds to LogSink::send().

asekretenko commented on a change in pull request #327: Updated glog to 0.3.5 and then to 0.4.0, added microseconds to LogSink::send(). URL: https://github.com/apache/mesos/pull/327#discussion_r268592665 ## File path: 3rdparty/Makefile.am ## @@ -248,8 +248,17 @@ $(LIB_GLOG

[GitHub] [mesos] asekretenko commented on a change in pull request #327: Updated glog to 0.3.5 and then to 0.4.0, added microseconds to LogSink::send().

asekretenko commented on a change in pull request #327: Updated glog to 0.3.5 and then to 0.4.0, added microseconds to LogSink::send(). URL: https://github.com/apache/mesos/pull/327#discussion_r268605009 ## File path: 3rdparty/CMakeLists.txt ## @@ -379,18 +379,11 @@ if (WI

Re: Review Request 70216: Cleanup the recovery logic for refactoring SLRP.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70216/#review213977 --- Fix it, then Ship it! Thanks for the patch reorganization, this

Re: Review Request 70185: Renamed Master::sendBulkOperationFeedback() function.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70185/ --- (Updated March 25, 2019, 11:38 a.m.) Review request for mesos, Gastón Kleiman,

[GitHub] [mesos] asekretenko commented on a change in pull request #327: Updated glog to 0.3.5 and then to 0.4.0, added microseconds to LogSink::send().

asekretenko commented on a change in pull request #327: Updated glog to 0.3.5 and then to 0.4.0, added microseconds to LogSink::send(). URL: https://github.com/apache/mesos/pull/327#discussion_r268592665 ## File path: 3rdparty/Makefile.am ## @@ -248,8 +248,17 @@ $(LIB_GLOG

Re: Review Request 70293: Clarified timeline for advanced contributions.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70293/#review213978 --- Bad review! Reviews applied: [] Error: No reviewers specified. P

[GitHub] [mesos] asekretenko commented on a change in pull request #327: Updated glog to 0.3.5 and then to 0.4.0, added microseconds to LogSink::send().

asekretenko commented on a change in pull request #327: Updated glog to 0.3.5 and then to 0.4.0, added microseconds to LogSink::send(). URL: https://github.com/apache/mesos/pull/327#discussion_r268587329 ## File path: 3rdparty/glog-0.4.0.patch ## @@ -0,0 +1,244 @@ +diff --

Review Request 70293: Clarified timeline for advanced contributions.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70293/ --- Review request for mesos. Repository: mesos Description --- The previous

[GitHub] [mesos] lava commented on a change in pull request #327: Updated glog to 0.3.5 and then to 0.4.0, added microseconds to LogSink::send().

lava commented on a change in pull request #327: Updated glog to 0.3.5 and then to 0.4.0, added microseconds to LogSink::send(). URL: https://github.com/apache/mesos/pull/327#discussion_r268566685 ## File path: src/python/native_common/ext_modules.py.in ## @@ -71,75 +94,10

[GitHub] [mesos] lava commented on a change in pull request #327: Updated glog to 0.3.5 and then to 0.4.0, added microseconds to LogSink::send().

lava commented on a change in pull request #327: Updated glog to 0.3.5 and then to 0.4.0, added microseconds to LogSink::send(). URL: https://github.com/apache/mesos/pull/327#discussion_r268568866 ## File path: src/python/native_common/ext_modules.py.in ## @@ -71,75 +94,10

[GitHub] [mesos] lava commented on a change in pull request #327: Updated glog to 0.3.5 and then to 0.4.0, added microseconds to LogSink::send().

lava commented on a change in pull request #327: Updated glog to 0.3.5 and then to 0.4.0, added microseconds to LogSink::send(). URL: https://github.com/apache/mesos/pull/327#discussion_r268554431 ## File path: 3rdparty/Makefile.am ## @@ -248,8 +248,17 @@ $(LIB_GLOG): $(GL

[GitHub] [mesos] lava commented on a change in pull request #327: Updated glog to 0.3.5 and then to 0.4.0, added microseconds to LogSink::send().

lava commented on a change in pull request #327: Updated glog to 0.3.5 and then to 0.4.0, added microseconds to LogSink::send(). URL: https://github.com/apache/mesos/pull/327#discussion_r268572596 ## File path: src/python/native_common/ext_modules.py.in ## @@ -71,75 +94,10

[GitHub] [mesos] lava commented on a change in pull request #327: Updated glog to 0.3.5 and then to 0.4.0, added microseconds to LogSink::send().

lava commented on a change in pull request #327: Updated glog to 0.3.5 and then to 0.4.0, added microseconds to LogSink::send(). URL: https://github.com/apache/mesos/pull/327#discussion_r268575980 ## File path: src/python/native_common/ext_modules.py.in ## @@ -22,6 +22,29

[GitHub] [mesos] lava commented on a change in pull request #327: Updated glog to 0.3.5 and then to 0.4.0, added microseconds to LogSink::send().

lava commented on a change in pull request #327: Updated glog to 0.3.5 and then to 0.4.0, added microseconds to LogSink::send(). URL: https://github.com/apache/mesos/pull/327#discussion_r268558424 ## File path: 3rdparty/CMakeLists.txt ## @@ -379,18 +379,11 @@ if (WIN32)

[GitHub] [mesos] lava commented on a change in pull request #327: Updated glog to 0.3.5 and then to 0.4.0, added microseconds to LogSink::send().

lava commented on a change in pull request #327: Updated glog to 0.3.5 and then to 0.4.0, added microseconds to LogSink::send(). URL: https://github.com/apache/mesos/pull/327#discussion_r268567530 ## File path: src/python/native_common/ext_modules.py.in ## @@ -71,75 +94,10

[GitHub] [mesos] lava commented on a change in pull request #327: Updated glog to 0.3.5 and then to 0.4.0, added microseconds to LogSink::send().

lava commented on a change in pull request #327: Updated glog to 0.3.5 and then to 0.4.0, added microseconds to LogSink::send(). URL: https://github.com/apache/mesos/pull/327#discussion_r268579630 ## File path: 3rdparty/glog-0.4.0.patch ## @@ -0,0 +1,244 @@ +diff --git a/c

Re: Review Request 70214: Added skeleton code for v0 `VolumeManager`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70214/#review213975 --- Ship it! - Benjamin Bannier On March 22, 2019, 7:12 a.m., Chu

Re: Review Request 70214: Added skeleton code for v0 `VolumeManager`.

> On March 19, 2019, 3:57 p.m., Benjamin Bannier wrote: > > src/csi/v0_volume_manager.hpp > > Lines 100 (patched) > > > > > > Does it make sense to move this into the process? It would lead to > > simpler dispatch i

Re: Review Request 70213: Added the `VolumeManager` interface to manage CSI volumes.

> On March 19, 2019, 3:42 p.m., Benjamin Bannier wrote: > > src/csi/volume_manager.hpp > > Lines 74-75 (patched) > > > > > > Do we have a chance here to translate from CSI semantics to our own > > semantics instead o

Re: Review Request 70288: Supported docker manifest v2 schema2.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70288/#review213973 --- src/uri/fetchers/docker.cpp Lines 828 (patched)

Re: Review Request 70291: Added gcr registry test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70291/#review213970 --- src/tests/containerizer/provisioner_docker_tests.cpp Lines 634-63

Re: Review Request 70290: Added a unit test for fetching docker manifest v2s2 image.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70290/#review213969 --- I see in the test `INTERNET_CURL_FetchManifest` we have the follow

Re: Review Request 70289: Added a TODO for additional URLs support.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70289/#review213965 --- src/uri/fetchers/docker.cpp Lines 961-962 (patched)

Re: Review Request 70288: Supported docker manifest v2 schema2.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70288/#review213964 --- src/slave/containerizer/mesos/provisioner/docker/registry_puller.