Re: Review Request 69955: WIP: Added SLRP unit tests for destroying unpublished persistent volumes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69955/#review214619 --- FAIL: Some of the unit tests failed. Please check the relevant log

Re: Review Request 69954: Added a SLRP unit test for persistent block volume creation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69954/ --- (Updated April 12, 2019, 3:15 a.m.) Review request for mesos and Benjamin Banni

Re: Review Request 70398: Fixed the URI fetcher image fetch test failure on windows.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70398/ --- (Updated April 11, 2019, 7:58 p.m.) Review request for mesos and Qian Zhang.

Re: Review Request 70446: Added a test `CurlFetcherPluginTest.CURL_ValidUriWithOutputFileName`.

> On April 11, 2019, 6:46 a.m., Gilbert Song wrote: > > are you going to add this option to the docker plugin? I think we can do it later when it is required. - Qian --- This is an automatically generated e-mail. To reply, visit: https:

[GitHub] [mesos] bmahler commented on issue #332: Fix detection of ELFIO header

bmahler commented on issue #332: Fix detection of ELFIO header URL: https://github.com/apache/mesos/pull/332#issuecomment-482404971 @vinodkone it's probably the first time anyone has made use of the flag to use an external elfio lib -

Re: Review Request 69954: Added a SLRP unit test for persistent block volume creation.

> On March 5, 2019, 9:58 a.m., Benjamin Bannier wrote: > > These tests seem to have issues when executed under load. When putting > > extra stress on the system with `stress-ng` I was able to get e.g., > > `CreateDestroyPersistentVolume` to break after only 4 iterations > > ``` > > I0305 10:39:

Re: Review Request 70184: Fixed flakiness in 'RetryRpcWithExponentialBackoff'.

> On March 27, 2019, 5:10 p.m., Chun-Hung Hsiao wrote: > > src/tests/storage_local_resource_provider_tests.cpp > > Lines 4926 (patched) > > > > > > I'm not sure if this is the most appropriate fix before understandi

[GitHub] [mesos] Digital-Chaos opened a new pull request #332: Fix detection of ELFIO header

Digital-Chaos opened a new pull request #332: Fix detection of ELFIO header URL: https://github.com/apache/mesos/pull/332 Build fails to detect system provided ELFIO headers when using `configure --with-elfio` flag. Basically this is the same fix as the patch provided here: [https://issues

Re: Review Request 70449: Avoid publishing resources when an HTTP executor resubscribes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70449/#review214600 --- Patch looks great! Reviews applied: [70449] Passed command: expo

Re: Review Request 70449: Avoid publishing resources when an HTTP executor resubscribes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70449/ --- (Updated April 11, 2019, 3:55 p.m.) Review request for mesos, Benjamin Bannier,

Re: Review Request 70449: Avoid publishing resources when an HTTP executor resubscribes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70449/#review214590 --- FAIL: Some of the unit tests failed. Please check the relevant log

Re: Review Request 70449: Avoid publishing resources when an HTTP executor resubscribes.

> On April 11, 2019, 3:35 p.m., Vinod Kone wrote: > > src/slave/slave.cpp > > Lines 5033 (patched) > > > > > > s/updated/update/ Oops thanks. - Chun-Hung

Re: Review Request 70454: Fixed potential use-after-free bug in storage local resource provider.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70454/#review214587 --- Ship it! Ship It! - Chun-Hung Hsiao On April 11, 2019, 12:55

Re: Review Request 70449: Avoid publishing resources when an HTTP executor resubscribes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70449/#review214586 --- src/slave/slave.cpp Lines 5033 (patched)

Re: Review Request 70454: Fixed potential use-after-free bug in storage local resource provider.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70454/#review214585 --- Patch looks great! Reviews applied: [70454] Passed command: expo

Re: Review Request 70387: Updated the bundled glog to 0.4.0.

> On April 11, 2019, 3:26 p.m., Benjamin Bannier wrote: > > Could one of you please follow up and update > > `support/mesos-tidy/entrypoint.sh`? We currently only run that job against > > `master`. Until it is updated we won't have working `mesos-tidy`. Ups, I see you already did that. I'll re

Re: Review Request 70387: Updated the bundled glog to 0.4.0.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70387/#review214583 --- Could one of you please follow up and update `support/mesos-tidy/

Review Request 70454: Fixed potential use-after-free bug in storage local resource provider.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70454/ --- Review request for mesos and Chun-Hung Hsiao. Bugs: MESOS-9711 https://issu

Re: Review Request 70387: Updated the bundled glog to 0.4.0.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70387/#review214581 --- Ship it! Ship It! - Benno Evers On April 10, 2019, 1:59 p.m.

Re: Review Request 70388: Replaced os.path.exists() with a proper check of automake flags.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70388/#review214580 --- Ship it! Ship It! - Benno Evers On April 11, 2019, 10:11 a.m

Re: Review Request 70388: Replaced os.path.exists() with a proper check of automake flags.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70388/#review214578 --- Patch looks great! Reviews applied: [70387, 70388] Passed comman

[GitHub] [mesos] asekretenko commented on issue #327: Updated glog to 0.3.5 and then to 0.4.0, added microseconds to LogSink::send().

asekretenko commented on issue #327: Updated glog to 0.3.5 and then to 0.4.0, added microseconds to LogSink::send(). URL: https://github.com/apache/mesos/pull/327#issuecomment-482055965 Moved to ASF Reviewboard: https://reviews.apache.org/r/70388/ ---

[GitHub] [mesos] asekretenko closed pull request #327: Updated glog to 0.3.5 and then to 0.4.0, added microseconds to LogSink::send().

asekretenko closed pull request #327: Updated glog to 0.3.5 and then to 0.4.0, added microseconds to LogSink::send(). URL: https://github.com/apache/mesos/pull/327 This is an automated message from the Apache Git Service. To

Re: Review Request 70388: Replaced os.path.exists() with a proper check of automake flags.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70388/ --- (Updated April 11, 2019, 10:11 a.m.) Review request for mesos and Benno Evers.

Re: Review Request 70388: Replaced os.path.exists() with a proper check of automake flags.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70388/ --- (Updated April 11, 2019, 10:10 a.m.) Review request for mesos and Benno Evers.

Re: Review Request 70449: Avoid publishing resources when an HTTP executor resubscribes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70449/#review214576 --- Ship it! The test looks acceptable to me. We would be able to