Re: Review Request 70533: Implemented the UPDATE_FRAMEWORK call.

2019-05-11 Thread Benjamin Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70533/#review215205 --- src/master/master.hpp Lines 665-668 (patched)

Re: Review Request 70534: Added tests for the UPDATE_FRAMEWORK call.

2019-05-11 Thread Benjamin Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70534/#review215206 --- Thanks for the tests! Having a test file just for a specific

Re: Review Request 70532: Added an UPDATE_FRAMEWORK scheduler::Call.

2019-05-11 Thread Benjamin Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70532/#review215204 --- Ship it! Ship It! - Benjamin Mahler On May 10, 2019, 3

Re: Review Request 70530: Refactored Framework updates for the UPDATE_FRAMEWORK call; fixed race.

2019-05-11 Thread Benjamin Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70530/#review215203 --- Thanks for the description! Overall this is looking pretty good,

Re: Review Request 70620: Made SLRP allow changes in volume context.

2019-05-11 Thread James DeFelice
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70620/#review215202 --- src/resource_provider/storage/provider.cpp Lines 1078 (patched)

Re: Review Request 70628: Return 409 if `UPDATE_RESOURCE_PROVIDER_CONFIG` names a missing config.

2019-05-11 Thread James DeFelice
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70628/#review215201 --- Ship it! Ship It! - James DeFelice On May 10, 2019, 11:07