Re: Review Request 70620: Made SLRP allow changes in volume context.

> On May 14, 2019, 10:04 a.m., Benjamin Bannier wrote: > > src/resource_provider/storage/provider.cpp > > Line 923 (original), 930 (patched) > > > > > > Let's create a dedicated error message. Do you mean printing o

Re: Review Request 70620: Made SLRP allow changes in volume context.

> On May 12, 2019, 12:44 a.m., James DeFelice wrote: > > src/resource_provider/storage/provider.cpp > > Lines 1078 (patched) > > > > > > how often are these conversions applied? i suppose it's every time that > > r

Review Request 70686: Added a unit test for master operation authorization.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70686/ --- Review request for mesos, Benjamin Bannier and Greg Mann. Bugs: MESOS-9485

Review Request 70685: Removed the `TaskStatusUpdateIsTerminalState` matcher.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70685/ --- Review request for mesos, Benjamin Bannier and Gilbert Song. Repository: mesos

Review Request 70684: Changed the `*TaskIdEq` test matchers to take a `TaskID`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70684/ --- Review request for mesos, Benjamin Bannier and Greg Mann. Bugs: MESOS-9485

Review Request 70683: Added helpers for evolving operation-related proto messages.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70683/ --- Review request for mesos, Benjamin Bannier and Greg Mann. Bugs: MESOS-9485

Re: Review Request 70651: Notifies master `/api/v1` subscribers about recovered frameworks.

> On May 17, 2019, 10:16 a.m., Greg Mann wrote: > > src/tests/api_tests.cpp > > Lines 2774 (patched) > > > > > > Nit: make this a const ref? > > Chun-Hung Hsiao wrote: > This is copied because `event` is overwr

Re: Review Request 70668: Fixed the race between validating and applying FrameworkInfo updates.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70668/#review215378 --- Ship it! src/master/master.cpp Lines 2777 (patched)

Re: Review Request 70667: Added unit tests for 'framework::validateUpdate()'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70667/#review215377 --- Fix it, then Ship it! src/tests/master_validation_tests.cpp Li

Re: Review Request 70666: Introduced a function for validating a `FrameworkInfo` update.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70666/#review215375 --- Fix it, then Ship it! Looks good, but some clarity in the descr

Re: Review Request 70618: Store framework sorters inside RoleInfos.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70618/#review215376 --- Patch looks great! Reviews applied: [70626, 70591, 70679, 70618]

Re: Review Request 70665: Moved the logic of sending 'Framework' updates into a separate method.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70665/#review215374 --- src/master/master.hpp Lines 667 (patched)

Re: Review Request 70664: Made `activateRecoveredFramework()` return void instead of Nothing().

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70664/#review215372 --- Ship it! Thanks! I was a bit confused at first from the summary

Re: Review Request 70663: Removed non-implemented declaration of 'Master::validate()'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70663/#review215371 --- Ship it! Ship It! - Benjamin Mahler On May 17, 2019, 3:01 p.

Re: Review Request 70618: Store framework sorters inside RoleInfos.

> On May 20, 2019, 12:18 p.m., Meng Zhu wrote: > > src/master/allocator/mesos/hierarchical.cpp > > Line 367 (original), 367 (patched) > > > > > > Not yours, but this could be just a reference? > > > > const

Re: Review Request 70626: Refactored `untrackReservations()` method.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70626/ --- (Updated May 20, 2019, 4:27 p.m.) Review request for mesos and Meng Zhu. Bugs

Re: Review Request 70591: Added `struct RoleInfo` to track role reservations and framework IDs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70591/ --- (Updated May 20, 2019, 4:26 p.m.) Review request for mesos, Benjamin Mahler and

Review Request 70679: Fixed comment to reflect the existence of sorters other than DRF.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70679/ --- Review request for mesos and Meng Zhu. Repository: mesos Description ---

Re: Review Request 70618: Store framework sorters inside RoleInfos.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70618/ --- (Updated May 20, 2019, 4:25 p.m.) Review request for mesos, Benjamin Mahler and

Re: Review Request 70618: Store framework sorters inside RoleInfos.

> On May 20, 2019, 12:18 p.m., Meng Zhu wrote: > > src/master/allocator/mesos/hierarchical.cpp > > Lines 1708-1709 (original), 1706-1709 (patched) > > > > > > The logic here is not related to this patch. > > I a

Re: Review Request 70618: Store framework sorters inside RoleInfos.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70618/#review215354 --- Just a partial review, will post the rest later src/master/alloc

Re: Review Request 70591: Added `struct RoleInfo` to track role reservations and framework IDs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70591/#review215353 --- Much nicer, thanks! src/master/allocator/mesos/hierarchical.hpp

Re: Review Request 70626: Refactored `untrackReservations()` method.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70626/#review215352 --- Fix it, then Ship it! Thanks for the refactoring! src/master/