Re: Review Request 70778: Fixed a deadlock in libprocess.

2019-06-03 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70778/#review215670 --- Patch looks great! Reviews applied: [70778] Passed command:

Review Request 70738: Allow roles to burst up to quota limits in the allocator.

2019-06-03 Thread Meng Zhu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70738/ --- Review request for mesos, Andrei Sekretenko and Benjamin Mahler. Bugs:

Review Request 70780: Added comments on allocating non-scalar resources in the allocator.

2019-06-03 Thread Meng Zhu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70780/ --- Review request for mesos and Benjamin Mahler. Repository: mesos Description

Review Request 70779: Added `<<` operator for `ResourceLimits`.

2019-06-03 Thread Meng Zhu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70779/ --- Review request for mesos and Benjamin Mahler. Repository: mesos Description

Review Request 70778: Fixed a deadlock in libprocess.

2019-06-03 Thread Benjamin Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70778/ --- Review request for mesos, Andrei Sekretenko and Chun-Hung Hsiao. Bugs:

Re: Review Request 70777: WIP: Stopped using rDNS for hostname validation.

2019-06-03 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70777/#review215668 --- Bad review! Reviews applied: [70777, 70749, 70748, 70747]

Re: Review Request 70755: Added tests for the V0 UPDATE_FRAMEWORK scheduler call.

2019-06-03 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70755/#review215667 --- Patch looks great! Reviews applied: [70532, 70663, 70664, 70665,

Re: Review Request 70756: Refactored some of `MasterAPITest`s using MockMasterAPISubscriber.

2019-06-03 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70756/#review215666 --- Patch looks great! Reviews applied: [70532, 70663, 70664, 70665,

Re: Review Request 70766: Fixed chaining futures infinitely in `UriDiskProfileAdaptor`.

2019-06-03 Thread Benjamin Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70766/#review215662 --- Ship it! Ship It! - Benjamin Mahler On May 31, 2019, 3:11

Re: Review Request 70671: Added a class for setting expectations on master V1 API events in tests.

2019-06-03 Thread Andrei Sekretenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70671/ --- (Updated June 3, 2019, 8:28 p.m.) Review request for mesos, Benno Evers,

Re: Review Request 70671: Added a class for setting expectations on master V1 API events in tests.

2019-06-03 Thread Andrei Sekretenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70671/ --- (Updated June 3, 2019, 8:22 p.m.) Review request for mesos, Benno Evers,

Re: Review Request 70755: Added tests for the V0 UPDATE_FRAMEWORK scheduler call.

2019-06-03 Thread Andrei Sekretenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70755/ --- (Updated June 3, 2019, 8:16 p.m.) Review request for mesos, Benjamin Mahler

Re: Review Request 70534: Added tests for the V1 UPDATE_FRAMEWORK call.

2019-06-03 Thread Andrei Sekretenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70534/ --- (Updated June 3, 2019, 8:14 p.m.) Review request for mesos and Benjamin

Re: Review Request 70671: Added a class for setting expectations on master V1 API events in tests.

2019-06-03 Thread Andrei Sekretenko
> On May 29, 2019, 6:02 p.m., Benjamin Mahler wrote: > > src/tests/master/mock_master_api_subscriber.cpp > > Lines 131-134 (patched) > > > > > > If possible, we prefer to use the "managed=true" approach to avoid >

Re: Review Request 70671: Added a class for setting expectations on master V1 API events in tests.

2019-06-03 Thread Andrei Sekretenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70671/ --- (Updated June 3, 2019, 7:55 p.m.) Review request for mesos, Benno Evers,

Re: Review Request 70766: Fixed chaining futures infinitely in `UriDiskProfileAdaptor`.

2019-06-03 Thread Benjamin Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70766/#review215658 --- src/resource_provider/storage/uri_disk_profile_adaptor.hpp Lines

Re: Review Request 70550: Added `UPDATE_QUOTA_WITH_CONFIG` authorization in the local authorizor.

2019-06-03 Thread Benjamin Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70550/#review215656 --- Ship it! src/tests/authorization_tests.cpp Lines 2560-2566

Re: Review Request 70549: Added authorization for `UpdateQuota` call in the master.

2019-06-03 Thread Benjamin Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70549/#review215654 --- Fix it, then Ship it!

Re: Review Request 70690: Added `repeated QuotaConfig` to `QuotaStatus`.

2019-06-03 Thread Benjamin Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70690/#review215653 --- Ship it! Can you file the appropriate ticket for the 2.0 work

Re: Review Request 70777: WIP: Stopped using rDNS for hostname validation.

2019-06-03 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70777/#review215650 --- Bad review! Reviews applied: [70777] Error: 2019-06-03 17:34:47

Review Request 70777: WIP: Stopped using rDNS for hostname validation.

2019-06-03 Thread Benno Evers
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70777/ --- Review request for mesos, Alexander Rukletsov and Benjamin Mahler. Repository:

Re: Review Request 70775: Added `ipc_mode` and `shm_size` fields into `LinuxInfo`.

2019-06-03 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70775/#review215642 --- Patch looks great! Reviews applied: [70773, 70774, 70775]

Re: Review Request 70774: Added `default_shm_size` agent flag.

2019-06-03 Thread Qian Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70774/ --- (Updated June 3, 2019, 2:38 p.m.) Review request for mesos, Andrei Budnik and

Re: Review Request 70773: Added `disallow_sharing_agent_ipc_namespace` agent flag.

2019-06-03 Thread Qian Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70773/ --- (Updated June 3, 2019, 2:38 p.m.) Review request for mesos, Andrei Budnik and

Re: Review Request 70715: Added method `empty()` for `ResourceLimits`.

2019-06-03 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70715/#review215640 --- Bad review! Reviews applied: [70715, 70714, 70713, 70707, 70750]