Review Request 70786: Moved `class ResourceQuantities` to public header.

2019-06-04 Thread Meng Zhu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70786/ --- Review request for mesos and Benjamin Mahler. Repository: mesos Description -

Re: Review Request 70783: Added debug logging for metrics which are slow to become ready.

2019-06-04 Thread Benjamin Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70783/#review215693 --- Looks good, but I'm also wondering if there's a cleaner way to imp

Re: Review Request 70738: Allow roles to burst up to quota limits in the allocator.

2019-06-04 Thread Meng Zhu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70738/ --- (Updated June 4, 2019, 2:15 p.m.) Review request for mesos, Andrei Sekretenko a

Re: Review Request 70783: Added debug logging for metrics which are slow to become ready.

2019-06-04 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70783/#review215689 --- I think it is a little unfortunate that we end up with a condition

Re: Review Request 70738: Allow roles to burst up to quota limits in the allocator.

2019-06-04 Thread Meng Zhu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70738/#review215686 --- src/master/allocator/mesos/hierarchical.cpp Lines 1842-1845 (patc

Re: Review Request 70782: Added a crude probabilistic test for MESOS-9808.

2019-06-04 Thread Benjamin Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70782/#review215687 --- Great work with this test!! We have several fixed several deadloc

Re: Review Request 70778: Fixed a deadlock in libprocess.

2019-06-04 Thread Benjamin Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70778/ --- (Updated June 4, 2019, 8:09 p.m.) Review request for mesos, Andrei Sekretenko a

Re: Review Request 70749: WIP: Use openssl hostname validation.

2019-06-04 Thread Benno Evers
> On June 4, 2019, 11:39 a.m., Alexander Rukletsov wrote: > > 3rdparty/libprocess/src/posix/libevent/libevent_ssl_socket.cpp > > Lines 530-533 (patched) > > > > > > Does it mean that hostname validation with the help

Review Request 70783: Added debug logging for metrics which are slow to become ready.

2019-06-04 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70783/ --- Review request for mesos, Benno Evers, Benjamin Mahler, Joseph Wu, and Vinod Kon

Re: Review Request 70778: Fixed a deadlock in libprocess.

2019-06-04 Thread Andrei Sekretenko
> On June 4, 2019, 1:15 p.m., Andrei Sekretenko wrote: > > 3rdparty/libprocess/src/process.cpp > > Line 3520 (original), 3526 (patched) > > > > > > It turns out that this can also be followed by deleting `event`...

Re: Review Request 70749: WIP: Use openssl hostname validation.

2019-06-04 Thread Benno Evers
> On June 4, 2019, 11:39 a.m., Alexander Rukletsov wrote: > > 3rdparty/libprocess/src/openssl.cpp > > Lines 565-567 (patched) > > > > > > Hm, this is unfortunate. I wonder if we can use > > https://www.openssl.org/d

Re: Review Request 70778: Fixed a deadlock in libprocess.

2019-06-04 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70778/#review215680 --- Thanks for the quick fix Ben!! 3rdparty/libprocess/include/proce

Re: Review Request 70749: WIP: Use openssl hostname validation.

2019-06-04 Thread Benno Evers
> On June 4, 2019, 11:39 a.m., Alexander Rukletsov wrote: > > 3rdparty/libprocess/src/openssl.cpp > > Lines 565-567 (patched) > > > > > > Hm, this is unfortunate. I wonder if we can use > > https://www.openssl.org/d

Re: Review Request 70749: WIP: Use openssl hostname validation.

2019-06-04 Thread Alexander Rukletsov
> On June 4, 2019, 11:39 a.m., Alexander Rukletsov wrote: > > 3rdparty/libprocess/src/posix/libevent/libevent_ssl_socket.cpp > > Lines 530-533 (patched) > > > > > > Does it mean that hostname validation with the help

Re: Review Request 70778: Fixed a deadlock in libprocess.

2019-06-04 Thread Andrei Sekretenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70778/#review215676 --- 3rdparty/libprocess/src/process.cpp Line 3520 (original), 3526 (p

Review Request 70782: Added a crude probabilistic test for MESOS-9808.

2019-06-04 Thread Andrei Sekretenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70782/ --- Review request for mesos, Benjamin Mahler and Chun-Hung Hsiao. Bugs: MESOS-9808

Re: Review Request 70749: WIP: Use openssl hostname validation.

2019-06-04 Thread Benno Evers
> On June 4, 2019, 11:39 a.m., Alexander Rukletsov wrote: > > 3rdparty/libprocess/src/posix/libevent/libevent_ssl_socket.cpp > > Lines 530-533 (patched) > > > > > > Does it mean that hostname validation with the help

Re: Review Request 70749: WIP: Use openssl hostname validation.

2019-06-04 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70749/#review215673 --- 3rdparty/libprocess/src/openssl.cpp Lines 142 (patched)

Re: Review Request 70738: Allow roles to burst up to quota limits in the allocator.

2019-06-04 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70738/#review215672 --- Patch looks great! Reviews applied: [70779, 70780, 70738] Passed