Re: Review Request 70914: Defined `mapped_type` for `ResourceQuantities` and `ResourceLimits`.

> On June 21, 2019, 1:35 p.m., Benjamin Mahler wrote: > > This makes the json serialization pretty implicit, why not just add > > explicit json serialization functions for these types? I'm not that > > familiar with the other implications of adding mapped_type, are you? This would avoid a copy

Re: Review Request 70927: Fixed a memory "leak" of filters in the allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70927/#review216077 --- Fix it, then Ship it! Bar Benjamin's comment, LGTM. src/maste

Re: Review Request 70927: Fixed a memory "leak" of filters in the allocator.

> On June 22, 2019, 1:14 p.m., Benjamin Bannier wrote: > > src/master/allocator/mesos/hierarchical.cpp > > Line 1158 (original), 1164 (patched) > > > > > > While this improves on the previous approach where we poten

Re: Review Request 70927: Fixed a memory "leak" of filters in the allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70927/#review216076 --- src/master/allocator/mesos/hierarchical.cpp Line 1158 (original),