Re: Review Request 71424: Added `SlaveOptions` for wrapping all parameters of `StartSlave`.

2019-09-02 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71424/#review217536 --- Patch looks great! Reviews applied: [71424] Passed command:

Review Request 71424: Added `SlaveOptions` for wrapping all parameters of `StartSlave`.

2019-09-02 Thread Andrei Budnik
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71424/ --- Review request for mesos, Benjamin Bannier, Benno Evers, Benjamin Mahler,

Re: Review Request 71423: Removed legacy docker-build script.

2019-09-02 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71423/#review217535 --- Bad review! Reviews applied: [71423, 71422] Error: 2019-09-02

Re: Review Request 71395: Implemented snapshot bot.

2019-09-02 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71395/#review217534 --- Fix it, then Ship it! support/mesos-snapshot.sh Lines 23

Re: Review Request 71394: Skipped GPG signing for snapshot builds.

2019-09-02 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71394/#review217533 --- Ship it! LGTM, but I think a much preferable approach would

Re: Review Request 71393: Skiped GPG signing during `maven-install` in Makefile.

2019-09-02 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71393/#review217532 --- Ship it! LGTM, but I think a much preferable approach would

Re: Review Request 71392: Improved snapshot script to deduce the Mesos version.

2019-09-02 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71392/#review217530 --- support/snapshot.sh Line 35 (original), 33 (patched)

Re: Review Request 71391: Fixed sed arg to work on Linux and OSX.

2019-09-02 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71391/#review217529 --- Fix it, then Ship it! support/snapshot.sh Line 40 (original),

Re: Review Request 71421: Switched verify-reviews from docker-build to prepared Docker image.

2019-09-02 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71421/#review217531 --- Patch looks great! Reviews applied: [71421] Passed command:

Re: Review Request 71390: Fixed the snapshot script to be non-interactive.

2019-09-02 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71390/#review217528 --- Ship it! Ship It! - Benjamin Bannier On Aug. 28, 2019, 6:38

Review Request 71423: Removed legacy docker-build script.

2019-09-02 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71423/ --- Review request for mesos and Vinod Kone. Repository: mesos Description

Review Request 71422: Added Coverity support to mesos-build.

2019-09-02 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71422/ --- Review request for mesos, Benjamin Bannier and Vinod Kone. Repository: mesos

Review Request 71421: Switched verify-reviews from docker-build to prepared Docker image.

2019-09-02 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71421/ --- Review request for mesos and Benjamin Bannier. Repository: mesos Description

Re: Review Request 71420: Fixed typo in reservation documentation.

2019-09-02 Thread Jan Schlicht
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71420/#review217527 --- Ship it! Ship It! - Jan Schlicht On Sept. 2, 2019, 10:14

Re: Review Request 71419: Fixed anchor name in upgrades guide.

2019-09-02 Thread Jan Schlicht
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71419/#review217526 --- Ship it! Ship It! - Jan Schlicht On Sept. 2, 2019, 10:14

Review Request 71419: Fixed anchor name in upgrades guide.

2019-09-02 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71419/ --- Review request for mesos, Benjamin Mahler, Meng Zhu, and Jan Schlicht.

Review Request 71420: Fixed typo in reservation documentation.

2019-09-02 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71420/ --- Review request for mesos and Jan Schlicht. Repository: mesos Description