[GitHub] [mesos] ArmandGrillet commented on a change in pull request #345: Allow `mesos task exec/attach` for any task_id

ArmandGrillet commented on a change in pull request #345: Allow `mesos task exec/attach` for any task_id URL: https://github.com/apache/mesos/pull/345#discussion_r338908237 ## File path: src/python/cli_new/lib/cli/mesos.py ## @@ -114,25 +114,25 @@ def get_container_id(task

[GitHub] [mesos] ArmandGrillet commented on a change in pull request #345: Allow `mesos task exec/attach` for any task_id

ArmandGrillet commented on a change in pull request #345: Allow `mesos task exec/attach` for any task_id URL: https://github.com/apache/mesos/pull/345#discussion_r338904665 ## File path: src/python/cli_new/lib/cli/http.py ## @@ -41,6 +41,8 @@ def read_endpoint(addr, endpoi

[GitHub] [mesos] ArmandGrillet commented on a change in pull request #345: Allow `mesos task exec/attach` for any task_id

ArmandGrillet commented on a change in pull request #345: Allow `mesos task exec/attach` for any task_id URL: https://github.com/apache/mesos/pull/345#discussion_r338909310 ## File path: src/python/cli_new/lib/cli/mesos.py ## @@ -169,11 +169,11 @@ def __init__(self, master

[GitHub] [mesos] ArmandGrillet commented on a change in pull request #345: Allow `mesos task exec/attach` for any task_id

ArmandGrillet commented on a change in pull request #345: Allow `mesos task exec/attach` for any task_id URL: https://github.com/apache/mesos/pull/345#discussion_r338907494 ## File path: src/python/cli_new/lib/cli/mesos.py ## @@ -114,25 +114,25 @@ def get_container_id(task

Re: Review Request 71673: Got rid of storing totals in the random sorter.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71673/#review218404 --- Fix it, then Ship it! src/master/allocator/mesos/sorter/random

Re: Review Request 71672: Modified Sorter::addSlave()/removeSlave() to accept scalar quantities.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71672/#review218403 --- Fix it, then Ship it! src/master/allocator/mesos/sorter/sorter

Re: Review Request 71673: Got rid of storing totals in the random sorter.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71673/#review218402 --- Patch looks great! Reviews applied: [71646, 71672, 71673] Passed

Re: Review Request 71646: Modified Sorter interface to add/remove agent resources as a whole.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71646/#review218401 --- Ship it! Ship It! - Meng Zhu On Oct. 24, 2019, 9:52 a.m., An

Review Request 71673: Got rid of storing totals in the random sorter.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71673/ --- Review request for mesos, Benjamin Mahler and Meng Zhu. Bugs: MESOS-10015 h

Review Request 71672: Modified Sorter::addSlave()/removeSlave() to accept scalar quantities.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71672/ --- Review request for mesos, Benjamin Mahler and Meng Zhu. Bugs: MESOS-10015 h

Re: Review Request 71646: Modified Sorter interface to add/remove agent resources as a whole.

> On Oct. 23, 2019, 2:31 a.m., Meng Zhu wrote: > > src/master/allocator/mesos/hierarchical.cpp > > Lines 2908-2913 (original), 2908-2913 (patched) > > > > > > maybe we should introduce `updateSlave(slaveId, total)`?

Re: Review Request 71646: Modified Sorter interface to add/remove agent resources as a whole.

> On Oct. 22, 2019, 5:29 p.m., Benjamin Mahler wrote: > > src/master/allocator/mesos/sorter/drf/sorter.cpp > > Lines 456-458 (original), 456-458 (patched) > > > > > > I'm a little puzzled about this case, do we still

Re: Review Request 71646: Modified Sorter interface to add/remove agent resources as a whole.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71646/ --- (Updated Oct. 24, 2019, 4:52 p.m.) Review request for mesos, Benjamin Mahler an

[GitHub] [mesos] bgalek closed pull request #341: Remove unnecessary logging.

bgalek closed pull request #341: Remove unnecessary logging. URL: https://github.com/apache/mesos/pull/341 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use t

Re: Review Request 71639: Added an benchmark for `allocator->UpdateAllocation()`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71639/#review218386 --- Many thanks for this benchmark! Even in its WIP version it already

Re: Review Request 71639: Added an benchmark for `allocator->UpdateAllocation()`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71639/#review218383 --- Bad patch! Reviews applied: [71639] Failed command: ['bash', '-c