Re: Review Request 71782: Moved check on subscriber presences into subscribers.send.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71782/#review218750 --- Patch looks great! Reviews applied: [71780, 71781, 71782]

Re: Review Request 71781: Used a potential use after free bug.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71781/#review218749 --- Ship it! Looks good, but the title line seems to have a typo?

Re: Review Request 71782: Moved check on subscriber presences into subscribers.send.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71782/#review218745 --- Ship it! Ship It! - Benjamin Mahler On Nov. 21, 2019, 9:42

Re: Review Request 71781: Used a potential use after free bug.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71781/#review218744 --- Ship it! Ideally we would have a regression test, but I won't

Re: Review Request 71780: Deferred sending of initial heartbeat to Heartbeater.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71780/#review218743 --- Ship it! Logically looks good, but commit could use more

Re: Review Request 71787: Added end-to-end test for reservation update with persistent volume.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71787/#review218740 --- Patch looks great! Reviews applied: [71785, 71787] Passed

Review Request 71782: Moved check on subscriber presences into subscribers.send.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71782/ --- Review request for mesos, Andrei Sekretenko and Benjamin Mahler. Repository:

Review Request 71780: Deferred sending of initial heartbeat to Heartbeater.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71780/ --- Review request for mesos, Andrei Sekretenko and Benjamin Mahler. Repository:

Review Request 71781: Used a potential use after free bug.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71781/ --- Review request for mesos, Andrei Sekretenko and Benjamin Mahler. Repository:

Re: Review Request 71750: Improved performance of v1 operator API GetAgents call.

> On Nov. 19, 2019, 6:12 p.m., Andrei Sekretenko wrote: > > src/master/http.cpp > > Lines 2242 (patched) > > > > > > Did you consider allocating the `agent` temporaries outside of the > > loops? In my experience,

Re: Review Request 71750: Improved performance of v1 operator API GetAgents call.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71750/#review218736 --- src/master/http.cpp Lines 2142 (patched)

Re: Review Request 71755: Improved performance of v1 operator API GetMetrics call.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71755/#review218735 --- src/master/http.cpp Lines 2445 (patched)

Re: Review Request 71755: Improved performance of v1 operator API GetMetrics call.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71755/#review218719 --- Fix it, then Ship it! Overall looks good to me (and probably

Re: Review Request 71750: Improved performance of v1 operator API GetAgents call.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71750/#review218732 --- src/master/http.cpp Lines 2235-2237 (patched)

Re: Review Request 69423: Added a scheduler test for `UNSUPPRESS` call.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69423/#review218733 --- Bad review! Reviews applied: [69423, 69290, 69289, 69288]