Re: Review Request 71742: Mesos agent shouldn't respond pings if no master is registered

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71742/#review218780 --- Patch looks great! Reviews applied: [71742] Passed command:

Re: Review Request 71663: SSL Wrapper: Windows: Made sure windows.hpp is included before OpenSSL.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71663/#review218779 --- Ship it! Ship It! - Till Toenshoff On Oct. 23, 2019, 7:37

Re: Review Request 71805: Fixed memory leak in openssl verification function.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71805/ --- (Updated Nov. 22, 2019, 10:53 p.m.) Review request for mesos, Benjamin

Re: Review Request 71805: Fixed memory leak in openssl verification function.

> On Nov. 22, 2019, 5:33 p.m., Benjamin Mahler wrote: > > 3rdparty/libprocess/src/openssl.cpp > > Line 843 (original), 843 (patched) > > > > > > This says "if this call succeeds", but I guess it should say in all >

Re: Review Request 71805: Fixed memory leak in openssl verification function.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71805/#review218777 --- Ship it! Ship It! - Greg Mann On Nov. 22, 2019, 4:20 p.m.,

Re: Review Request 71805: Fixed memory leak in openssl verification function.

> On Nov. 22, 2019, 5:33 p.m., Benjamin Mahler wrote: > > 3rdparty/libprocess/src/openssl.cpp > > Line 843 (original), 843 (patched) > > > > > > This says "if this call succeeds", but I guess it should say in all >

Re: Review Request 71742: Mesos agent shouldn't respond pings if no master is registered

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71742/#review218775 --- As we are discussing on slack how to deal with the broken test

Re: Review Request 71742: Mesos agent shouldn't respond pings if no master is registered

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71742/ --- (Updated Nov. 22, 2019, 8 p.m.) Review request for mesos, Benjamin Mahler and

Re: Review Request 71754: Improved performance of v1 operator API GetState call.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71754/#review218773 --- Ship it! Ship It! - Andrei Sekretenko On Nov. 22, 2019,

Re: Review Request 71752: Improved performance of v1 operator API GetExecutors call.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71752/#review218771 --- Ship it! Ship It! - Andrei Sekretenko On Nov. 22, 2019,

Re: Review Request 71753: Improved performance of v1 operator API GetTasks call.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71753/#review218772 --- Ship it! Ship It! - Andrei Sekretenko On Nov. 22, 2019,

Re: Review Request 71751: Improved performance of v1 operator API GetFrameworks call.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71751/#review218770 --- Ship it! Ship It! - Andrei Sekretenko On Nov. 22, 2019,

Re: Review Request 71755: Improved performance of v1 operator API GetMetrics call.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71755/ --- (Updated Nov. 22, 2019, 6:31 p.m.) Review request for mesos, Andrei

Re: Review Request 71755: Improved performance of v1 operator API GetMetrics call.

> On Nov. 21, 2019, 6:02 p.m., Andrei Sekretenko wrote: > > Overall looks good to me (and probably this one is more permanent than > > 71750-71754, as the metrcis have a simple strictire which is not likely to > > change, I'd guess). > > > > Do you have any results of benchmarking

Re: Review Request 71755: Improved performance of v1 operator API GetMetrics call.

> On Nov. 21, 2019, 6:09 p.m., Andrei Sekretenko wrote: > > src/master/http.cpp > > Lines 2445 (patched) > > > > > > `default`? So that we do not rely on content-type validation in > > preceding code. > > > >

Re: Review Request 71753: Improved performance of v1 operator API GetTasks call.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71753/ --- (Updated Nov. 22, 2019, 6:28 p.m.) Review request for mesos, Andrei

Re: Review Request 71754: Improved performance of v1 operator API GetState call.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71754/ --- (Updated Nov. 22, 2019, 6:28 p.m.) Review request for mesos, Andrei

Re: Review Request 71752: Improved performance of v1 operator API GetExecutors call.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71752/ --- (Updated Nov. 22, 2019, 6:28 p.m.) Review request for mesos, Andrei

Re: Review Request 71751: Improved performance of v1 operator API GetFrameworks call.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71751/ --- (Updated Nov. 22, 2019, 6:27 p.m.) Review request for mesos, Andrei

Re: Review Request 71750: Improved performance of v1 operator API GetAgents call.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71750/ --- (Updated Nov. 22, 2019, 6:27 p.m.) Review request for mesos, Andrei

Re: Review Request 71748: Support jsonifying v0 protobuf to v1 protobuf.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71748/ --- (Updated Nov. 22, 2019, 6:16 p.m.) Review request for mesos, Andrei

Re: Review Request 71754: Improved performance of v1 operator API GetState call.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71754/ --- (Updated Nov. 22, 2019, 6:12 p.m.) Review request for mesos, Andrei

Re: Review Request 71753: Improved performance of v1 operator API GetTasks call.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71753/ --- (Updated Nov. 22, 2019, 6:11 p.m.) Review request for mesos, Andrei

Re: Review Request 71752: Improved performance of v1 operator API GetExecutors call.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71752/ --- (Updated Nov. 22, 2019, 6:11 p.m.) Review request for mesos, Andrei

Re: Review Request 71751: Improved performance of v1 operator API GetFrameworks call.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71751/ --- (Updated Nov. 22, 2019, 6:10 p.m.) Review request for mesos, Andrei

Re: Review Request 71750: Improved performance of v1 operator API GetAgents call.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71750/ --- (Updated Nov. 22, 2019, 6:09 p.m.) Review request for mesos, Andrei

Re: Review Request 71749: Added a test for AsV1Protobuf.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71749/ --- (Updated Nov. 22, 2019, 6:08 p.m.) Review request for mesos, Andrei

Re: Review Request 71748: Support jsonifying v0 protobuf to v1 protobuf.

> On Nov. 19, 2019, 5:29 p.m., Andrei Sekretenko wrote: > > src/common/http.cpp > > Lines 177 (patched) > > > > > > Is there any reason not to file a ticket for that and link it here? > > > > This patch

Re: Review Request 71750: Improved performance of v1 operator API GetAgents call.

> On Nov. 21, 2019, 4:45 p.m., Andrei Sekretenko wrote: > > src/master/http.cpp > > Lines 2235-2237 (patched) > > > > > > One more thought after looking at r71751-r71754: it should be possible > > to precalculate

Re: Review Request 71805: Fixed memory leak in openssl verification function.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71805/#review218765 --- Ship it! Good find! Can you file a MESOS ticket for this with

Re: Review Request 71805: Fixed memory leak in openssl verification function.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71805/#review218763 --- 3rdparty/libprocess/src/openssl.cpp Line 866 (original), 866

Review Request 71805: Fixed memory leak in openssl verification function.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71805/ --- Review request for mesos, Benjamin Bannier and Greg Mann. Repository: mesos

Re: Review Request 71741: Updated operator API documention to use rereservation format.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71741/#review218760 --- Bad review! Reviews applied: [71741, 71739, 71725, 71729]

Re: Review Request 71741: Updated operator API documention to use rereservation format.

> On Nov. 20, 2019, 3:41 p.m., Benno Evers wrote: > > docs/operator-http-api.md > > Line 1870 (original), 1872 (patched) > > > > > > Maybe ask a native speaker for a second opinion, but "takes" sounds a > > bit

Re: Review Request 71741: Updated operator API documention to use rereservation format.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71741/ --- (Updated Nov. 22, 2019, 12:55 p.m.) Review request for mesos and Benno Evers.

Re: Review Request 71787: Added end-to-end test for reservation update with persistent volume.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71787/#review218758 --- Ship it! Ship It! - Benjamin Bannier On Nov. 20, 2019, 3:49