Re: Review Request 71865: Moved creating authorization Object out of `Master::authorizeSlave`.

2019-12-03 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71865/#review218906 --- Bad review! Reviews applied: [71865, 71864, 71863, 71862, 71861,

Re: Review Request 71858: WIP: Set resource limits when launching executor container.

2019-12-03 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71858/#review218904 --- Patch looks great! Reviews applied: [71855, 71856, 71858]

Re: Review Request 71852: Used CMake's automatic parallelization in mesos-tidy setup.

2019-12-03 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71852/#review218899 --- Patch looks great! Reviews applied: [71852] Passed command:

Re: Review Request 71664: SSL Wrapper: Implemented BIO for SSL socket wrapper.

2019-12-03 Thread Joseph Wu
> On Nov. 26, 2019, 1:59 p.m., Greg Mann wrote: > > 3rdparty/libprocess/src/ssl/socket_wrapper.cpp > > Lines 212-215 (patched) > > > > > > I wonder if openssl's internal calls to `BIO_flush()` will retry if the > >

Re: Review Request 71827: Improved operator api subscribe initial payload performance.

2019-12-03 Thread Andrei Sekretenko
> On Dec. 2, 2019, 1:23 p.m., Andrei Sekretenko wrote: > > src/master/http.cpp > > Lines 444 (patched) > > > > > > Shouldn't we delete `_getState`, `_getFrameworks` and so on altogether? > > > > They are

Review Request 71867: WIP: Support for docker containerizer.

2019-12-03 Thread Benno Evers
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71867/ --- Review request for mesos and Benjamin Bannier. Repository: mesos Description

Re: Review Request 71836: WIP: Bind-mount domain socket into executor containers.

2019-12-03 Thread Benno Evers
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71836/ --- (Updated Dec. 3, 2019, 6:33 p.m.) Review request for mesos and Benjamin

Review Request 71866: Added new chmod() function to stout.

2019-12-03 Thread Benno Evers
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71866/ --- Review request for mesos, Benjamin Bannier and Benjamin Mahler. Repository:

Re: Review Request 71833: Created unix domain socket on agent startup.

2019-12-03 Thread Benno Evers
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71833/ --- (Updated Dec. 3, 2019, 6:30 p.m.) Review request for mesos and Benjamin

Re: Review Request 71816: WIP: Added domain-socket related flags to Mesos agent.

2019-12-03 Thread Benno Evers
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71816/ --- (Updated Dec. 3, 2019, 6:30 p.m.) Review request for mesos and Benjamin

Re: Review Request 71815: Made the default executors connect via domain sockets if available.

2019-12-03 Thread Benno Evers
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71815/ --- (Updated Dec. 3, 2019, 6:29 p.m.) Review request for mesos and Benjamin

Re: Review Request 71814: Added support for new 'http+unix' URL scheme in libprocess.

2019-12-03 Thread Benno Evers
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71814/ --- (Updated Dec. 3, 2019, 6:27 p.m.) Review request for mesos, Benjamin Bannier

Re: Review Request 71832: Added new issocket() function to stout.

2019-12-03 Thread Benno Evers
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71832/ --- (Updated Dec. 3, 2019, 6:27 p.m.) Review request for mesos, Benjamin Bannier

Review Request 71865: Moved creating authorization Object out of `Master::authorizeSlave`.

2019-12-03 Thread Andrei Sekretenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71865/ --- Review request for mesos, Benjamin Bannier and Benjamin Mahler. Bugs:

Review Request 71864: Moved creating authorization Object out of `Master::authorize*reserve`.

2019-12-03 Thread Andrei Sekretenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71864/ --- Review request for mesos, Benjamin Bannier and Benjamin Mahler. Bugs:

Review Request 71863: Moved creating authorization Object out of `Master::authorize*Volume`.

2019-12-03 Thread Andrei Sekretenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71863/ --- Review request for mesos, Benjamin Bannier and Benjamin Mahler. Bugs:

Review Request 71862: Moved creating authorization Object out of `Master::authorize*Disk`.

2019-12-03 Thread Andrei Sekretenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71862/ --- Review request for mesos, Benjamin Bannier and Benjamin Mahler. Bugs:

Review Request 71861: Moved creating authz Object out of `Master::authorizeResizeVolume`.

2019-12-03 Thread Andrei Sekretenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71861/ --- Review request for mesos, Benjamin Bannier and Benjamin Mahler. Bugs:

Review Request 71860: Moved creating authorization Object out of `Master::authorizeFramework`.

2019-12-03 Thread Andrei Sekretenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71860/ --- Review request for mesos, Benjamin Bannier and Benjamin Mahler. Bugs:

Review Request 71859: Moved creating authorization Object out of `Master::authorizeTask`.

2019-12-03 Thread Andrei Sekretenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71859/ --- Review request for mesos, Benjamin Bannier and Benjamin Mahler. Bugs:

Review Request 71858: WIP: Set resource limits when launching executor container.

2019-12-03 Thread Qian Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71858/ --- Review request for mesos, Andrei Budnik and Greg Mann. Bugs: MESOS-10046

Review Request 71856: Added resource limits into `ContainerConfig`.

2019-12-03 Thread Qian Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71856/ --- Review request for mesos, Andrei Budnik and Greg Mann. Bugs: MESOS-10046

Review Request 71855: Added resource limits into `TaskInfo` and `ExecutorInfo`.

2019-12-03 Thread Qian Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71855/ --- Review request for mesos, Andrei Budnik and Greg Mann. Bugs: MESOS-10043

Review Request 71854: Handled `/api/v1` and /api/v1/executor` over agent executor socket.

2019-12-03 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71854/ --- Review request for mesos and Benno Evers. Bugs: MESOS-10038

Review Request 71853: Constructed `HttpEvent` from owning instead of raw pointers.

2019-12-03 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71853/ --- Review request for mesos and Benno Evers. Repository: mesos Description

Review Request 71852: Used CMake's automatic parallelization in mesos-tidy setup.

2019-12-03 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71852/ --- Review request for mesos and Benno Evers. Repository: mesos Description

Re: Review Request 71825: Updated mesos code to work against recordio encoder/decoder changes.

2019-12-03 Thread Andrei Sekretenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71825/#review218889 --- Ship it! Ship It! - Andrei Sekretenko On Dec. 3, 2019, 5:26

Re: Review Request 71824: Updated stout recordio encoder/decoder to be lower-level.

2019-12-03 Thread Andrei Sekretenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71824/#review21 --- Ship it! Ship It! - Andrei Sekretenko On Dec. 3, 2019, 5:25