Re: Review Request 71790: SSL Socket: Implemented sendfile.

2019-12-05 Thread Greg Mann
> On Nov. 20, 2019, 3:53 a.m., Benjamin Mahler wrote: > > Are you aware of kTLS? > > > > E.g. https://blog.filippo.io/playing-with-kernel-tls-in-linux-4-13-and-go/ > > Greg Mann wrote: > Cool feature!! Although it landed in 4.13, so I don't think we could use > it? Sounds like it's also no

Re: Review Request 71666: SSL Wrapper: Implemented send/recv and shutdown.

2019-12-05 Thread Greg Mann
> On Dec. 5, 2019, 6:38 p.m., Greg Mann wrote: > > 3rdparty/libprocess/src/ssl/socket_wrapper.hpp > > Lines 94 (patched) > > > > > > In this case, we don't really need an actor context, since there isn't > > any acto

Re: Review Request 71666: SSL Wrapper: Implemented send/recv and shutdown.

2019-12-05 Thread Joseph Wu
> On Dec. 5, 2019, 10:38 a.m., Greg Mann wrote: > > 3rdparty/libprocess/src/ssl/socket_wrapper.hpp > > Lines 94 (patched) > > > > > > In this case, we don't really need an actor context, since there isn't > > any act

Re: Review Request 71666: SSL Wrapper: Implemented send/recv and shutdown.

2019-12-05 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71666/#review218948 --- 3rdparty/libprocess/src/ssl/socket_wrapper.hpp Lines 94 (patched)

Re: Review Request 71790: SSL Socket: Implemented sendfile.

2019-12-05 Thread Greg Mann
> On Nov. 20, 2019, 3:53 a.m., Benjamin Mahler wrote: > > Are you aware of kTLS? > > > > E.g. https://blog.filippo.io/playing-with-kernel-tls-in-linux-4-13-and-go/ Cool feature!! Although it landed in 4.13, so I don't think we could use it? Sounds like it's also not full-featured enough to rep

Re: Review Request 71833: Created unix domain socket on agent startup.

2019-12-05 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71833/#review218939 --- src/slave/main.cpp Lines 614 (patched)

Re: Review Request 71882: Added a stout function to compute relative paths.

2019-12-05 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71882/#review218938 --- Bad patch! Reviews applied: [71878, 71879, 71880, 71881, 71882]

Review Request 71878: Added iteration support to stout's Path.

2019-12-05 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71878/ --- Review request for mesos and Benno Evers. Bugs: MESOS-10062 https://issues.

Review Request 71879: Renamed stout's path-related absolute functions to is_absolute.

2019-12-05 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71879/ --- Review request for mesos and Benno Evers. Bugs: MESOS-10062 https://issues.

Review Request 71880: Renamed stout's path-related absolute functions to is_absolute.

2019-12-05 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71880/ --- Review request for mesos and Benno Evers. Bugs: MESOS-10062 https://issues.

Review Request 71881: Allowed specifying path separator in a `path::join` overload.

2019-12-05 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71881/ --- Review request for mesos and Benno Evers. Bugs: MESOS-10062 https://issues.

Review Request 71882: Added a stout function to compute relative paths.

2019-12-05 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71882/ --- Review request for mesos and Benno Evers. Bugs: MESOS-10062 https://issues.

Re: Review Request 71866: Added new chmod() function to stout.

2019-12-05 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71866/#review218937 --- Fix it, then Ship it! 3rdparty/stout/include/stout/os/chmod.hp