Re: Review Request 71790: SSL Socket: Implemented sendfile.

2019-12-16 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71790/#review219042 --- Patch looks great! Reviews applied: [71659, 71764, 71660, 71661,

Re: Review Request 71666: SSL Wrapper: Implemented send/recv and shutdown.

2019-12-16 Thread Joseph Wu
> On Dec. 13, 2019, 11:41 a.m., Greg Mann wrote: > > 3rdparty/libprocess/src/ssl/openssl_socket.cpp > > Lines 478 (patched) > > > > > > Is it possible that a client-initiated renegotiation will lead to an > >

Re: Review Request 71666: SSL Wrapper: Implemented send/recv and shutdown.

2019-12-16 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71666/ --- (Updated Dec. 16, 2019, 2:05 p.m.) Review request for mesos, Benno Evers,

Re: Review Request 71665: SSL Wrapper: Implemented socket connection and handshake.

2019-12-16 Thread Joseph Wu
> On Dec. 12, 2019, 4 p.m., Greg Mann wrote: > > 3rdparty/libprocess/src/ssl/openssl_socket.cpp > > Lines 439 (patched) > > > > > > Why not run these on the per-socket UPID also? The UPID is added next patch. And

Re: Review Request 71665: SSL Wrapper: Implemented socket connection and handshake.

2019-12-16 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71665/ --- (Updated Dec. 16, 2019, 1:58 p.m.) Review request for mesos, Benno Evers,

Re: Review Request 71664: SSL Wrapper: Implemented BIO for SSL socket wrapper.

2019-12-16 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71664/ --- (Updated Dec. 16, 2019, 1:56 p.m.) Review request for mesos, Benno Evers,

Re: Review Request 71916: Removed outdated check assuming no reservations with disks.

2019-12-16 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71916/#review219037 --- Patch looks great! Reviews applied: [71916] Passed command:

Re: Review Request 71916: Removed outdated check assuming no reservations with disks.

2019-12-16 Thread Benno Evers
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71916/#review219036 --- Ship it! Ship It! - Benno Evers On Dec. 16, 2019, 8:20

Review Request 71916: Removed outdated check assuming no reservations with disks.

2019-12-16 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71916/ --- Review request for mesos and Benno Evers. Repository: mesos Description