Re: Review Request 71947: Handled embedded null bytes in abstract domain socket names.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71947/#review219118 --- Patch looks great! Reviews applied: [71947] Passed command:

Review Request 71947: Handled embedded null bytes in abstract domain socket names.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71947/ --- Review request for mesos, Benjamin Bannier and Benjamin Mahler. Repository:

Re: Review Request 71865: Moved creating authorization Object out of `Master::authorizeSlave`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71865/#review219117 --- Patch looks great! Reviews applied: [71859, 71860, 71861, 71862,

Re: Review Request 71864: Moved creating authorization Object out of `Master::authorize*reserve`.

> On Dec. 4, 2019, 8:27 p.m., Benjamin Mahler wrote: > > src/master/authorization.cpp > > Lines 111 (patched) > > > > > > This comment isn't helpful, can you describe what this does? > > > > It seems a lot

Re: Review Request 71863: Moved creating authorization Object out of `Master::authorize*Volume`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71863/ --- (Updated Jan. 2, 2020, 8:37 p.m.) Review request for mesos, Benjamin Bannier

Re: Review Request 71861: Moved creating authz Object out of `Master::authorizeResizeVolume`.

> On Dec. 4, 2019, 7:41 p.m., Benjamin Mahler wrote: > > src/master/authorization.cpp > > Lines 98-100 (patched) > > > > > > everything after "since" is only really relevant to RESERVE or > > UNRESERVE (pushing or

Re: Review Request 71859: Moved creating authorization Object out of `Master::authorizeTask`.

> On Dec. 4, 2019, 6:43 p.m., Benjamin Mahler wrote: > > src/master/authorization.cpp > > Lines 38 (patched) > > > > > > Actually, come to think of it, this construction style seems quite odd? > > > > We're

Re: Review Request 71859: Moved creating authorization Object out of `Master::authorizeTask`.

> On Dec. 4, 2019, 6:59 p.m., Benjamin Mahler wrote: > > Another observation from a subsequent review with: > > > > ``` > > static std::vector growVolume( > > const Offer::Operation::GrowVolume& grow); > > > > static std::vector shrinkVolume( > > const

Re: Review Request 71859: Moved creating authorization Object out of `Master::authorizeTask`.

> On Dec. 4, 2019, 6:21 p.m., Benjamin Mahler wrote: > > src/master/authorization.cpp > > Lines 41-42 (patched) > > > > > > We try in new code to stick to the following assignment style, since it > > works

Re: Review Request 71865: Moved creating authorization Object out of `Master::authorizeSlave`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71865/ --- (Updated Jan. 2, 2020, 8:01 p.m.) Review request for mesos, Benjamin Bannier

Re: Review Request 71863: Moved creating authorization Object out of `Master::authorize*Volume`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71863/ --- (Updated Jan. 2, 2020, 8:01 p.m.) Review request for mesos, Benjamin Bannier

Re: Review Request 71864: Moved creating authorization Object out of `Master::authorize*reserve`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71864/ --- (Updated Jan. 2, 2020, 8:01 p.m.) Review request for mesos, Benjamin Bannier

Re: Review Request 71861: Moved creating authz Object out of `Master::authorizeResizeVolume`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71861/ --- (Updated Jan. 2, 2020, 8:01 p.m.) Review request for mesos, Benjamin Bannier

Re: Review Request 71862: Moved creating authorization Object out of `Master::authorize*Disk`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71862/ --- (Updated Jan. 2, 2020, 8:01 p.m.) Review request for mesos, Benjamin Bannier

Re: Review Request 71860: Moved creating authorization Object out of `Master::authorizeFramework`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71860/ --- (Updated Jan. 2, 2020, 8:01 p.m.) Review request for mesos, Benjamin Bannier

Re: Review Request 71859: Moved creating authorization Object out of `Master::authorizeTask`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71859/ --- (Updated Jan. 2, 2020, 8 p.m.) Review request for mesos, Benjamin Bannier and