Re: Review Request 72018: Windows: Excluded some unix socket code.

2020-01-27 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72018/#review219392 --- Ship it! Ship It! - Greg Mann On Jan. 16, 2020, 6:49 p.m., J

Re: Review Request 72019: Updated master::Call::SUBSCRIBE to be served in parallel.

2020-01-27 Thread Benjamin Mahler
> On Jan. 27, 2020, 7:13 p.m., Andrei Sekretenko wrote: > > src/master/master.hpp > > Lines 1306 (patched) > > > > > > Hmm... to me, "caching of responses" sounds misleading here. > > Yes, `ReadOnlyHandler` is

Re: Review Request 72019: Updated master::Call::SUBSCRIBE to be served in parallel.

2020-01-27 Thread Andrei Sekretenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72019/#review219389 --- Fix it, then Ship it! src/master/master.hpp Lines 1306 (patche

Re: Review Request 71421: Switched verify-reviews from docker-build to prepared Docker image.

2020-01-27 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71421/#review219387 --- Bad patch! Reviews applied: [71421] Failed command: ['bash', '-c

Re: Review Request 71782: Moved check on subscriber presences into subscribers.send.

2020-01-27 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71782/#review219386 --- Bad review! Reviews applied: [71782, 71781, 71780] Error: 2020-0

Re: Review Request 71421: Switched verify-reviews from docker-build to prepared Docker image.

2020-01-27 Thread Andrei Budnik
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71421/#review219385 --- Ship it! Ship It! - Andrei Budnik On Сен. 2, 2019, 9:35 д.п.

Re: Review Request 71421: Switched verify-reviews from docker-build to prepared Docker image.

2020-01-27 Thread Benjamin Bannier
> On Jan. 27, 2020, 4:16 p.m., Andrei Budnik wrote: > > support/verify-reviews.py > > Lines 245-248 (original), 245-248 (patched) > > > > > > Please, update these comments if needed. Just got rid of this comment.

Re: Review Request 71421: Switched verify-reviews from docker-build to prepared Docker image.

2020-01-27 Thread Andrei Budnik
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71421/#review219383 --- support/verify-reviews.py Lines 245-248 (original), 245-248 (patc

Re: Review Request 71421: Switched verify-reviews from docker-build to prepared Docker image.

2020-01-27 Thread Andrei Budnik
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71421/#review219382 --- support/verify-reviews.py Line 258 (original), 258 (patched)