Re: Review Request 74998: [cgroups2] ignore manual enabling of perf_event during Cgroups2IsolatorProcess::prepare

2024-05-20 Thread Benjamin Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74998/#review226473 --- Ship it! src/slave/containerizer/mesos/isolators/cgroups2/cgro

Re: Review Request 74997: [cgroups2] Introduce the PerfEventControllerProcess.

2024-05-20 Thread Benjamin Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74997/#review226472 --- Ship it! made some local formatting only edits src/slave/cont

Re: Review Request 74981: [cgroups2] allow enable() to take in a set instead of string

2024-05-20 Thread Benjamin Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74981/#review226471 --- Fix it, then Ship it! "take in a set instead of string" -> look

Re: Review Request 75003: [cgroups2] fix containerizer::paths::cgroups2::container

2024-05-20 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/75003/#review226468 --- Bad patch! Reviews applied: [75003] Failed command: cd .. && /us

Re: Review Request 75003: [cgroups2] fix containerizer::paths::cgroups2::container

2024-05-20 Thread Jason Zhou
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/75003/ --- (Updated May 20, 2024, 8:54 p.m.) Review request for mesos and Benjamin Mahler.

Review Request 75003: [cgroups2] fix ontainerizer::paths::cgroups2::container

2024-05-20 Thread Jason Zhou
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/75003/ --- Review request for mesos and Benjamin Mahler. Repository: mesos Description -