Re: Review Request 39019: Windows: Added dirent compat code for non-Unix systems.

reflected in iteration 8. - Alex --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39019/#review110101 --- On Dec. 23,

Re: Review Request 39019: Windows: Added dirent compat code for non-Unix systems.

automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39019/#review110101 ------- On Dec. 23, 2015, 2:12 a.m., Alex Clemmer wrote: > > --- > This is an automatically

Re: Review Request 39019: Windows: Added dirent compat code for non-Unix systems.

- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39019/#review111717 --- On Dec. 23, 2015, 2:15 a.m., Alex Clemmer wrote: > > --

Re: Review Request 39019: Windows: Added dirent compat code for non-Unix systems.

/39019/diff/ Testing --- `make check` from autotools on Ubuntu 15. `make check` from CMake on OS X 10.10. Ran `check` project in VS on Windows 10. Thanks, Alex Clemmer

Re: Review Request 39019: Windows: Added dirent compat code for non-Unix systems.

the semnatic of opendir() function? I'm under the > > imression that the first file is found after a susequential readdir() call. > > Is the intent to change the behaviour on Windows? > > Alex Clemmer wrote: > I believe this implementation is correct. The POSIX spe

Re: Review Request 39584: Windows: Implemented `os::rmdir.hpp`.

gt; > > > Consider using ::RemoveDirectory here, which will delete the directory > > when the last handle is closed. Unless that's not the desired behavior... I believe `rmdir` does the same thing, actually. In fact, I remember being unaware of this fact until I

Re: Review Request 39584: Windows: Implemented `os::rmdir.hpp`.

ail. To reply, visit: https://reviews.apache.org/r/39584/#review110385 ------- On Nov. 16, 2015, 9:13 a.m., Alex Clemmer wrote: > > --- > This is an automatically generated e-

Re: Review Request 41425: Fix the Mesos pkg-config.

support at least one other distribution channel (such as NuGet), and possibly many. Can we add `alexnaparu` and `dpravat` to the review and get their feedback as well? - Alex Clemmer On Dec. 22, 2015, 8:45 p.m., James Peach wrote: > > -

Re: Review Request 41424: Install picojson.h if we are using the bundled version.

-- > > (Updated Dec. 22, 2015, 8:44 p.m.) > > > Review request for mesos, Benjamin Hindman, Ben Mahler, Alex Clemmer, Joris > Van Remoortere, Joseph Wu, and Niklas Nielsen. > > > Bugs: MESOS-3909 > https://issues.apache.or

Re: Review Request 41425: Fix the Mesos pkg-config.

> On Dec. 23, 2015, 9:15 p.m., Alex Clemmer wrote: > > Just as a short note here, `pkg-config` doesn't work well with the rest of > > the Windows tool chain, so it's worth wondering what our distribution story > > should be there. > > > > If the con

Re: Review Request 39584: Windows: Implemented `os::rmdir.hpp`.

ps://reviews.apache.org/r/39584/#review109681 ------- On Nov. 16, 2015, 9:13 a.m., Alex Clemmer wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39584/ > -

Re: Review Request 45015: Windows: Fixed bug causing `os::exists` to report invalid paths exist.

------ Thanks, Alex Clemmer

Re: Review Request 45015: Windows: Fixed bug causing `os::exists` to report invalid paths exist.

To reply, visit: https://reviews.apache.org/r/45015/#review124661 ------- On March 24, 2016, 7:58 a.m., Alex Clemmer wrote: > > --- > This is an automatically generated e

Re: Review Request 44084: Windows: Forked os::rename().

/libprocess/3rdparty/stout/include/stout/os/windows/rename.hpp PRE-CREATION 3rdparty/libprocess/3rdparty/stout/tests/os/filesystem_tests.cpp 4c30189bb8261ccfc699da0f31b8b1fd3e9b3c83 Diff: https://reviews.apache.org/r/44084/diff/ Testing --- Thanks, Alex Clemmer

Review Request 45299: Stout:[1/2] transitioned codebase to use `os::pagesize`.

/posix/os.hpp 9ee233b988c08d953e70345c55bcdd5c2f7c101b 3rdparty/libprocess/3rdparty/stout/include/stout/windows/os.hpp 6a391ff198ab724f689bcef79d4e2e05a786cbc2 Diff: https://reviews.apache.org/r/45299/diff/ Testing --- make check Thanks, Alex Clemmer

Review Request 45300: Containerizer:[2/2] Transitioned codebase to use `os::pagesize`.

acaed9b3f8a04964092cef413133834d0cf5a145 src/tests/containerizer/memory_test_helper.cpp 92579a28336b3c15ba7fdbb4a9f769ac7182aeb6 Diff: https://reviews.apache.org/r/45300/diff/ Testing --- make check Thanks, Alex Clemmer

Re: Review Request 44080: Windows:[1/2] Implemented `os::gmtime_r`.

/3rdparty/stout/include/stout/posix/os.hpp 9ee233b988c08d953e70345c55bcdd5c2f7c101b 3rdparty/libprocess/3rdparty/stout/include/stout/windows/os.hpp 6a391ff198ab724f689bcef79d4e2e05a786cbc2 Diff: https://reviews.apache.org/r/44080/diff/ Testing --- Thanks, Alex Clemmer

Re: Review Request 44081: Stout: Moved `os::libraries::` namespace back to `stout/os.hpp`.

-- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44081/#review124257 ------- On March 14, 2016, 9:10 p.m., Alex Clemmer wrote: > > ---

Re: Review Request 44081: Stout: Moved `os::libraries::` namespace back to `stout/os.hpp`.

79e30ca04c6d23f92e3a2f80fbe38ae63fde3520 3rdparty/libprocess/3rdparty/stout/include/stout/posix/os.hpp 9ee233b988c08d953e70345c55bcdd5c2f7c101b Diff: https://reviews.apache.org/r/44081/diff/ Testing --- Thanks, Alex Clemmer

Re: Review Request 44081: Stout: Moved `os::libraries::` namespace back to `stout/os.hpp`.

--- Thanks, Alex Clemmer

Re: Review Request 44082: Stout: Un-commented out functions and marked them as deleted instead.

6a391ff198ab724f689bcef79d4e2e05a786cbc2 Diff: https://reviews.apache.org/r/44082/diff/ Testing --- Thanks, Alex Clemmer

Re: Review Request 44978: Windows: Fixed `fs::list` to be more compliant with POSIX version.

7dace7d579c1b18afcf2278f9689b205cf57877f 3rdparty/libprocess/3rdparty/stout/tests/os/filesystem_tests.cpp 4c30189bb8261ccfc699da0f31b8b1fd3e9b3c83 Diff: https://reviews.apache.org/r/44978/diff/ Testing --- Thanks, Alex Clemmer

Re: Review Request 44084: Windows: Forked os::rename().

/libprocess/3rdparty/stout/include/stout/os/windows/rename.hpp PRE-CREATION 3rdparty/libprocess/3rdparty/stout/tests/os/filesystem_tests.cpp 4c30189bb8261ccfc699da0f31b8b1fd3e9b3c83 Diff: https://reviews.apache.org/r/44084/diff/ Testing --- Thanks, Alex Clemmer

Re: Review Request 45015: Windows: Fixed bug causing `os::exists` to report invalid paths exist.

------ Thanks, Alex Clemmer

Re: Review Request 45022: Windows: Add Windows-friendly implementation of `rm.hpp`.

consistency elsewhere in another comment? - Alex --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45022/#review124879 -------

Re: Review Request 45022: Windows: Add Windows-friendly implementation of `rm.hpp`.

ly generated e-mail. To reply, visit: https://reviews.apache.org/r/45022/#review124867 --- On March 18, 2016, 7:39 a.m., Alex Clemmer wrote: > > --- > This is an auto

Re: Review Request 45022: Windows: Add Windows-friendly implementation of `rm.hpp`.

45022/diff/ Testing --- Thanks, Alex Clemmer

Re: Review Request 45022: Windows: Add Windows-friendly implementation of `rm.hpp`.

45022/diff/ Testing --- Thanks, Alex Clemmer

Re: Review Request 45022: Windows: Add Windows-friendly implementation of `rm.hpp`.

45022/diff/ Testing --- Thanks, Alex Clemmer

Review Request 45888: Stout: Implemented `os::setenv` on Windows.

/45888/diff/ Testing --- Thanks, Alex Clemmer

Re: Review Request 44081: Stout: Moved `os::libraries::` namespace back to `stout/os.hpp`.

79e30ca04c6d23f92e3a2f80fbe38ae63fde3520 3rdparty/libprocess/3rdparty/stout/include/stout/posix/os.hpp 9ee233b988c08d953e70345c55bcdd5c2f7c101b Diff: https://reviews.apache.org/r/44081/diff/ Testing --- Thanks, Alex Clemmer

Review Request 45898: CMake: Place master files that moved into the correct directories.

--- Thanks, Alex Clemmer

Re: Review Request 44081: Stout:[2/2] Moved `os::libraries::` namespace back to `stout/os.hpp`.

--- Thanks, Alex Clemmer

Review Request 45940: Agent:[1/2] Fixed transitive #include problem in `load.cpp`.

o fully address here. Diffs - src/slave/qos_controllers/load.cpp dd44f9209ad283bfea95f16a8c1017e309757f23 Diff: https://reviews.apache.org/r/45940/diff/ Testing ------- Thanks, Alex Clemmer

Review Request 45944: Containerizer:[2/2] Transitioned codebase to use `os::pagesize`.

399218478a596387814d123290eeeb33102fad7a src/tests/containerizer/cgroups_tests.cpp ecd83c7427353790d93e98ab3d62c46a8da43c96 src/tests/containerizer/memory_test_helper.cpp 92579a28336b3c15ba7fdbb4a9f769ac7182aeb6 Diff: https://reviews.apache.org/r/45944/diff/ Testing --- Thanks, Alex Clemmer

Review Request 45943: Stout:[1/2] transitioned codebase to use `os::pagesize`.

c48106e5905e3be0faeba7177ef534766089faff Diff: https://reviews.apache.org/r/45943/diff/ Testing --- Thanks, Alex Clemmer

Re: Review Request 45888: Stout: Implemented `os::setenv` on Windows.

c48106e5905e3be0faeba7177ef534766089faff Diff: https://reviews.apache.org/r/45888/diff/ Testing --- Thanks, Alex Clemmer

Re: Review Request 44082: Stout: Un-commented out functions and marked them as deleted instead.

c48106e5905e3be0faeba7177ef534766089faff Diff: https://reviews.apache.org/r/44082/diff/ Testing --- Thanks, Alex Clemmer

Re: Review Request 44978: Windows: Fixed `fs::list` to be more compliant with POSIX version.

7dace7d579c1b18afcf2278f9689b205cf57877f 3rdparty/libprocess/3rdparty/stout/tests/os/filesystem_tests.cpp 1336972f1f4d8dccdaeb0c9c16b1ba6d255debd8 Diff: https://reviews.apache.org/r/44978/diff/ Testing --- Thanks, Alex Clemmer

Re: Review Request 45943: Stout:[1/2] transitioned codebase to use `os::pagesize`.

/3rdparty/stout/include/stout/windows/os.hpp c48106e5905e3be0faeba7177ef534766089faff Diff: https://reviews.apache.org/r/45943/diff/ Testing --- Thanks, Alex Clemmer

Review Request 45987: Fixed `rmdir.hpp` Windows build breaks.

/stout/tests/os/rmdir_tests.cpp cc92953ccc53f37c54b87e738b16ea1fb521b987 Diff: https://reviews.apache.org/r/45987/diff/ Testing --- Thanks, Alex Clemmer

Review Request 46008: Stout: Initialize Windows socket stack in Stout tests.

/46008/diff/ Testing --- Thanks, Alex Clemmer

Review Request 46010: Stout:[2/2] Added simple process environment tests.

/ Testing --- Thanks, Alex Clemmer

Review Request 46009: Stout:[1/2] Added simple tests for `os::` functions.

--- Thanks, Alex Clemmer

Review Request 46015: Stout:[2/2] Moved process tests to their own file.

217283cd3ce6df699b63dc5b8fb3aab0c6debd04 Diff: https://reviews.apache.org/r/46015/diff/ Testing --- Thanks, Alex Clemmer

Review Request 46014: Stout:[1/2] Moved process tests to their own file.

9bd34c7508cd813c5de18028956f6a740997c266 Diff: https://reviews.apache.org/r/46014/diff/ Testing --- Thanks, Alex Clemmer

Review Request 46013: Stout: Implemented `os::processes` on Windows.

c48106e5905e3be0faeba7177ef534766089faff Diff: https://reviews.apache.org/r/46013/diff/ Testing --- Thanks, Alex Clemmer

Re: Review Request 46013: Stout: Implemented `os::processes` on Windows.

: https://reviews.apache.org/r/46013/diff/ Testing --- Thanks, Alex Clemmer

Re: Review Request 46013: Stout: Implemented `os::processes` on Windows.

: https://reviews.apache.org/r/46013/diff/ Testing --- Thanks, Alex Clemmer

Re: Review Request 46013: Stout: Implemented `os::processes` on Windows.

lude/stout/posix/os.hpp > edaa76a5322d0bf60b7172405aa754b5aca95458 > 3rdparty/libprocess/3rdparty/stout/include/stout/windows/os.hpp > c48106e5905e3be0faeba7177ef534766089faff > > Diff: https://reviews.apache.org/r/46013/diff/ > > > Testing > --- > > > Thanks, > > Alex Clemmer > >

Re: Review Request 46014: Stout:[1/2] Moved process tests to their own file.

/os_tests.cpp 9bd34c7508cd813c5de18028956f6a740997c266 Diff: https://reviews.apache.org/r/46014/diff/ Testing --- Thanks, Alex Clemmer

Re: Review Request 46013: Stout: Implemented `os::processes` on Windows.

: https://reviews.apache.org/r/46013/diff/ Testing --- Thanks, Alex Clemmer

Re: Review Request 46013: Stout: Implemented `os::processes` on Windows.

ally generated e-mail. To reply, visit: https://reviews.apache.org/r/46013/#review128565 ------- On April 13, 2016, 9:33 p.m., Alex Clemmer wrote: > > --- > This is an au

Re: Review Request 46009: Stout:[1/2] Added simple tests for `os::` functions.

://reviews.apache.org/r/46009/diff/ Testing --- Thanks, Alex Clemmer

Re: Review Request 46009: Stout:[1/2] Added simple tests for `os::` functions.

nd more boring. Christmas comes early to the Van Remoortere household! - Alex --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46009/#review128420 -

Re: Review Request 46013: Stout: Implemented `os::processes` on Windows.

Diff: https://reviews.apache.org/r/46013/diff/ Testing --- Thanks, Alex Clemmer

Re: Review Request 45987: Fixed `rmdir.hpp` Windows build breaks.

views.apache.org/r/45987/#review128411 --- On April 10, 2016, 10:34 a.m., Alex Clemmer wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45987/ > --

Re: Review Request 45987: Fixed `rmdir.hpp` Windows build breaks.

dd5cc6923ecc503d58e56128cf4ae736d8145fd7 3rdparty/libprocess/3rdparty/stout/tests/os/rmdir_tests.cpp cc92953ccc53f37c54b87e738b16ea1fb521b987 Diff: https://reviews.apache.org/r/45987/diff/ Testing --- Thanks, Alex Clemmer

Re: Review Request 46014: Stout:[1/2] Moved process tests to their own file.

/os_tests.cpp 9bd34c7508cd813c5de18028956f6a740997c266 Diff: https://reviews.apache.org/r/46014/diff/ Testing --- Thanks, Alex Clemmer

Re: Review Request 46008: Stout: Initialize Windows socket stack in Stout tests.

b5aeab75c2365a3431c397743b95ce7fbd6d7a1a 3rdparty/libprocess/3rdparty/stout/tests/main.cpp c449de87bede4d3bf1df368eaf1d22f857c2298f Diff: https://reviews.apache.org/r/46008/diff/ Testing --- Thanks, Alex Clemmer

Re: Review Request 46008: Stout: Initialize Windows socket stack in Stout tests.

8522026e01b8f4ed70da4d9f Alex is right. But, to make progress I've implemented what you've asked for. :) - Alex --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46008/#review128410 ---

Re: Review Request 46008: Stout: Initialize Windows socket stack in Stout tests.

b5aeab75c2365a3431c397743b95ce7fbd6d7a1a 3rdparty/libprocess/3rdparty/stout/tests/main.cpp c449de87bede4d3bf1df368eaf1d22f857c2298f Diff: https://reviews.apache.org/r/46008/diff/ Testing --- Thanks, Alex Clemmer

Re: Review Request 46008: Stout: Initialize Windows socket stack in Stout tests.

b5aeab75c2365a3431c397743b95ce7fbd6d7a1a 3rdparty/libprocess/3rdparty/stout/tests/main.cpp c449de87bede4d3bf1df368eaf1d22f857c2298f Diff: https://reviews.apache.org/r/46008/diff/ Testing --- Thanks, Alex Clemmer

Review Request 46193: Stout:[2/2] Added `systems_tests.cpp`.

217283cd3ce6df699b63dc5b8fb3aab0c6debd04 Diff: https://reviews.apache.org/r/46193/diff/ Testing --- Thanks, Alex Clemmer

Review Request 46192: Stout:[1/2] Added `systems_tests.cpp`.

: https://reviews.apache.org/r/46192/diff/ Testing --- Thanks, Alex Clemmer

Review Request 46191: Stout: Implemented `uname` on Windows.

c48106e5905e3be0faeba7177ef534766089faff Diff: https://reviews.apache.org/r/46191/diff/ Testing --- Thanks, Alex Clemmer

Re: Review Request 46013: Stout: Implemented `os::processes` on Windows.

: https://reviews.apache.org/r/46013/diff/ Testing --- Thanks, Alex Clemmer

Re: Review Request 46008: Stout: Initialize Windows socket stack in Stout tests.

b5aeab75c2365a3431c397743b95ce7fbd6d7a1a 3rdparty/libprocess/3rdparty/stout/tests/main.cpp c449de87bede4d3bf1df368eaf1d22f857c2298f Diff: https://reviews.apache.org/r/46008/diff/ Testing --- Thanks, Alex Clemmer

Re: Review Request 45987: Fixed `rmdir.hpp` Windows build breaks.

dd5cc6923ecc503d58e56128cf4ae736d8145fd7 3rdparty/libprocess/3rdparty/stout/tests/os/rmdir_tests.cpp cc92953ccc53f37c54b87e738b16ea1fb521b987 Diff: https://reviews.apache.org/r/45987/diff/ Testing --- Thanks, Alex Clemmer

Re: Review Request 44123: Stout: [1/2] Implemented assorted `os::` functions on Windows.

- On April 11, 2016, 4:20 a.m., Daniel Pravat wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44123/ > --------

Re: Review Request 44123: Stout: [1/2] Implemented assorted `os::` functions on Windows.

--- > > (Updated April 11, 2016, 4:20 a.m.) > > > Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, Alex > Clemmer, Joris Van Remoortere, and Michael Park. > > > Repository: mesos > > > Description &

Re: Review Request 46009: Stout:[1/2] Added simple tests for `os::` functions.

> > I think I've even seen it in other reviews? > > Why is it burried in a test? > > Alex Clemmer wrote: > We are doing this to stay consistent with Neil Conway's pass over the > tests to use `std::string`. For the general codebase, maybe it's usef

Re: Review Request 46008: Stout: Initialize Windows socket stack in Stout tests.

b5aeab75c2365a3431c397743b95ce7fbd6d7a1a 3rdparty/libprocess/3rdparty/stout/tests/main.cpp c449de87bede4d3bf1df368eaf1d22f857c2298f Diff: https://reviews.apache.org/r/46008/diff/ Testing --- Thanks, Alex Clemmer

Re: Review Request 46013: Stout: Implemented `os::processes` on Windows.

: https://reviews.apache.org/r/46013/diff/ Testing --- Thanks, Alex Clemmer

Re: Review Request 46013: Stout: Implemented `os::processes` on Windows.

matically generated e-mail. To reply, visit: https://reviews.apache.org/r/46013/#review128983 ------- On April 15, 2016, 7:50 a.m., Alex Clemmer wrote: > > ---

Re: Review Request 46014: Stout:[1/2] Moved process tests to their own file.

/os_tests.cpp 9bd34c7508cd813c5de18028956f6a740997c266 Diff: https://reviews.apache.org/r/46014/diff/ Testing --- Thanks, Alex Clemmer

Re: Review Request 46014: Stout:[1/2] Moved process tests to their own file.

.apache.org/r/46014/#review128989 --- On April 15, 2016, 8:01 a.m., Alex Clemmer wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46014/ > --

Re: Review Request 46191: Stout: Implemented `uname` on Windows.

://reviews.apache.org/r/46191/diff/ Testing --- Thanks, Alex Clemmer

Re: Review Request 46191: Stout: Implemented `uname` on Windows.

ks, so that's what I guessed you wanted. - Alex --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46191/#review129003 --- On April

Re: Review Request 46192: Stout:[1/2] Added `systems_tests.cpp`.

9bd34c7508cd813c5de18028956f6a740997c266 Diff: https://reviews.apache.org/r/46192/diff/ Testing --- Thanks, Alex Clemmer

Re: Review Request 46013: Stout: Implemented `os::processes` on Windows.

y generated e-mail. To reply, visit: https://reviews.apache.org/r/46013/#review129204 --- On April 15, 2016, 7:50 a.m., Alex Clemmer wrote: > > --- > This is an automatically g

Re: Review Request 46013: Stout: Implemented `os::processes` on Windows.

Diff: https://reviews.apache.org/r/46013/diff/ Testing --- Thanks, Alex Clemmer

Re: Review Request 46191: Stout: Implemented `uname` on Windows.

_ptr name(new char[size + 1]); > > ``` You're right, that is a lot cleaner, thanks! - Alex --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46191/#review129199 --------

Re: Review Request 46191: Stout: Implemented `uname` on Windows.

://reviews.apache.org/r/46191/diff/ Testing --- Thanks, Alex Clemmer

Review Request 46340: Stout:[1/2] Implement `os::waitpid`.

--- Thanks, Alex Clemmer

Review Request 46341: Stout:[2/2] Transitioned reap.cpp to `os::waitpid`.

110386842d5eeccfbc4e48bfca88d79a9d087fb0 Diff: https://reviews.apache.org/r/46341/diff/ Testing --- Thanks, Alex Clemmer

Re: Review Request 46013: Stout: Implemented `os::processes` on Windows.

: https://reviews.apache.org/r/46013/diff/ Testing --- Thanks, Alex Clemmer

Review Request 46344: Libprocess: Created Winsock class to handle WSAStartup/WSACleanup.

47f5347988a61140c87bcd329e25d5a4d52e17a0 3rdparty/libprocess/include/process/windows/winsock.hpp PRE-CREATION Diff: https://reviews.apache.org/r/46344/diff/ Testing --- Thanks, Alex Clemmer

Review Request 46392: Windows:[PLACEHOLDER] Implemented fcntl nonblock and other items.

14734317d7fb40053ee808745ac3ba8c706a7669 Diff: https://reviews.apache.org/r/46392/diff/ Testing --- Thanks, Alex Clemmer

Review Request 46393: Windows: Added Windows support for `stout/os/shell.hpp`.

/windows/shell.hpp 18f038fa405b45daa5b3b46e4caee0904d7fdd1c Diff: https://reviews.apache.org/r/46393/diff/ Testing --- Thanks, Alex Clemmer

Review Request 46395: Windows: Removed `std::bind` from `process.cpp` to build on Windows.

d2c458ed93307f75358bb642aaf2ed8e17b2fe97 Diff: https://reviews.apache.org/r/46395/diff/ Testing --- Thanks, Alex Clemmer

Review Request 46422: Stout: Added Windows support for `stopwatch.hpp`.

://reviews.apache.org/r/46422/diff/ Testing --- Thanks, Alex Clemmer

Review Request 46423: Windows: Forked subprocess.cpp, added `Windows` implementation.

/libprocess/src/subprocess_posix.cpp PRE-CREATION 3rdparty/libprocess/src/subprocess_windows.cpp PRE-CREATION Diff: https://reviews.apache.org/r/46423/diff/ Testing --- Thanks, Alex Clemmer

Review Request 46424: Windows: Added libprocess to build.

://reviews.apache.org/r/46424/diff/ Testing --- Thanks, Alex Clemmer

Re: Review Request 46341: Stout:[2/2] Transitioned reap.cpp to `os::waitpid`.

/libprocess/src/reap.cpp 110386842d5eeccfbc4e48bfca88d79a9d087fb0 Diff: https://reviews.apache.org/r/46341/diff/ Testing --- Thanks, Alex Clemmer

Re: Review Request 46340: Stout:[1/2] Implement `os::waitpid`.

: https://reviews.apache.org/r/46340/diff/ Testing --- Thanks, Alex Clemmer

Re: Review Request 46341: Stout:[2/2] Transitioned reap.cpp to `os::waitpid`.

itpid [2] https://reviews.apache.org/r/46424/ - Alex --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46341/#review129780 --------

Re: Review Request 46013: Stout: Implemented `os::processes` on Windows.

: https://reviews.apache.org/r/46013/diff/ Testing --- Thanks, Alex Clemmer

Re: Review Request 46393: Windows: Fixed shell constants, mark `os::shell` as deleted.

--- Windows: Added Windows support for `stout/os/shell.hpp`. Diffs (updated) - 3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/shell.hpp 18f038fa405b45daa5b3b46e4caee0904d7fdd1c Diff: https://reviews.apache.org/r/46393/diff/ Testing --- Thanks, Alex Clemmer

Re: Review Request 46344: Libprocess: Created Winsock class to handle WSAStartup/WSACleanup.

) - 3rdparty/libprocess/include/Makefile.am 47f5347988a61140c87bcd329e25d5a4d52e17a0 3rdparty/libprocess/include/process/windows/winsock.hpp PRE-CREATION Diff: https://reviews.apache.org/r/46344/diff/ Testing --- Thanks, Alex Clemmer

<    6   7   8   9   10   11   12   >