Re: Review Request 38827: CMake: Expanded support for compiling much of the master.

Diff: https://reviews.apache.org/r/38827/diff/ Testing (updated) --- # On OS X 10.10, Ubuntu 14.04, Ubuntu 15.04 cmake .. -DENABLE_LIBEVENT=1 && make -j 8 cmake .. && make -j 8 Thanks, Alex Clemmer

Re: Review Request 38837: CMake: Disable agent build on Windows.

14.04, Ubuntu 15.04 cmake .. -DENABLE_LIBEVENT=1 && make -j 8 cmake .. && make -j 8 Thanks, Alex Clemmer

Re: Review Request 38825: CMake: Plumb `ENABLE_LIBEVENT` through libprocess config scripts.

) --- # On OS X 10.10, Ubuntu 14.04, Ubuntu 15.04 cmake .. -DENABLE_LIBEVENT=1 && make -j 8 cmake .. && make -j 8 Thanks, Alex Clemmer

Re: Review Request 38826: CMake: Added support for libevent for Unix builds.

8 cmake .. && make -j 8 Thanks, Alex Clemmer

Re: Review Request 38826: CMake: Added support for libevent for Unix builds.

8 cmake .. && make -j 8 Thanks, Alex Clemmer

Re: Review Request 38825: CMake: Plumb `ENABLE_LIBEVENT` through libprocess config scripts.

--- # On OS X 10.10, Ubuntu 14.04, Ubuntu 15.04 cmake .. -DENABLE_LIBEVENT=1 && make -j 8 cmake .. && make -j 8 Thanks, Alex Clemmer

Re: Review Request 38837: CMake: Disable agent build on Windows.

14.04, Ubuntu 15.04 cmake .. -DENABLE_LIBEVENT=1 && make -j 8 cmake .. && make -j 8 Thanks, Alex Clemmer

Re: Review Request 38827: CMake: Expanded support for compiling much of the master.

891f951f3107ece29b7923b7a3cc414e2ea56983 Diff: https://reviews.apache.org/r/38827/diff/ Testing --- # On OS X 10.10, Ubuntu 14.04, Ubuntu 15.04 cmake .. -DENABLE_LIBEVENT=1 && make -j 8 cmake .. && make -j 8 Thanks, Alex Clemmer

Re: Review Request 38815: Add Zookeeper patch from ZOOKEEPER-2253

> On Sept. 28, 2015, 8:43 p.m., Alex Clemmer wrote: > > Can you add this comment to the CMake build system as well? > > > > The file you need to change is here: > > https://github.com/apache/mesos/blob/master/3rdparty/CMakeLists.txt Should > > be line 40, a

Re: Review Request 38815: Add Zookeeper patch from ZOOKEEPER-2253

? The file you need to change is here: https://github.com/apache/mesos/blob/master/3rdparty/CMakeLists.txt Should be line 40, above `PATCH_CMD`. - Alex Clemmer On Sept. 28, 2015, 6:17 p.m., Chris Chen wrote: > > --- > This is an auto

Review Request 38826: CMake: Added support for libevent for Unix builds.

230e574f3ddc6aa12cc74105de7201a33dd7cdab Diff: https://reviews.apache.org/r/38826/diff/ Testing --- Thanks, Alex Clemmer

Review Request 38827: CMake: Expanded support for compiling much of the master.

/diff/ Testing --- Thanks, Alex Clemmer

Review Request 38825: CMake: Plumb `ENABLE_LIBEVENT` through libprocess config scripts.

9c369e2c94abcd2dfa463f98fb3b6527033064ab 3rdparty/libprocess/cmake/ProcessConfigure.cmake 076c8836d9d53b8bc69330a46a7e1d3039aa476b Diff: https://reviews.apache.org/r/38825/diff/ Testing --- Thanks, Alex Clemmer

Re: Review Request 38825: CMake: Plumb `ENABLE_LIBEVENT` through libprocess config scripts.

, Alex Clemmer

Re: Review Request 38826: CMake: Added support for libevent for Unix builds.

/CMakeLists.txt 891f951f3107ece29b7923b7a3cc414e2ea56983 src/slave/cmake/SlaveConfigure.cmake 230e574f3ddc6aa12cc74105de7201a33dd7cdab Diff: https://reviews.apache.org/r/38826/diff/ Testing --- Thanks, Alex Clemmer

Review Request 38837: CMake: Disable slave build on Windows.

Wu. Repository: mesos Description --- CMake: Disable slave build on Windows. Diffs - CMakeLists.txt c866f6d85d629ca9c3a987fa2c652bc63a7ff1be Diff: https://reviews.apache.org/r/38837/diff/ Testing --- Thanks, Alex Clemmer

Re: Review Request 38815: Add Zookeeper patch from ZOOKEEPER-2253

g/r/38815/#comment158170> Looks like the rest of this block is intented with 2 spaces. Can we do the same for this comment? - Alex Clemmer On Sept. 28, 2015, 11:45 p.m., Chris Chen wrote: > > --- > This is an automatica

Re: Review Request 38753: CMake: Transition Stout tests to use new third-party build scripts.

://reviews.apache.org/r/38753/diff/ Testing --- Compiled and ran made sure libprocess and stout tests ran and passed on the following platforms: * OS X 10.10 * Ubuntu 14.04.2 Thanks, Alex Clemmer

Re: Review Request 38756: CMake: Add support for compiling the agent with CMake.

libprocess and stout tests ran and passed on the following platforms: * OS X 10.10 * Ubuntu 14.04.2 Thanks, Alex Clemmer

Re: Review Request 38751: CMake: Pull third-party configuration logic into its own .cmake file.

--- Compiled and ran made sure libprocess and stout tests ran and passed on the following platforms: * OS X 10.10 * Ubuntu 14.04.2 Thanks, Alex Clemmer

Re: Review Request 38551: [1/2]CMake: Add version info for APR we need to build Windows.

: https://reviews.apache.org/r/38551/diff/ Testing --- Compiled and ran made sure libprocess and stout tests ran and passed on the following platforms: * OS X 10.10 * Windows 10 * Ubuntu 14.04.2 Thanks, Alex Clemmer

Re: Review Request 38552: [2/2]CMake: Add Windows-specific build targets for APR.

libprocess and stout tests ran and passed on the following platforms: * OS X 10.10 * Windows 10 * Ubuntu 14.04.2 Thanks, Alex Clemmer

Re: Review Request 38752: CMake: Update MesosConfigure to use new process configure scripts.

--- Compiled and ran made sure libprocess and stout tests ran and passed on the following platforms: * OS X 10.10 * Ubuntu 14.04.2 Thanks, Alex Clemmer

Re: Review Request 38754: CMake: Add build/configure/install logic for Zookeeper.

made sure libprocess and stout tests ran and passed on the following platforms: * OS X 10.10 * Ubuntu 14.04.2 Thanks, Alex Clemmer

Re: Review Request 38755: CMake: Move compiler configuration logic to its own file.

://reviews.apache.org/r/38755/diff/ Testing --- Compiled and ran made sure libprocess and stout tests ran and passed on the following platforms: * OS X 10.10 * Ubuntu 14.04.2 Thanks, Alex Clemmer

Re: Review Request 38753: CMake: Transition Stout tests to use new third-party build scripts.

: https://reviews.apache.org/r/38753/diff/ Testing --- Compiled and ran made sure libprocess and stout tests ran and passed on the following platforms: * OS X 10.10 * Ubuntu 14.04.2 Thanks, Alex Clemmer

Re: Review Request 38756: CMake: Add support for compiling the agent with CMake.

libprocess and stout tests ran and passed on the following platforms: * OS X 10.10 * Ubuntu 14.04.2 Thanks, Alex Clemmer

Review Request 38793: CMake: Transition to CMake-based build system for GMock/GTest.

9e4dcb83a8cc4e95a2a38573944f6b38e2eac76e Diff: https://reviews.apache.org/r/38793/diff/ Testing --- Compiled and ran made sure libprocess and stout tests ran and passed on the following platforms: * OS X 10.10 * Ubuntu 14.04.2 Thanks, Alex Clemmer

Re: Review Request 38549: [1/2]CMake: Add libevent version, configure Windows to use as default.

ed e-mail. To reply, visit: https://reviews.apache.org/r/38549/#review100735 --- On Sept. 26, 2015, 9:56 p.m., Alex Clemmer wrote: > > --- > This is an automatically generated e-mail. To re

Re: Review Request 38550: [2/2]CMake: Integrate libevent into Windows builds.

Diff: https://reviews.apache.org/r/38550/diff/ Testing --- Compiled and ran made sure libprocess and stout tests ran and passed on the following platforms: * OS X 10.10 * Windows 10 * Ubuntu 14.04.2 Thanks, Alex Clemmer

Re: Review Request 38755: CMake: Move compiler configuration logic to its own file.

> On Sept. 25, 2015, 7:07 a.m., Alex Clemmer wrote: > > cmake/CompilationConfigure.cmake, line 97 > > <https://reviews.apache.org/r/38755/diff/1/?file=1084612#file1084612line97> > > > > Oh yeah. I forgot to remove these. I don't actually know what > >

Re: Review Request 38751: CMake: Pull third-party configuration logic into its own .cmake file.

> On Sept. 26, 2015, 6:10 a.m., Joris Van Remoortere wrote: > > 3rdparty/libprocess/cmake/Process3rdpartyConfigure.cmake, line 82 > > <https://reviews.apache.org/r/38751/diff/2/?file=1084978#file1084978line82> > > > > Do we not need lflags for

Re: Review Request 38539: [VIA HAOSDENT] [1/2]Add CMake macro VsBuildCommand in libprocess.

-- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38539/#review100596 --- On Sept. 21, 2015, 6:14 p.m., Alex Clemmer wrote: > > --

Re: Review Request 38756: CMake: Add support for compiling the agent with CMake.

nerated e-mail. To reply, visit: https://reviews.apache.org/r/38756/#review100625 ------- On Sept. 25, 2015, 6:20 a.m., Alex Clemmer wrote: > > --- > This i

Re: Review Request 38550: [2/2]CMake: Integrate libevent into Windows builds.

oris, I think we'll probably keep this as is. - Alex --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38550/#review100608 --- On Sept. 21, 201

Re: Review Request 38753: CMake: Transition Stout tests to use new third-party build scripts.

e variables like `GLOG_INCLUDE_DIR`. - Alex --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38753/#review100605 ------- On

Re: Review Request 38754: CMake: Add build/configure/install logic for Zookeeper.

ans we have to keep two definitions. - Alex --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38754/#review100614 ------- On

Re: Review Request 38539: [VIA HAOSDENT] [1/2]Add CMake macro VsBuildCommand in libprocess.

to fix it here and > > elsewhere in this file? > > Alex Clemmer wrote: > I chose not to do this because the Google C++ style guide seems to say > that raw string literals can go over 80 characters. Per our conversation, > hopefully Joris can give guidance here? Per conversat

Re: Review Request 38539: [VIA HAOSDENT] [1/2]Add CMake macro VsBuildCommand in libprocess.

://reviews.apache.org/r/38539/diff/ Testing --- Compiled and ran made sure libprocess and stout tests ran and passed on the following platforms: * OS X 10.10 * Windows 10 * Ubuntu 14.04.2 Thanks, Alex Clemmer

Re: Review Request 38751: CMake: Pull third-party configuration logic into its own .cmake file.

--- Compiled and ran made sure libprocess and stout tests ran and passed on the following platforms: * OS X 10.10 * Ubuntu 14.04.2 Thanks, Alex Clemmer

Re: Review Request 38756: CMake: Add support for compiling the agent with CMake.

libprocess and stout tests ran and passed on the following platforms: * OS X 10.10 * Ubuntu 14.04.2 Thanks, Alex Clemmer

Re: Review Request 38755: CMake: Move compiler configuration logic to its own file.

://reviews.apache.org/r/38755/diff/ Testing --- Compiled and ran made sure libprocess and stout tests ran and passed on the following platforms: * OS X 10.10 * Ubuntu 14.04.2 Thanks, Alex Clemmer

Re: Review Request 38755: CMake: Move compiler configuration logic to its own file.

.apache.org/r/38755/#review100637 --- On Sept. 25, 2015, 10:13 p.m., Alex Clemmer wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/38755/ >

Re: Review Request 38756: CMake: Add support for compiling the agent with CMake.

esos, libprocess and stout. > > > > Paths grouped by project: > > mesos: > > cmake/MesosConfigure.cmake > > libprocess: > > 3rdparty/libprocess/3rdparty/CMakeLists.txt > > Failed to commit patch > > Alex Clemmer wrote: > Whoa, really? How

Re: Review Request 38756: CMake: Add support for compiling the agent with CMake.

ke[2]: *** [src/CMakeFiles/mesos-0.25.0.dir/slave/http.cpp.o] Error 1 > > make[1]: *** [src/CMakeFiles/mesos-0.25.0.dir/all] Error 2 > > make: *** [all] Error 2 > > ``` > > > > I wonder if the macro change broke something. I accidentally moved that part into the master

Re: Review Request 38541: CMake: Add `Versions.cmake` as an analog to `versions.am`.

libprocess and stout tests ran and passed on the following platforms: * OS X 10.10 * Windows 10 * Ubuntu 14.04.2 Thanks, Alex Clemmer

Re: Review Request 38539: [VIA HAOSDENT] [1/2]Add CMake macro VsBuildCommand in libprocess.

to fix it here and > > elsewhere in this file? > > Alex Clemmer wrote: > I chose not to do this because the Google C++ style guide seems to say > that raw string literals can go over 80 characters. Per our conversation, > hopefully Joris can give guidance here? >

Re: Review Request 38754: CMake: Add build/configure/install logic for Zookeeper.

made sure libprocess and stout tests ran and passed on the following platforms: * OS X 10.10 * Ubuntu 14.04.2 Thanks, Alex Clemmer

Re: Review Request 38754: CMake: Add build/configure/install logic for Zookeeper.

-- On Sept. 25, 2015, 10:22 p.m., Alex Clemmer wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/38754/ > ---

Re: Review Request 38752: CMake: Update MesosConfigure to use new process configure scripts.

ts really belonged review #38751. Moving it, I think, fixes this issue. - Alex --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38752/#review100676 ------

Re: Review Request 38756: CMake: Add support for compiling the agent with CMake.

mething like: > > ``` > > BUILD_PROTO(MESOS) > > BUILD_PROTO(V1_MESOS) > > BUILD_PROTO(AUTHENTICATION) > > ... > > ``` > > Alex Clemmer wrote: > Hmm, I see your point about there being a lot of duplicated code, so let > m

Re: Review Request 38756: CMake: Add support for compiling the agent with CMake.

ally generated e-mail. To reply, visit: https://reviews.apache.org/r/38756/#review100641 --- On Sept. 25, 2015, 10:14 p.m., Alex Clemmer wrote: > > --- > This is an au

Re: Review Request 38756: CMake: Add support for compiling the agent with CMake.

libprocess and stout tests ran and passed on the following platforms: * OS X 10.10 * Ubuntu 14.04.2 Thanks, Alex Clemmer

Re: Review Request 38549: [1/2]CMake: Add libevent version, configure Windows to use as default.

- Alex Clemmer On Sept. 21, 2015, 6:31 p.m., Alex Clemmer wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/38549/ >

Re: Review Request 38747: Adding digest utilities

> On Sept. 25, 2015, 6:24 a.m., Alex Clemmer wrote: > > Hey, it doesn't look like `src/tests/digest_tests.cpp` is being added to > > the `CMakeLists.txt` file in `3rdparty/libprocess/src/tests`. Is that > > correct? If not, could we please add it there as well? >

Re: Review Request 38755: CMake: Move compiler configuration logic to its own file.

tps://reviews.apache.org/r/38755/#comment157771> Oh yeah. I forgot to remove these. I don't actually know what `pkglibexecdir` does in autoconf; I'll look it up tomorrow if no one mentions it before I get back to these reviews. :) - Alex Clemmer On Sept. 25, 2015, 6:19 a.m., Alex Clemmer

Review Request 38755: CMake: Move compiler configuration logic to its own file.

--- Compiled and ran made sure libprocess and stout tests ran and passed on the following platforms: * OS X 10.10 * Ubuntu 14.04.2 Thanks, Alex Clemmer

Review Request 38754: CMake: Add build/configure/install logic for Zookeeper.

on the following platforms: * OS X 10.10 * Ubuntu 14.04.2 Thanks, Alex Clemmer

Review Request 38753: CMake: Transition Stout tests to use new third-party build scripts.

--- Compiled and ran made sure libprocess and stout tests ran and passed on the following platforms: * OS X 10.10 * Ubuntu 14.04.2 Thanks, Alex Clemmer

Review Request 38752: CMake: Transition Mesos to use new third-party build scripts.

://reviews.apache.org/r/38752/diff/ Testing --- Compiled and ran made sure libprocess and stout tests ran and passed on the following platforms: * OS X 10.10 * Ubuntu 14.04.2 Thanks, Alex Clemmer

Review Request 38751: CMake: Pull third-party configuration logic into its own .cmake file.

Thanks, Alex Clemmer

Review Request 38756: CMake: Add support for compiling the agent with CMake.

on the following platforms: * OS X 10.10 * Ubuntu 14.04.2 Thanks, Alex Clemmer

Re: Review Request 38747: Adding digest utilities

added to the `CMakeLists.txt` file in `3rdparty/libprocess/src/tests`. Is that correct? If not, could we please add it there as well? (I have forgotten to add a list of header files as dependencies, so you can't add that quite yet.) - Alex Clemmer On Sept. 25, 2015, 5:46 a.m., Jojy Varghese

Re: Review Request 37999: Implemented http::AuthenticatorManager

> On Sept. 23, 2015, 5:39 p.m., Alex Clemmer wrote: > > Can we please add this file to the CMakeLists.txt file in > > 3rdparty/libprocess/src as well? > > Alexander Rojas wrote: > The included file is a header and so far cmake file doesn't seem to care > about

Re: Review Request 38756: CMake: Add support for compiling the agent with CMake.

folks! :S - Alex --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38756/#review100553 --- On Sept. 25, 2015, 6:20

Re: Review Request 37996: Added property manager

> On Sept. 23, 2015, 5:40 p.m., Alex Clemmer wrote: > > Can we please add these tests to the CMakeLists.txt file in > > 3rdparty/libprocess/3rdparty/stout/tests? > > Alexander Rojas wrote: > It was done already since the first version of this patch. Ah. I'm so sor

Re: Review Request 37999: Implemented http::AuthenticatorManager

in 3rdparty/libprocess/src as well? - Alex Clemmer On Sept. 23, 2015, 8:57 a.m., Alexander Rojas wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 38665: Added fs::realpath().

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38665/#review100231 --- Can we add this test to the relevant CMakeLists.txt too? - Alex

Re: Review Request 37997: Running PathInheritedProperties tests from libprocess Makefile

/libprocess/3rdparty/stout/tests/ as well? - Alex Clemmer On Sept. 23, 2015, 8:55 a.m., Alexander Rojas wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 38094: Added implementation of Http Basic authentication scheme.

/libprocess/src as well? - Alex Clemmer On Sept. 23, 2015, 11:17 a.m., Alexander Rojas wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 37996: Added property manager

in 3rdparty/libprocess/3rdparty/stout/tests? - Alex Clemmer On Sept. 23, 2015, 11:17 a.m., Alexander Rojas wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Review Request 38550: [2/2]CMake: Integrate libevent into Windows builds.

/ Testing --- Compiled and ran made sure libprocess and stout tests ran and passed on the following platforms: * OS X 10.10 * Windows 10 * Ubuntu 14.04.2 Thanks, Alex Clemmer

Review Request 38549: [1/2]CMake: Add libevent version, configure Windows to use as default.

iff: https://reviews.apache.org/r/38549/diff/ Testing --- Compiled and ran made sure libprocess and stout tests ran and passed on the following platforms: * OS X 10.10 * Windows 10 * Ubuntu 14.04.2 Thanks, Alex Clemmer

Review Request 38551: [1/2]CMake: Add version info for APR we need to build Windows.

--- Compiled and ran made sure libprocess and stout tests ran and passed on the following platforms: * OS X 10.10 * Windows 10 * Ubuntu 14.04.2 Thanks, Alex Clemmer

Review Request 38552: [2/2]CMake: Add Windows-specific build targets for APR.

on the following platforms: * OS X 10.10 * Windows 10 * Ubuntu 14.04.2 Thanks, Alex Clemmer

Re: Review Request 38530: CMake: Add preprocessor definitions required to build picojson 1.3.0.

b530da4c1e6f202b682ad7d6892da95d2181f8c8 Diff: https://reviews.apache.org/r/38530/diff/ Testing --- Compiled and ran made sure libprocess and stout tests ran and passed on the following platforms: * OS X 10.10 * Windows 10 * Ubuntu 14.04.2 Thanks, Alex Clemmer

Re: Review Request 38539: [VIA HAOSDENT] [1/2]Add CMake macro VsBuildCommand in libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38539/#review99788 ------- On Sept. 21, 2015, 2:40 a.m., Alex Clemmer wrote: > >

Re: Review Request 38539: [VIA HAOSDENT] [1/2]Add CMake macro VsBuildCommand in libprocess.

://reviews.apache.org/r/38539/diff/ Testing --- Compiled and ran made sure libprocess and stout tests ran and passed on the following platforms: * OS X 10.10 * Windows 10 * Ubuntu 14.04.2 Thanks, Alex Clemmer

Re: Review Request 38541: CMake: Add `Versions.cmake` as an analog to `versions.am`.

s.apache.org/r/38541/#review99795 --- On Sept. 21, 2015, 3:23 a.m., Alex Clemmer wrote: > > --- > This is an automatically generated e-mail. To reply, v

Re: Review Request 38529: CMake: Only compile proc_tests.cpp for Linux platforms.

o reply, visit: https://reviews.apache.org/r/38529/#review99778 --- On Sept. 20, 2015, 2:07 a.m., Alex Clemmer wrote: > > --- > This is an automatically generated e-mail. To reply, visit:

Re: Review Request 38549: [1/2]CMake: Add libevent version, configure Windows to use as default.

eLists.txt 3b6f4af337466d33cb915959a5995e4307b27be3 Diff: https://reviews.apache.org/r/38549/diff/ Testing --- Compiled and ran made sure libprocess and stout tests ran and passed on the following platforms: * OS X 10.10 * Windows 10 * Ubuntu 14.04.2 Thanks, Alex Clemmer

Re: Review Request 38542: CMake: Use version info from `Versions.cmake` instead of magic strings.

ocessConfigure.cmake > a5f8d399e151acad87bb72ecb1f7372b2c467423 > 3rdparty/libprocess/cmake/ProcessTestsConfigure.cmake > 9e4dcb83a8cc4e95a2a38573944f6b38e2eac76e > > Diff: https://reviews.apache.org/r/38542/diff/ > > > Testing > --- > > Compiled and ran made sure libprocess and stout tests ran and passed on the > following platforms: > > * OS X 10.10 > * Windows 10 > * Ubuntu 14.04.2 > > > Thanks, > > Alex Clemmer > >

Re: Review Request 38551: [1/2]CMake: Add version info for APR we need to build Windows.

: https://reviews.apache.org/r/38551/diff/ Testing --- Compiled and ran made sure libprocess and stout tests ran and passed on the following platforms: * OS X 10.10 * Windows 10 * Ubuntu 14.04.2 Thanks, Alex Clemmer

Re: Review Request 38457: CMake: Fix MESOS-3250, a dynamic load error in Stout tests on OS X.

s (updated) - 3rdparty/libprocess/3rdparty/CMakeLists.txt b9c9fae7d448906e9c9f5ab0ee3fe138a0171a7d Diff: https://reviews.apache.org/r/38457/diff/ Testing --- Thanks, Alex Clemmer

Review Request 38541: CMake: Add `Versions.cmake` as an analog to `versions.am`.

on the following platforms: * OS X 10.10 * Windows 10 * Ubuntu 14.04.2 Thanks, Alex Clemmer

Review Request 38542: CMake: Use version info from `Versions.cmake` instead of magic strings.

libprocess and stout tests ran and passed on the following platforms: * OS X 10.10 * Windows 10 * Ubuntu 14.04.2 Thanks, Alex Clemmer

Review Request 38540: [VIA HAOSDENT] [2/2]Generate make batch file to build project in windows.

: * OS X 10.10 * Windows 10 * Ubuntu 14.04.2 Thanks, Alex Clemmer

Review Request 38539: [VIA HAOSDENT] [1/2]Add CMake macro VsBuildCommand in libprocess.

and ran made sure libprocess and stout tests ran and passed on the following platforms: * OS X 10.10 * Windows 10 * Ubuntu 14.04.2 Thanks, Alex Clemmer

Review Request 38538: [VIA HAOSDENT] CMake: Add `CMAKE_NOOP` to common definitions file.

3b6f4af337466d33cb915959a5995e4307b27be3 cmake/Common.cmake PRE-CREATION Diff: https://reviews.apache.org/r/38538/diff/ Testing --- Compiled and ran made sure libprocess and stout tests ran and passed on the following platforms: * OS X 10.10 * Windows 10 * Ubuntu 14.04.2 Thanks, Alex

Re: Review Request 38530: CMake: Add preprocessor definitions required to build picojson 1.3.0.

b530da4c1e6f202b682ad7d6892da95d2181f8c8 Diff: https://reviews.apache.org/r/38530/diff/ Testing --- Compiled and ran made sure libprocess and stout tests ran and passed on the following platforms: * OS X 10.10 * Windows 10 * Ubuntu 14.04.2 Thanks, Alex Clemmer

Re: Review Request 38529: CMake: Only compile proc_tests.cpp for Linux platforms.

baa648aacfd5204c33e102b58126862729fbb612 Diff: https://reviews.apache.org/r/38529/diff/ Testing --- Compiled and ran made sure libprocess and stout tests ran and passed on the following platforms: * OS X 10.10 * Windows 10 * Ubuntu 14.04.2 Thanks, Alex Clemmer

Re: Review Request 38457: CMake: Fix MESOS-3250, a dynamic load error in Stout tests on OS X.

- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38457/#review99401 ------- On Sept. 17, 2015, 10:03 a.m., Alex Clemmer wrote: > >

Re: Review Request 38531: CMake: Update CMake config to build Mesos against picojson v1.3.0.

a5f8d399e151acad87bb72ecb1f7372b2c467423 Diff: https://reviews.apache.org/r/38531/diff/ Testing --- Compiled and ran made sure libprocess and stout tests ran and passed on the following platforms: * OS X 10.10 * Windows 10 * Ubuntu 14.04.2 Thanks, Alex Clemmer

Re: Review Request 38457: CMake: Fix MESOS-3250, a dynamic load error in Stout tests on OS X.

eLists.txt b9c9fae7d448906e9c9f5ab0ee3fe138a0171a7d Diff: https://reviews.apache.org/r/38457/diff/ Testing --- Thanks, Alex Clemmer

Re: Review Request 38457: CMake: Fix MESOS-3250, a dynamic load error in Stout tests on OS X.

3rdparty/libprocess/3rdparty/CMakeLists.txt b9c9fae7d448906e9c9f5ab0ee3fe138a0171a7d Diff: https://reviews.apache.org/r/38457/diff/ Testing --- Thanks, Alex Clemmer

Re: Review Request 38457: CMake: Fix MESOS-3250, a dynamic load error in Stout tests on OS X.

having a macro or function expand this out. - Alex --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38457/#review99599 ------- On Sept. 17, 2015, 10:03 a.m., Alex Clemmer wrote: > > ---

Review Request 38529: CMake: Only compile proc_tests.cpp for Linux platforms.

and ran made sure libprocess and stout tests ran and passed on the following platforms: * OS X 10.10 * Windows 10 * Ubuntu 14.04.2 Thanks, Alex Clemmer

Review Request 38531: CMake: Update CMake config to build Mesos against picojson v1.3.0.

and ran made sure libprocess and stout tests ran and passed on the following platforms: * OS X 10.10 * Windows 10 * Ubuntu 14.04.2 Thanks, Alex Clemmer

Review Request 38530: CMake: Add preprocessor definitions required to build picojson 1.3.0.

libprocess and stout tests ran and passed on the following platforms: * OS X 10.10 * Windows 10 * Ubuntu 14.04.2 Thanks, Alex Clemmer

Review Request 38455: CMake: Remove thread_tests.cpp from Stout tests.

Wu. Repository: mesos Description --- CMake: Remove thread_tests.cpp from Stout tests. Diffs - 3rdparty/libprocess/3rdparty/stout/tests/CMakeLists.txt cf5fd5c9840fb58b604dc0cd49b2922efbb2a10e Diff: https://reviews.apache.org/r/38455/diff/ Testing --- Thanks, Alex Clemmer

<    7   8   9   10   11   12   13   >