Re: Review Request 63434: Added IPv6 capabilities for TCP and HTTP healthchecks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63434/#review190437 --- Ship it! Ship It! - Alexander Rukletsov On Nov. 3, 2017, 12

Re: Review Request 63434: Added IPv6 capabilities for TCP and HTTP healthchecks.

cally generated e-mail. To reply, visit: > https://reviews.apache.org/r/63434/ > --- > > (Updated Nov. 3, 2017, 12:38 a.m.) > > > Review request for mesos, Alexander Rukletsov, Qian Zhang, and Vinod Kone. > >

Re: Review Request 63538: Removed expectation for scheduler connected events in some tests.

ortly. Thanks! src/tests/containerizer/cni_isolator_tests.cpp Line 1497 (original), 1486-1489 (patched) <https://reviews.apache.org/r/63538/#comment267585> Let's wrap it like we did in the test above. - Alexander Rukletsov On Nov. 3, 2017, 2:32 p.m., Arma

Review Request 63615: Passed scheduler as a shared pointer into the callback.

Diff: https://reviews.apache.org/r/63615/diff/1/ Testing --- make check on Mac OS 10.11.6 with Apple LLVM version 8.0.0 (clang-800.0.42.1) make check on various linux distributions Thanks, Alexander Rukletsov

Review Request 63614: Removed unnecessary check in v1 scheduler library.

/ Thanks, Alexander Rukletsov

Review Request 63612: Modified formatting of v1 scheduler test driver for consistency.

Description --- See summary. Diffs - src/tests/mesos.hpp e25defeb55608136e77363aa48cf820092a13a59 Diff: https://reviews.apache.org/r/63612/diff/1/ Testing --- See https://reviews.apache.org/r/63615/ Thanks, Alexander Rukletsov

Review Request 63611: Refactored scheduler test driver to avoid using uninitialized object.

altogether and hence prevents possible segfaults. Diffs - src/tests/mesos.hpp e25defeb55608136e77363aa48cf820092a13a59 Diff: https://reviews.apache.org/r/63611/diff/1/ Testing --- See https://reviews.apache.org/r/63615/ Thanks, Alexander Rukletsov

Review Request 63613: Refactored executor test driver to avoid using uninitialized object.

altogether and hence prevents possible segfaults. Diffs - src/tests/mesos.hpp e25defeb55608136e77363aa48cf820092a13a59 Diff: https://reviews.apache.org/r/63613/diff/1/ Testing --- See https://reviews.apache.org/r/63615/ Thanks, Alexander Rukletsov

Re: Review Request 63538: Moved expectation for scheduler subscription events in some tests.

(original), 502-505 (patched) <https://reviews.apache.org/r/63538/#comment267384> Since we do not AWAIT for `connected`, no need to declare and set it anymore. Here and below. - Alexander Rukletsov On Nov. 3, 2017, 2:32 p.m., Armand Grillet

Re: Review Request 63434: Added IPv6 capabilities for TCP and HTTP healthchecks.

7193> Let's call it `protocol` to avoid confusion - Alexander Rukletsov On Oct. 30, 2017, 11:57 p.m., Avinash sridharan wrote: > > --- > This is an automatically generated

Re: Review Request 63499: Fixed the unit test that broke Windows build.

> On Nov. 2, 2017, 11:23 a.m., Alexander Rukletsov wrote: > > src/tests/default_executor_tests.cpp > > Lines 1413-1416 (original), 1413-1419 (patched) > > <https://reviews.apache.org/r/63499/diff/1/?file=1878739#file1878739line1413> > > > > Pease use `T

Re: Review Request 63499: Fixed the unit test that broke Windows build.

il. To reply, visit: > https://reviews.apache.org/r/63499/ > --- > > (Updated Nov. 2, 2017, 8:27 a.m.) > > > Review request for mesos, Alexander Rukletsov, Andrew Schwartzmeyer, Gaston > Kleiman, and Vinod Kone. > > > Repository: mesos > > > Description

Re: Review Request 63497: Fixed the unit test that missed to check the TASK_STARTING update.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63497/#review189901 --- Ship it! Ship It! - Alexander Rukletsov On Nov. 2, 2017, 8

Re: Review Request 63499: Fixed the unit test that broke Windows build.

), 1413-1419 (patched) <https://reviews.apache.org/r/63499/#comment267128> Pease use `TEST_P_TEMP_DISABLED_ON_WINDOWS` instead - Alexander Rukletsov On Nov. 2, 2017, 8:27 a.m., Qian Zhang wrote: > > --- > This is a

Re: Review Request 62837: Added a test `DefaultExecutorTest.KillMultipleTasks`.

the first `TASK_RUNNING` status > > update will come after the second `TASK_STARTING` update. > > > > The following ordering would also be possible: [`TASK_STARTING`, > > `TASK_RUNNING`, `TASK_STARTING`, `TASK_RUNNING`, ...] > > Alexander Rukletsov wrote

Re: Review Request 62837: Added a test `DefaultExecutorTest.KillMultipleTasks`.

> On Nov. 1, 2017, 3 p.m., Gaston Kleiman wrote: > > src/tests/default_executor_tests.cpp > > Lines 538-548 (patched) > > > > > > This is racy; there's no guarantee that the first `TASK_RUNNING` status > > update wi

Re: Review Request 63183: Stopped awaiting the connected event in ports isolator tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63183/#review189566 --- Ship it! Ship It! - Alexander Rukletsov On Oct. 30, 2017

Re: Review Request 63391: Fixed the flaky SlaveTest.HTTPSchedulerSlaveRestart.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63391/#review189554 --- Ship it! Ship It! - Alexander Rukletsov On Oct. 28, 2017, 1

Re: Review Request 63177: Fixed 'SlaveRecoveryTest.RegisterDisconnectedSlave'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63177/#review188850 --- Ship it! Ship It! - Alexander Rukletsov On Oct. 20, 2017, 9

Re: Review Request 63146: Replaced std::cerr by LOG(ERROR) in process.cpp.

Line 49 (original), 49 (patched) <https://reviews.apache.org/r/63146/#comment265759> I don't think we need this now. - Alexander Rukletsov On Oct. 19, 2017, 1:24 p.m., Armand Grillet wrote: > > --- > This is an autom

Re: Review Request 63148: Fixed 'PortMappingMesosTest.ROOT_NetworkNamespaceHandleSymlink'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63148/#review188685 --- Ship it! Ship It! - Alexander Rukletsov On Oct. 19, 2017, 2

Re: Review Request 63113: Fix flakyness in 'SlaveTest.ExecutorShutdownGracePeriod'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63113/#review188550 --- Ship it! Ship It! - Alexander Rukletsov On Oct. 18, 2017, 3

Re: Review Request 62213: Fix unit tests that were broken by the additional TASK_STARTING update.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62213/#review188553 --- Ship it! Ship It! - Alexander Rukletsov On Oct. 18, 2017, 4

Re: Review Request 62212: Send TASK_STARTING from the built-in executors.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62212/#review188554 --- Ship it! Ship It! - Alexander Rukletsov On Oct. 12, 2017

Re: Review Request 61855: Removed a stray trailing parenthesis from a validation error.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61855/#review188552 --- Ship it! Ship It! - Alexander Rukletsov On Oct. 6, 2017, 10

Re: Review Request 62891: Increased level of verbose logs for libprocess actor state transitions.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62891/#review188533 --- Ship it! Ship It! - Alexander Rukletsov On Oct. 11, 2017, 1

Re: Review Request 62887: Increased level of some verbose logs from master and agent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62887/#review188535 --- Ship it! Ship It! - Alexander Rukletsov On Oct. 11, 2017, 1

Re: Review Request 62886: Increased level of some verbose logs from allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62886/#review188534 --- Ship it! Ship It! - Alexander Rukletsov On Oct. 11, 2017, 1

Re: Review Request 62886: Increased level of some verbose logs from allocator.

(original), 1486-1487 (patched) <https://reviews.apache.org/r/62886/#comment265189> Let's keep this one at level 1 for now. I think if we remove this line, we will have no insight on level 1 when an allocation—even an event-based!—happens. - Alexander Rukletsov On Oct. 11, 201

Review Request 63010: Avoided periodic allocations in persistent volume endpoint tests.

::updateAvailable()` and periodic allocations. Diffs - src/tests/persistent_volume_endpoints_tests.cpp 7a24bf48e9d84bf31ad85397ac3e1b4e566cbc2c Diff: https://reviews.apache.org/r/63010/diff/1/ Testing --- See https://reviews.apache.org/r/63015/ Thanks, Alexander Rukletsov

Review Request 63014: Avoided periodic allocations in reservation refinement tests.

: https://reviews.apache.org/r/63014/diff/1/ Testing --- See https://reviews.apache.org/r/63015/ Thanks, Alexander Rukletsov

Review Request 63011: Fixed a race when the first agent retries to register.

7a24bf48e9d84bf31ad85397ac3e1b4e566cbc2c Diff: https://reviews.apache.org/r/63011/diff/1/ Testing --- See https://reviews.apache.org/r/63015/ Thanks, Alexander Rukletsov

Review Request 63012: Avoided periodic allocations in api tests.

://reviews.apache.org/r/63012/diff/1/ Testing --- See https://reviews.apache.org/r/63015/ Thanks, Alexander Rukletsov

Review Request 63013: Avoided periodic allocations in EventAuthorizationFiltering test.

3d0db3b6c6bfb088a79921c3841ad312dad1ee6a Diff: https://reviews.apache.org/r/63013/diff/1/ Testing --- See https://reviews.apache.org/r/63015/ Thanks, Alexander Rukletsov

Review Request 63015: Cleaned up test ordering in "master_tests.cpp".

10.11.6 make check + root tests on various Linux distros tests from all modified test fixtures in the chain run at least 1000 on Mac OS 10.11.6 Thanks, Alexander Rukletsov

Review Request 63009: Cleaned up reservation endpoint tests.

--- See summary. Diffs - src/tests/reservation_endpoints_tests.cpp 5a6e9a7f08a5306542830f359868b2c31f4820c6 Diff: https://reviews.apache.org/r/63009/diff/1/ Testing --- See https://reviews.apache.org/r/63015/ Thanks, Alexander Rukletsov

Review Request 63003: Augmented AwaitAssertResponseStatusEq with response body.

ocess/gtest.hpp 27077ac9047447fc4c52cc76ab26420e5bc79418 Diff: https://reviews.apache.org/r/63003/diff/1/ Testing --- See https://reviews.apache.org/r/63015/ Thanks, Alexander Rukletsov

Review Request 63007: Replaced unnecessary future chaining in api_tests.cpp.

://reviews.apache.org/r/63015/ Thanks, Alexander Rukletsov

Review Request 63005: Libprocess: Fixed formatting of `AWAIT_EXPECT_RESPONSE_STATUS_EQ`.

--- See summary. Diffs - 3rdparty/libprocess/src/tests/http_tests.cpp dde05f6a554fcb8c6c89e690bbdcd2bf509854d5 Diff: https://reviews.apache.org/r/63005/diff/1/ Testing --- See https://reviews.apache.org/r/63015/ Thanks, Alexander Rukletsov

Review Request 63008: Avoided periodic allocations in reservation endpoint tests.

5a6e9a7f08a5306542830f359868b2c31f4820c6 Diff: https://reviews.apache.org/r/63008/diff/1/ Testing --- See https://reviews.apache.org/r/63015/ Thanks, Alexander Rukletsov

Review Request 63002: Logged when allocator cannot apply offer operation.

://reviews.apache.org/r/63015/ Thanks, Alexander Rukletsov

Review Request 63004: Removed no longer necessary response body output in tests.

4c7d37fd14c8f3e7a52d35fb685fb8f05cba1e70 src/tests/slave_tests.cpp 6d1e98d59ad0b8a02f4696ca9cc663d048109ca6 Diff: https://reviews.apache.org/r/63004/diff/1/ Testing --- See https://reviews.apache.org/r/63015/ Thanks, Alexander Rukletsov

Review Request 63006: Fixed formatting of `AWAIT_EXPECT_RESPONSE_*`.

://reviews.apache.org/r/63006/diff/1/ Testing --- See https://reviews.apache.org/r/63015/ Thanks, Alexander Rukletsov

Re: Review Request 60467: Fixed race in configureSignal and installCtrlHandler.

ent265138> Ditto - Alexander Rukletsov On Oct. 13, 2017, 10:47 a.m., Dmitry Zhuk wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://re

Re: Review Request 60467: Fixed race in configureSignal.

nchronized` for consistency? - Alexander Rukletsov On June 27, 2017, 2:09 p.m., Dmitry Zhuk wrote: > > --- > This is an automatically generated e-mail. To reply, visit:

Re: Review Request 62213: Fix unit tests that were broken by the additional TASK_STARTING update.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62213/#review187810 --- Ship it! Ship It! - Alexander Rukletsov On Oct. 11, 2017

Re: Review Request 62212: Send TASK_STARTING from the built-in executors.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62212/#review187808 --- Ship it! Ship It! - Alexander Rukletsov On Oct. 12, 2017

Re: Review Request 62897: Add MESOS-7941 to changelog and to upgrade guidelines.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62897/#review187809 --- Ship it! Ship It! - Alexander Rukletsov On Oct. 12, 2017

Review Request 62913: Fixed flaky ROOT_DynamicAddDelofCniConfig test.

/cni_isolator_tests.cpp 636695f368d1c8acd9ed4ccfd1a449f375af8282 Diff: https://reviews.apache.org/r/62913/diff/1/ Testing --- make check Thanks, Alexander Rukletsov

Re: Review Request 62897: Add MESOS-7941 to changelog and to upgrading documentation.

tps://reviews.apache.org/r/62897/#comment264762> Please add a sentence that this means that all schedulers must be upgraded to support `TASK_STARTING` before Mesos is upgraded to 1.5.x. - Alexander Rukletsov On Oct. 11, 2017, 10:15 p.m., Benno Evers

Re: Review Request 62212: Send TASK_STARTING from the built-in executors.

Please check the internal invariant: `CHECK(containers.contains(taskId));` - Alexander Rukletsov On Oct. 11, 2017, 10:28 p.m., Benno Evers wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https

Re: Review Request 62893: Expand description of the --recovery_timeout flag.

is not running, hence it might make sense to have `recovery_timeout` longer than `agent_reregister_timeout`. - Alexander Rukletsov On Oct. 11, 2017, 2:11 p.m., Benno Evers wrote: > > --- > This is an automatically generated e-mail.

Re: Review Request 62868: Reverted 2af9a5b07dc80151154264e974d03f56a1c25838.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62868/#review187570 --- Ship it! Ship It! - Alexander Rukletsov On Oct. 10, 2017, 3

Re: Review Request 62696: Updated error messages in `getMountNamespaceTarget()`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62696/#review186943 --- Ship it! Ship It! - Alexander Rukletsov On Oct. 2, 2017, 4

Re: Review Request 62663: Updated maximum acceptable number of similar lines in Python files.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62663/#review186552 --- Ship it! Ship It! - Alexander Rukletsov On Sept. 28, 2017

Re: Review Request 62381: Removed `docker exec` when performing health checks in docker executor.

ply, visit: > https://reviews.apache.org/r/62381/ > --- > > (Updated Sept. 18, 2017, 5:21 p.m.) > > > Review request for mesos, Alexander Rukletsov, Gastón Kleiman, haosdent > huang, and Lukas Loesche. > > > Bugs: MESOS-4812 > https://issues.apache.org/jira/brow

Re: Review Request 62037: Added logging::initialize to main functions that use glog.

s for you. - Alexander Rukletsov On Sept. 18, 2017, 2:27 p.m., Armand Grillet wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.a

Re: Review Request 62037: Added logging::initialize to main functions that use glog.

> On Sept. 18, 2017, 4:18 p.m., Andrei Budnik wrote: > > src/examples/long_lived_framework.cpp > > Lines 578 (patched) > > <https://reviews.apache.org/r/62037/diff/6/?file=1828518#file1828518line578> > > > > Extra newline? > > Alexander Rukletso

Re: Review Request 62037: Added logging::initialize to main functions that use glog.

Ditto. src/examples/no_executor_framework.cpp Line 312 (original), 319 (patched) <https://reviews.apache.org/r/62037/#comment261910> Why did you change it from ``` logging::initialize(argv[0], true, flags); // Catch signals. ``` ? - Alexander Rukletsov On Sept. 18, 2017, 2:27 p.m., A

Re: Review Request 62357: Updated logging initialization arguments.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62357/#review185609 --- Ship it! Ship It! - Alexander Rukletsov On Sept. 18, 2017

Re: Review Request 62018: Updated logging::initialize to make flags optional.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62018/#review185608 --- Ship it! Ship It! - Alexander Rukletsov On Sept. 18, 2017

Re: Review Request 62122: Fixed parameter name in uri/fetcher.hpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62122/#review185607 --- Ship it! Ship It! - Alexander Rukletsov On Sept. 6, 2017, 2

Re: Review Request 62037: Added logging::initialize to main functions that use glog.

- On Sept. 18, 2017, 2:27 p.m., Armand Grillet wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/62037/ > --- > > (Updated

Re: Review Request 62212: Send TASK_STARTING from the built-in executors.

tps://reviews.apache.org/r/62212/#comment261883> Why don't you send the update right after creating a `Container` instance? - Alexander Rukletsov On Sept. 13, 2017, 2:52 p.m., Benno Evers wrote: > > --- > This

Re: Review Request 62246: Added workaround for a docker bug in docker build helper.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62246/#review185477 --- Ship it! Ship It! - Alexander Rukletsov On Sept. 13, 2017

Re: Review Request 62279: Fixed failure of `DefaultExecutorTest.SigkillExecutor` test on windows.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62279/#review185301 --- Ship it! Ship It! - Alexander Rukletsov On Sept. 13, 2017

Re: Review Request 62253: Ignored cgroups v2 hierarchy when parsing /proc/self/cgroups.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62253/#review185239 --- Ship it! Ship It! - Alexander Rukletsov On Sept. 12, 2017

Re: Review Request 62254: Ignored /proc/self/ns/pid_for_children when listing namespaces.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62254/#review185238 --- Ship it! Ship It! - Alexander Rukletsov On Sept. 12, 2017

Re: Review Request 62212: Send TASK_STARTING from the built-in executors. [1/2]

-- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/62212/ > --- > > (Updated Sept. 11, 2017, 9:16 a.m.) > > > Review request for mesos, Andrei Budnik and A

Re: Review Request 62212: Send TASK_STARTING from the built-in executors. [1/2]

tion. src/launcher/default_executor.cpp Lines 1317-1319 (original), 1333-1337 (patched) <https://reviews.apache.org/r/62212/#comment261447> Instead of checking a flag, why not replacing `CHECK` with a condition? - Alexander Rukletsov On Sept. 11, 2017, 9:16 a.m.,

Re: Review Request 62140: Shorten the default interval between disk-usage GCs.

tps://reviews.apache.org/r/62140/#comment261000> I know it is hard to justify specific values, but `1s` feels too aggressive. - Alexander Rukletsov On Sept. 7, 2017, 4:01 a.m., Chun-Hung Hsiao wrote: > > --- > This is a

Re: Review Request 61495: Add documentation for possible task reasons.

this for you. docs/task-state-reasons.md Lines 20 (patched) <https://reviews.apache.org/r/61495/#comment260999> Change "which" back to "that" - Alexander Rukletsov On Sept. 6, 2017, 9:29 a.m., Benno Evers wrote: > > ---

Review Request 62116: Excluded invalid offers from abnormal termination metrics.

Thanks, Alexander Rukletsov

Review Request 62113: Fixed compilation issue on Mac OS.

akefile.am a4f2ee008eba263fe52c4e58c305e3fb9ba42f6b src/tests/CMakeLists.txt def233d13f627f58362fdc61ac3e9c104d65fe7e Diff: https://reviews.apache.org/r/62113/diff/1/ Testing --- make check on Mac OS Thanks, Alexander Rukletsov

Re: Review Request 62094: Updated CMake version in docker build helper.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62094/#review184633 --- Ship it! Ship It! - Alexander Rukletsov On Sept. 5, 2017, 7

Re: Review Request 62037: Added logging::initialize to main functions that use glog.

> On Sept. 4, 2017, 1:39 p.m., Alexander Rukletsov wrote: > > src/examples/dynamic_reservation_framework.cpp > > Lines 366-375 (original), 366-375 (patched) > > <https://reviews.apache.org/r/62037/diff/1/?file=1812248#file1812248line368> > > > > Let

Review Request 62070: Added protobufs to CMake project to facilitate indexing.

, Alexander Rukletsov

Review Request 62071: Added non-src files to CMake project to facilitate indexing.

the built-in CMake plugin and verified the change adds files to the project structure and makes them searchable in Qt Creator. Thanks, Alexander Rukletsov

Re: Review Request 62018: Updated logging::initialize to make flags optional.

cpp Line 149 (original), 155 (patched) <https://reviews.apache.org/r/62018/#comment260645> Ditto. - Alexander Rukletsov On Aug. 31, 2017, 4:47 p.m., Armand Grillet wrote: > > --- > This is an automatically

Re: Review Request 62037: Added logging::initialize to main functions that use glog.

entioned for another `cli/` binary, it looks it was not intended to use glog at all. Please see my comment above for more info. - Alexander Rukletsov On Sept. 1, 2017, 3:47 p.m., Armand Grillet wrote: > > -

Re: Review Request 61991: Added several logs to the C++ part of the v1-v0 adapter.

://reviews.apache.org/r/61991/diff/2/ Testing --- None: Not a functional change. Thanks, Alexander Rukletsov

Re: Review Request 61849: Improved consistency of cout/cerr and glog usage in main functions.

s::initialize()` src/master/main.cpp Lines 258-261 (original), 257-260 (patched) <https://reviews.apache.org/r/61849/#comment260402> This is done right after initializing logging. Let's do the same here for consistency. - Alexander Rukletsov On Aug. 29, 201

Re: Review Request 61495: Add documentation for possible task reasons.

"originally sent", probably? Instead, you can say "the original ones" include/mesos/mesos.proto Lines 2149-2150 (original) <https://reviews.apache.org/r/61495/#comment260346> I thought you remove the comment in the next patch? include/mesos/v1/mesos.proto Lines 2132

Re: Review Request 61579: Ensured JAVA HTTP adapter propagates a subscription error.

--- See https://reviews.apache.org/r/61580/ Thanks, Alexander Rukletsov

Re: Review Request 61580: Extracted JNI code into a protected function for clarity.

hanks, Alexander Rukletsov

Re: Review Request 61991: Added several logs to the C++ part of the v1-v0 adapter.

/r/61991/diff/1-2/ Testing --- None: Not a functional change. Thanks, Alexander Rukletsov

Re: Review Request 61991: Added several logs to the C++ part of the v1-v0 adapter.

s value in this log entry to show the reader how the adapter reacted to the disconnected event because connected-disconnected and registered/disconnected logics are not symmetrical. - Alexander --- This is an automatically ge

Re: Review Request 61579: Ensured JAVA HTTP adapter propagates a subscription error.

--- See https://reviews.apache.org/r/61580/ Thanks, Alexander Rukletsov

Re: Review Request 61580: Extracted JNI code into a protected function for clarity.

; SDK. Thanks, Alexander Rukletsov

Review Request 61991: Added several logs to the C++ part of the v1-v0 adapter.

. Repository: mesos Description --- See summary. Diffs - src/java/jni/org_apache_mesos_v1_scheduler_V0Mesos.cpp 1f58fbff4e8414e4d2ae4c8f69b637ee3315e411 Diff: https://reviews.apache.org/r/61991/diff/1/ Testing --- None: Not a functional change. Thanks, Alexander Rukletsov

Re: Review Request 61915: Enabled `DockerContainerizerProcess::usage` for all platforms.

Lines 1869-1870 (patched) <https://reviews.apache.org/r/61915/#comment260016> Let's insert a blank line here. - Alexander Rukletsov On Aug. 25, 2017, 8:32 p.m., Andrew Schwartzmeyer wrote: > > --- > This is an autom

Re: Review Request 60647: Fixed the mention of default ports in 'configuration.md'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60647/#review183843 --- Ship it! Ship It! - Alexander Rukletsov On July 5, 2017, 9

Re: Review Request 61597: Fixed linking to `IPHlpAPI` library.

> On Aug. 18, 2017, 9:29 a.m., Alexander Rukletsov wrote: > > Ship It! I've tested the chain up to this commit in my CMake setup (integration with Qt Creator + ccache) and confirm it works as expected (targets are set up properly, building and running tests works).

Re: Review Request 61799: Replaced ABORT with _EXIT in `childMain` to handle `os::execvpe` error.

> On Aug. 22, 2017, 10:46 a.m., Alexander Rukletsov wrote: > > 3rdparty/libprocess/src/subprocess_posix.hpp > > Line 194 (original), 195-197 (patched) > > <https://reviews.apache.org/r/61799/diff/1/?file=1801034#file1801034line195> > > > > Is this wh

Re: Review Request 61797: Added async-signal safe implementation of `write` function in stout.

> On Aug. 22, 2017, 10:46 a.m., Alexander Rukletsov wrote: > > 3rdparty/stout/include/stout/os/write.hpp > > Lines 67 (patched) > > <https://reviews.apache.org/r/61797/diff/1/?file=1801032#file1801032line68> > > > > `std::strlen`? > > Andrei Bud

Review Request 61818: Adjusted a comment and a log message around container termination.

ffs - src/slave/slave.cpp 50d2a10cd68f6611efd4e691e5325e6e0c06f33a Diff: https://reviews.apache.org/r/61818/diff/1/ Testing --- None: not a functional change. Thanks, Alexander Rukletsov

Re: Review Request 59746: Stopped accounting aborted container launches as failures.

With docker c-zer m: `./bin/mesos-master.sh --work_dir=./m` a: `GLOG_v=1 sudo ./bin/mesos-agent.sh --master=:5050 --work_dir=./a --containerizers=docker` f: `./src/mesos-execute --master=:5050 --containerizer=docker --docker_image=fedora:25 --name=pull-test --command="sleep 1000"` Thanks, Alexander Rukletsov

Re: Review Request 61811: Flattened continuation chains in containerizer for readability.

--- make check on: `Apple LLVM version 8.0.0 (clang-800.0.42.1)` on Mac OS 10.11.6 `c++ (GCC) 6.2.1 20160916 (Red Hat 6.2.1-2)` on Fedora 24 Thanks, Alexander Rukletsov

Re: Review Request 59746: Stopped accounting aborted container launches as failures.

-- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59746/#review176820 --- On Aug. 22, 2017, 1:47 p.m., Alexander Rukletsov wrote: > > -

Re: Review Request 59746: Stopped accounting aborted container launches as failures.

future? > > `!future.isReady()` could also mean that it's in `PENDING` state. The old > > code (wrongly) logged a "future discarded" but covered that case. > > Alexander Rukletsov wrote: > I don't think so. IIUC, this continuation is only called when

<    1   2   3   4   5   6   7   8   9   10   >