Re: Review Request 47999: Added calico information for CNI.

2016-06-22 Thread Dan Osborne
-docs?expand=1=calico-cni-docs_path=088dbb7#diff-088dbb7685be5d67a99111cd00dd3db8 Thanks, Dan Osborne

Re: Review Request 48527: Add NetworkInfo.labels to CNI Network before passing to CNI plugin.

2016-06-16 Thread Dan Osborne
8af50c11b00240ac1d24605b119acbd96aaa50be src/slave/containerizer/mesos/isolators/network/cni/paths.cpp b3fb0a32e3e74ca859ca58085efed5a87e4e626b Diff: https://reviews.apache.org/r/48527/diff/ Testing --- Thanks, Dan Osborne

Re: Review Request 48527: Add NetworkInfo.labels to CNI Network before passing to CNI plugin.

2016-06-15 Thread Dan Osborne
(line 962) <https://reviews.apache.org/r/48527/#comment203061> I'm not a fan of the number of JSON::Objects that were initialized here, but couldn't figure out a way to more dynamically create entries in `config['args']['labels']`. Any suggestions? - Dan Osborne On June 15, 2016, 10:

Re: Review Request 48527: Add NetworkInfo.labels to CNI Network before passing to CNI plugin.

2016-06-15 Thread Dan Osborne
il. To reply, visit: https://reviews.apache.org/r/48527/#review137667 ----------- On June 15, 2016, 10:23 p.m., Dan Osborne wrote: > > --- > This is an automat

Re: Review Request 48527: Add NetworkInfo.labels to CNI Network before passing to CNI plugin.

2016-06-15 Thread Dan Osborne
/containerizer/mesos/isolators/network/cni/paths.cpp b3fb0a32e3e74ca859ca58085efed5a87e4e626b Diff: https://reviews.apache.org/r/48527/diff/ Testing --- Thanks, Dan Osborne

Re: Review Request 48527: Add NetworkInfo.labels to CNI Network before passing to CNI plugin.

2016-06-15 Thread Dan Osborne
/paths.cpp b3fb0a32e3e74ca859ca58085efed5a87e4e626b Diff: https://reviews.apache.org/r/48527/diff/ Testing --- Thanks, Dan Osborne

Re: Review Request 48527: Add NetworkInfo.labels to CNI Network before passing to CNI plugin.

2016-06-15 Thread Dan Osborne
/slave/containerizer/mesos/isolators/network/cni/cni.cpp 106ff35320f37b2e75ed60381de1406459e6d515 Diff: https://reviews.apache.org/r/48527/diff/ Testing --- Thanks, Dan Osborne

Re: Review Request 48527: Add NetworkInfo.labels to CNI Network before passing to CNI plugin.

2016-06-13 Thread Dan Osborne
106ff35320f37b2e75ed60381de1406459e6d515 Diff: https://reviews.apache.org/r/48527/diff/ Testing --- Thanks, Dan Osborne

Review Request 48527: Add NetworkInfo.labels to CNI Network before passing to CNI plugin.

2016-06-09 Thread Dan Osborne
://reviews.apache.org/r/48527/diff/ Testing --- Thanks, Dan Osborne

Re: Review Request 47999: Added calico information for CNI.

2016-05-29 Thread Dan Osborne
=calico-cni-docs_path=088dbb7#diff-088dbb7685be5d67a99111cd00dd3db8 Thanks, Dan Osborne

Re: Review Request 47999: Added calico information for CNI.

2016-05-27 Thread Dan Osborne
: mesos Description --- Added calico information for CNI. Diffs (updated) - docs/cni.md cdc50da9db2f19f27be6a39f4d6e0f54834fb964 Diff: https://reviews.apache.org/r/47999/diff/ Testing --- Thanks, Dan Osborne

Review Request 47999: Added calico information for CNI.

2016-05-27 Thread Dan Osborne
--- Thanks, Dan Osborne

Re: Review Request 47971: Remove subnet prefix length from IP address.

2016-05-27 Thread Dan Osborne
/containerizer/mesos/isolators/network/cni/cni.cpp 2ba3d62041379f5175b58f8c1ba3c2eae73edcf6 Diff: https://reviews.apache.org/r/47971/diff/ Testing --- Thanks, Dan Osborne

Review Request 47971: Remove subnet prefix length from IP address.

2016-05-27 Thread Dan Osborne
/cni.cpp 2ba3d62041379f5175b58f8c1ba3c2eae73edcf6 Diff: https://reviews.apache.org/r/47971/diff/ Testing --- Thanks, Dan Osborne

Re: Review Request 44531: Fixed parsing network ip address with docker.

2016-03-09 Thread Dan Osborne
is `--net=default` and > it also works if I run the command `docker run -it --net default ubuntu:14.04 > /bin/bash` > > Travis Hegner wrote: > Do you know if it's possible to run a container with "--net=default" and > have the container running in some

Re: Review Request 44531: Fixed parsing network ip address with docker.

2016-03-09 Thread Dan Osborne
---------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44531/ > --- > > (Updated March 8, 2016, 10:54 p.m.) > > > Review reques

Re: Review Request 44531: Fixed parsing network ip address with docker.

2016-03-09 Thread Dan Osborne
> On March 8, 2016, 11:51 p.m., Dan Osborne wrote: > > Ship It! I ran a test cluster and found no regression for launching containers networked with bridge and host. - Dan --- This is an automatically generated e-mail. To rep

Re: Review Request 44531: Fixed parsing network ip address with docker.

2016-03-08 Thread Dan Osborne
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44531/#review122637 --- Ship it! Ship It! - Dan Osborne On March 8, 2016, 10:54 p.m