Re: Review Request 67065: Added a new stout utility header file which interfaces with libarchive.

2018-06-01 Thread Eric Mumau via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67065/#review204205 --- Ship it! Ship It! - Eric Mumau On June 1, 2018, 9:58 p.m., J

Re: Review Request 67066: Modified the fetcher to use libarchive and added associated tests.

2018-05-30 Thread Eric Mumau via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67066/#review204085 --- Ship it! - Eric Mumau On May 30, 2018, 8:30 p.m., John Kordic

Re: Review Request 67066: Modified the fetcher to use libarchive and added associated tests.

2018-05-30 Thread Eric Mumau via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67066/#review204084 --- src/tests/fetcher_tests.cpp Line 1015 (original)

Re: Review Request 66952: Windows: Added overlapped field to WindowsFD.

2018-05-04 Thread Eric Mumau via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66952/#review202463 --- 3rdparty/stout/include/stout/os/windows/fd.hpp Lines 183 (patched

Re: Review Request 64701: Windows: Added `/EHsc` to `CMAKE_CXX_FLAGS`.

2017-12-19 Thread Eric Mumau via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64701/#review194190 --- Ship it! Ship It! - Eric Mumau On Dec. 19, 2017, 3:44 a.m.,