Re: Review Request 70749: Introduced optional new scheme for hostname validation.

2019-06-21 Thread Jan-Philip Gehrcke via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70749/#review215999 --- Fix it, then Ship it! Just saw that I did not yet submit this

Re: Review Request 70795: Updated SSL docs to include new libprocess flag.

2019-06-20 Thread Jan-Philip Gehrcke via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70795/#review215998 --- Fix it, then Ship it! Great work, left a few comments. Thanks!

Re: Review Request 70810: Updated SSL docs with suggested runtime configuration.

2019-06-20 Thread Jan-Philip Gehrcke via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70810/#review215997 --- Fix it, then Ship it! Great work. I have added a few minor

Re: Review Request 70689: Improved log messages for SSL configuration.

2019-05-21 Thread Jan-Philip Gehrcke via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70689/#review215410 --- Ship it! Ship It! - Jan-Philip Gehrcke On May 21, 2019,

Re: Review Request 60913: Adds support for OpenSSL's ECDH handshake.

2017-07-19 Thread Jan-Philip Gehrcke via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60913/#review180916 --- Hey! This looks great. I have a few remarks. 1) The test in