Re: Review Request 41787: Speed up SlaveRecoveryTest.*.

ework (244 ms) Thanks, Jian Qiu

Re: Review Request 41787: Speed up SlaveRecoveryTest.*.

) SlaveRecoveryTest/0.ReconcileShutdownFramework (1379 ms total) SlaveRecoveryTest/0.CleanupExecutor (474 ms total) Thanks, Jian Qiu

Re: Review Request 41787: Speed up SlaveRecoveryTest.*.

) SlaveRecoveryTest/0.ReconcileKillTask (443 ms total) SlaveRecoveryTest/0.ReconcileShutdownFramework (1379 ms total) SlaveRecoveryTest/0.CleanupExecutor (474 ms total) Thanks, Jian Qiu

Re: Review Request 41787: Speed up Speed up SlaveRecoveryTest.*.

ms total) SlaveRecoveryTest/0.CleanupExecutor (474 ms total) Thanks, Jian Qiu

Re: Review Request 42241: Speed up HookTest.VerifySlaveLaunchExecutorHook.

- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42241/#review119797 --- On 四月 9, 2016, 2:45 p.m., Jian Qiu wrote: > >

Re: Review Request 42241: Speed up HookTest.VerifySlaveLaunchExecutorHook.

his is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42241/#review127792 ------- On 四月 9, 2016, 2:45 p.m., Jian Qiu wrote: > > --- > This is

Re: Review Request 42241: Speed up HookTest.VerifySlaveLaunchExecutorHook.

s.cpp 0bbb7ac9e80234920814e34286ea0da9b648ebe3 Diff: https://reviews.apache.org/r/42241/diff/ Testing --- Before HookTest.VerifySlaveLaunchExecutorHook (5061 ms) After HookTest.VerifySlaveLaunchExecutorHook (132 ms) Thanks, Jian Qiu

Re: Review Request 43935: Allow setting role in mesos-execute.

" --command="sleep 10" --role="test" --resources="cpus:2;mem:512" running mesos-execute with role test1 fails. ./src/mesos-execute --master=192.168.99.1:5050 --name="test" --command="sleep 10" --role="test1" --resources="cpus:2;mem:512" Thanks, Jian Qiu

Re: Review Request 43935: Allow setting role in mesos-execute.

ep 10" --role="test" --resources="cpus:2;mem:512" running mesos-execute with role test1 fails. ./src/mesos-execute --master=192.168.99.1:5050 --name="test" --command="sleep 10" --role="test1" --resources="cpus:2;mem:512" Thanks, Jian Qiu

Re: Review Request 43935: Allow setting role in mesos-execute.

1:5050 --name="test" --command="sleep 10" --role="test" --resources="cpus:2;mem:512" running mesos-execute with role test1 fails. ./src/mesos-execute --master=192.168.99.1:5050 --name="test" --command="sleep 10" --role="test1" --resources="cpus:2;mem:512" Thanks, Jian Qiu

Re: Review Request 43935: Allow setting role in mesos-execute.

... please review again. - Jian --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43935/#review125329 --- On 三月 25, 2016, 1:54 a.m., Jian Qiu wrote: > > ---

Re: Review Request 43935: Allow setting role in mesos-execute.

99.1:5050 --name="test" --command="sleep 10" --role="test" --resources="cpus:2;mem:512" running mesos-execute with role test1 fails. ./src/mesos-execute --master=192.168.99.1:5050 --name="test" --command="sleep 10" --role="test1" --resources="cpus:2;mem:512" Thanks, Jian Qiu

Re: Review Request 43935: Allow setting role in mesos-execute.

1:5050 --name="test" --command="sleep 10" --role="test" --resources="cpus:2;mem:512" running mesos-execute with role test1 fails. ./src/mesos-execute --master=192.168.99.1:5050 --name="test" --command="sleep 10" --role="test1" --resources="cpus:2;mem:512" Thanks, Jian Qiu

Re: Review Request 43935: Allow setting role in mesos-execute.

ep 10" --role="test" --resources="cpus:2;mem:512" running mesos-execute with role test1 fails. ./src/mesos-execute --master=192.168.99.1:5050 --name="test" --command="sleep 10" --role="test1" --resources="cpus:2;mem:512" Thanks, Jian Qiu

Re: Review Request 44421: Added support for "overlay" keyword.

421/#comment186528> This line seems redundant. - Jian Qiu On 三月 11, 2016, 11:58 a.m., Guangya Liu wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.

Re: Review Request 43935: Allow setting role in mesos-execute.

ot;test" --resources="cpus:2;mem:512" running mesos-execute with role test1 fails. ./src/mesos-execute --master=192.168.99.1:5050 --name="test" --command="sleep 10" --role="test1" --resources="cpus:2;mem:512" Thanks, Jian Qiu

Re: Review Request 43935: Allow setting role in mesos-execute.

ources in the target role, then unreserved resources. - Jian --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43935/#review123644 --------

Review Request 43935: Allow setting role in mesos-execute.

;mem:512" running mesos-execute with role test1 fails. ./src/mesos-execute --master=192.168.99.1:5050 --name="test" --command="sleep 10" --role="test1" --resources="cpus:2;mem:512" Thanks, Jian Qiu

Re: Review Request 43961: Added some additional synchronization in ROOT_CGROUPS_Pids_and_Tids.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43961/#review120664 --- Ship it! Ship It! - Jian Qiu On 二月 25, 2016, 5:59 a.m

Re: Review Request 43961: Added some additional synchronization in ROOT_CGROUPS_Pids_and_Tids.

tps://reviews.apache.org/r/43961/#comment182108> LGTM, Could you help changing the comment here? - Jian Qiu On 二月 24, 2016, 9:11 p.m., Joseph Wu wrote: > > --- > This is an automatically generated e-mail. To reply,

Re: Review Request 42241: Speed up HookTest.VerifySlaveLaunchExecutorHook.

ock::pause(); > > Clock::advance(...); > > Clock::settle(); > > ``` > > Jian Qiu wrote: > Thanks for reviewing! This settle() is necessary to trigger the > shutdownExecutor timer. > > Anand Mazumdar wrote: > Ahh, I see. It's not imme

Re: Review Request 42241: Speed up HookTest.VerifySlaveLaunchExecutorHook.

59a00ea722a17bbc82b14c69bda826f68cbac6e9 Diff: https://reviews.apache.org/r/42241/diff/ Testing --- Before HookTest.VerifySlaveLaunchExecutorHook (5061 ms) After HookTest.VerifySlaveLaunchExecutorHook (132 ms) Thanks, Jian Qiu

Re: Review Request 42241: Speed up HookTest.VerifySlaveLaunchExecutorHook.

e-mail. To reply, visit: https://reviews.apache.org/r/42241/#review119797 ------- On 二月 19, 2016, 3:29 a.m., Jian Qiu wrote: > > --- > This is an au

Re: Review Request 42241: Speed up HookTest.VerifySlaveLaunchExecutorHook.

59a00ea722a17bbc82b14c69bda826f68cbac6e9 Diff: https://reviews.apache.org/r/42241/diff/ Testing --- Before HookTest.VerifySlaveLaunchExecutorHook (5061 ms) After HookTest.VerifySlaveLaunchExecutorHook (132 ms) Thanks, Jian Qiu

Re: Review Request 43701: Added a command executor based on the new V1 API.

tps://reviews.apache.org/r/43701/#comment180939> this method and other methods not implementation of the virtual method should be private src/launcher/http_executor.cpp (line 202) <https://reviews.apache.org/r/43701/#comment180940> should this block be put in a separate function? - Jian Qi

Re: Review Request 43489: KillTask introduces TASK_KILLING state.

g/r/43489/#comment180588> the state should be TASK_KILLING? - Jian Qiu On 二月 16, 2016, 8:28 a.m., Abhishek Dasgupta wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.

Re: Review Request 43041: Update Master to send revocable resources in separate offers.

source) } - Jian Qiu On 二月 16, 2016, 8:21 a.m., Yongqiao Wang wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/43041/ > --

Re: Review Request 42440: Create a test macro to advance `Clock` for `Future`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42440/#review117766 --- Ship it! Ship It! - Jian Qiu On 一月 22, 2016, 4:56 p.m

Re: Review Request 41787: Speed up Speed up SlaveRecoveryTest.*.

.ReconcileShutdownFramework (1379 ms total) SlaveRecoveryTest/0.CleanupExecutor (474 ms total) Thanks, Jian Qiu

Re: Review Request 41787: Speed up Speed up SlaveRecoveryTest.*.

) SlaveRecoveryTest/0.ReconcileShutdownFramework (1379 ms total) SlaveRecoveryTest/0.CleanupExecutor (474 ms total) Thanks, Jian Qiu

Re: Review Request 42594: Introduced framework registry operations.

g/r/42594/#comment178304> When to use readmit if framwork is not allowed to be updated src/master/master.hpp (line 1638) <https://reviews.apache.org/r/42594/#comment178300> hashset* slaveIDs, bool strict - Jian Qiu On 二月 1, 2016, 7:24 a.m., Yongqia

Re: Review Request 42591: Added Framework protobufs to registry.

org/r/42591/#comment178298> Why do we persist these fields instead of the whole frameworkInfo or frameworkId only? - Jian Qiu On 二月 1, 2016, 7:23 a.m., Yongqiao Wang wrote: > > --- > This is an automatically generated e

Re: Review Request 42792: Fix compile error in container logger tests.

2/#review116427 --- On 一月 26, 2016, 8:12 a.m., Jian Qiu wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/42792/ > ---

Review Request 42792: Fix compile error in container logger tests.

on OSX and Ubuntu 15.04 Thanks, Jian Qiu

Re: Review Request 42441: Decrease scheduler authenticate timeout.

framework authentication message before it is fully started which cause the authentication timeout. I am not sure whether we can delay the start of framework until master has been fully started? - Jian Qiu On 一月 17, 2016, 6:27 p.m., haosdent huang wrote

Re: Review Request 42440: Create a test macro to advance `Clock` for `Future`.

tps://reviews.apache.org/r/42440/#comment176906> Maybe change this to advanceInterval? 3rdparty/libprocess/include/process/gtest.hpp (line 65) <https://reviews.apache.org/r/42440/#comment176905> If the clock is paused outside, there is no need to pause here - Jian Qiu On 一月 17

Re: Review Request 42241: Speed up HookTest.VerifySlaveLaunchExecutorHook.

AWAIT_READY has a timeout built in, and we will want to also make sure > > we don't hang forever. > > Also do we have a logically expected time the hook future should be > > ready? Can we just advance once and then AWAIT? > > Jian Qiu wrote: > Thanks, @tnach

Re: Review Request 42241: Speed up HookTest.VerifySlaveLaunchExecutorHook.

-------- On 一月 18, 2016, 4:03 p.m., Jian Qiu wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/42241/ >

Re: Review Request 42241: Speed up HookTest.VerifySlaveLaunchExecutorHook.

://reviews.apache.org/r/42241/diff/ Testing --- Before HookTest.VerifySlaveLaunchExecutorHook (5061 ms) After HookTest.VerifySlaveLaunchExecutorHook (132 ms) Thanks, Jian Qiu

Re: Review Request 42241: Speed up HookTest.VerifySlaveLaunchExecutorHook.

reply, visit: https://reviews.apache.org/r/42241/#review114762 ------- On 一月 18, 2016, 2:28 a.m., Jian Qiu wrote: > > --- > This is an automatically

Re: Review Request 42241: Speed up HookTest.VerifySlaveLaunchExecutorHook.

://reviews.apache.org/r/42241/diff/ Testing --- Before HookTest.VerifySlaveLaunchExecutorHook (5061 ms) After HookTest.VerifySlaveLaunchExecutorHook (132 ms) Thanks, Jian Qiu

Re: Review Request 42241: Speed up HookTest.VerifySlaveLaunchExecutorHook.

, Jian Qiu

Review Request 42241: Speed up HookTest.VerifySlaveLaunchExecutorHook.

--- Before HookTest.VerifySlaveLaunchExecutorHook (5061 ms) After HookTest.VerifySlaveLaunchExecutorHook (132 ms) Thanks, Jian Qiu

Re: Review Request 42130: WIP: Added tests for `ALLOCATION_SLACK` helper functions.

/#comment174519> Do you need this? it needs an estimator, but it seems that you have not started slave with an estimator. And I don't think estimator is necessary in this test? - Jian Qiu On 一月 11, 2016, 7:52 a.m., Klaus Ma wrote: > > -

Re: Review Request 41859: Launch tasks after evicting executors.

g/r/41859/#comment174089> If an evictable executor is in terminating state because of task finished, it cannot be moved out of evictableExecutors here. - Jian Qiu On 一月 8, 2016, 6:55 a.m., Klaus Ma wrote: > > --- > This is a

Re: Review Request 41857: Got evictable executors.

4079> I am not sure whether this situation will happen, because it means a task using allocation slack and is waiting for evicting executor. Master should not allowed such task to be launched beacause there not enough available allocation slack resources for this task - Jian Qiu On 一月

Re: Review Request 41858: Added helper functions to kill executor.

g/r/41858/#comment174062> Should this be used also by qos_correction? - Jian Qiu On 一月 8, 2016, 7:02 a.m., Klaus Ma wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.

Re: Review Request 41600: Speed up SlaveTest.CommandExecutorWithOverride.

case, and remove it when MESOS-4111 is fixed. Diffs (updated) - src/tests/slave_tests.cpp 328c853a338145256dadfc9364b9c2a0e6c356cb Diff: https://reviews.apache.org/r/41600/diff/ Testing --- Thanks, Jian Qiu

Re: Review Request 41848: Do not enable task and executor run on different resources.

allocation slack? - Jian Qiu On 一月 7, 2016, 11:26 a.m., Guangya Liu wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 41856: WIP: Added helper functions to get allocation slack.

g/r/41856/#comment173994> s/staeless/stateless - Jian Qiu On 一月 7, 2016, 1:09 p.m., Klaus Ma wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.

Re: Review Request 41600: Speed up SlaveTest.CommandExecutorWithOverride

/slave_tests.cpp 328c853a338145256dadfc9364b9c2a0e6c356cb Diff: https://reviews.apache.org/r/41600/diff/ Testing --- Thanks, Jian Qiu

Re: Review Request 41787: Speed up SlaveRecoveryTest.*.

.ReconcileKillTask (443 ms total) SlaveRecoveryTest/0.ReconcileShutdownFramework (1379 ms total) SlaveRecoveryTest/0.CleanupExecutor (474 ms total) Thanks, Jian Qiu

Re: Review Request 41787: Speed up Speed up SlaveRecoveryTest.*.

.ReconcileShutdownFramework (1379 ms total) SlaveRecoveryTest/0.CleanupExecutor (474 ms total) Thanks, Jian Qiu

Re: Review Request 41787: Speed up Speed up SlaveRecoveryTest.*.

ms total) Thanks, Jian Qiu

Review Request 41787: Speed up Speed up SlaveRecoveryTest.*

/0.CleanupExecutor (474 ms total) Thanks, Jian Qiu

Re: Review Request 41681: Introduce HTTP endpoint /weights for updating weight.

er.cpp (line 92) <https://reviews.apache.org/r/41681/#comment172858> <= 0 src/master/weights_handler.cpp (line 101) <https://reviews.apache.org/r/41681/#comment172864> s/existed/exist - Jian Qiu On 十二月 30, 2015, 11:5

Re: Review Request 41789: Add put method for http PUT request.

-3763 - Jian Qiu On 十二月 30, 2015, 8:08 a.m., Yongqiao Wang wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 41600: Speed up SlaveTest.CommandExecutorWithOverride

t; > there). There are two separate techniques used in this review request: > > explicit process kill and `Clock::advance()`. Though the latter may indeed > > slightly speed up the test, it's not longer necessary since > > `process::reap()` has been accelerated (see MESOS-11

Re: Review Request 41600: Speed up SlaveTest.CommandExecutorWithOverride

(updated) - src/tests/slave_tests.cpp 68d75176ce7cccafdf870fff48ac6a11089311ef Diff: https://reviews.apache.org/r/41600/diff/ Testing --- Thanks, Jian Qiu

Re: Review Request 41600: Speed up SlaveTest.CommandExecutorWithOverride

/hierarchical.cpp 7f900c4e024485704d79e57ae22407557598fe6c src/tests/slave_tests.cpp 90d56b987c60b99d9ca3e4ffef9cb71815bfc9b7 support/apply-reviews.py ea5e43a2b0d88f366efae56c6290c6929f4a4d5b Diff: https://reviews.apache.org/r/41600/diff/ Testing (updated) --- Thanks, Jian Qiu

Review Request 41675: Speed up SlaveTest.HTTPSchedulerSlaveRestart

rt (417 ms) [--] 1 test from SlaveTest (417 ms total) [--] Global test environment tear-down [==] 1 test from 1 test case ran. (426 ms total) [ PASSED ] 1 test. Thanks, Jian Qiu

Re: Review Request 41600: Speed up SlaveTest.CommandExecutorWithOverride

, Jian Qiu

Review Request 41600: Speed up SlaveTest.CommandExecutorWithOverride

] SlaveTest.CommandExecutorWithOverride [ OK ] SlaveTest.CommandExecutorWithOverride (405 ms) [--] 1 test from SlaveTest (405 ms total) [--] Global test environment tear-down [==] 1 test from 1 test case ran. (415 ms total) [ PASSED ] 1 test. Thanks, Jian Qiu

Re: Review Request 41337: WIP: Set task as TASK_LOST if not enough allocation slack resources.

g/r/41337/#comment170895> How about using tuple queue> pendingTasks? - Jian Qiu On 十二月 17, 2015, 2:49 a.m., Guangya Liu wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://revie

Re: Review Request 41333: Added helper functions to filter usage slack resources.

g/r/41333/#comment169943> two lines - Jian Qiu On Dec. 14, 2015, 5:23 a.m., Guangya Liu wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.

Re: Review Request 40632: WIP: Enabled oversubscribed resources for reservations in allocator.

> On Dec. 14, 2015, 2:14 a.m., Klaus Ma wrote: > > src/master/allocator/mesos/hierarchical.cpp, line 431 > > > > > > Honestly, I'd like to separate optimistic resources into other counter > > in allocator; it's a li

Re: Review Request 40469: Update Allocator interface to support dynamic weight

org/r/40469/#comment169655> namespace mesos? - Jian Qiu On Dec. 11, 2015, 9 a.m., Yongqiao Wang wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.

Re: Review Request 40224: Fix wrong flags infos in /state and /flags

utdown_frameworks": [{"principals": { "values": ["a", "b"] },"framework_principals": { "values": ["c"] }}]}' curl http://master:5050/state curl http://master:5050/flag Thanks, Jian Qiu

Re: Review Request 40224: Fix wrong flags infos in /state and /flags

ath instead of protobuf. - Jian --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40224/#review107604 --- On Nov. 23

Re: Review Request 40224: Fix wrong flags infos in /state and /flags

://reviews.apache.org/r/40224/#review107604 ------- On Nov. 23, 2015, 5:56 a.m., Jian Qiu wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/40224/ > ---

Review Request 40224: Fix wrong flags infos in /state and /flags

quot;a"] }}],"run_tasks": [{"principals": { "values": ["a", "b"] },"users": { "values": ["c"] }}],"shutdown_frameworks": [{"principals": { "values": ["a", "b"] },"framework_principals": { "values": ["c"] }}]}' curl http://master:5050/state curl http://master:5050/flag Thanks, Jian Qiu

Re: Review Request 38287: Check if the futrue is failed before dispatch in freeze()

.cpp f67633e31884b21e943a06100191d2228a637b1a Diff: https://reviews.apache.org/r/38287/diff/ Testing --- ./mesos-tests.sh --gtest_filter="CgroupsAnyHierarchyWithCpuMemoryTest.ROOT_CGROUPS_FreezeNonFreezer" --gtest_repeat=1000 --gtest_break_on_failure Thanks, Jian Qiu

Re: Review Request 38779: Use new HTTP status code check in scheduler.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38779/#review103720 --- Ship it! Ship It! - Jian Qiu On Oct. 23, 2015, 4:25 a.m

Re: Review Request 39043: Added support for HTTP Authentication in Mesos.

g/r/39043/#comment161461> may need a rephrase here - Jian Qiu On Oct. 21, 2015, 1:20 p.m., Alexander Rojas wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.

Re: Review Request 39368: Updated /state.json to show revocable resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39368/#review102858 --- Ship it! Ship It! - Jian Qiu On Oct. 16, 2015, 12:48 a.m

Re: Review Request 39216: Rename http_api_tests.cpp to scheduler_http_api_tests.cpp

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39216/#review102210 --- Ship it! Ship It! - Jian Qiu On Oct. 12, 2015, 5:10 a.m

Re: Review Request 38287: Check if the futrue is failed before dispatch in freeze()

d31f Diff: https://reviews.apache.org/r/38287/diff/ Testing (updated) --- ./mesos-tests.sh --gtest_filter="CgroupsAnyHierarchyWithCpuMemoryTest.ROOT_CGROUPS_FreezeNonFreezer" --gtest_repeat=1000 --gtest_break_on_failure Thanks, Jian Qiu

Re: Review Request 38454: Fix failed test LimitedCpuIsolatorTest.ROOT_CGROUPS_Pids_and_Tids

tedCpuIsolatorTest.ROOT_CGROUPS_Pids_and_Tids" --gtest_repeat=1000 --gtest_break_on_failure Thanks, Jian Qiu

Re: Review Request 38454: Fix failed test LimitedCpuIsolatorTest.ROOT_CGROUPS_Pids_and_Tids

tedCpuIsolatorTest.ROOT_CGROUPS_Pids_and_Tids" --gtest_repeat=1000 --gtest_break_on_failure Thanks, Jian Qiu

Re: Review Request 38602: Fixed minor typo in Executor API protobuf

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38602/#review99952 --- Ship it! Ship It! - Jian Qiu On Sept. 22, 2015, 3:07 a.m

Re: Review Request 37993: Add explanatory comments for Allocator interface

tps://reviews.apache.org/r/37993/#comment156712> needs adding explanation for @param inverseOfferCallback - Jian Qiu On Sept. 21, 2015, 7:28 a.m., Guangya Liu wrote: > > --- > This is an automatically generated e-mail. To reply,

Re: Review Request 38454: Fix failed test LimitedCpuIsolatorTest.ROOT_CGROUPS_Pids_and_Tids

ld be 1, but here is 2). This patch is to issue a "cat" command, so there > will be only one process in cgroup. > > > Diffs > - > > src/tests/containerizer/isolator_tests.cpp > a25ae97a519feb8ead6177da160df8a276ca15bf > > Diff: https://reviews.apache.org/r/38454/diff/ > > > Testing > --- > > ./mesos-tests.sh > --gtest_filter="LimitedCpuIsolatorTest.ROOT_CGROUPS_Pids_and_Tids" > --gtest_repeat=1000 --gtest_break_on_failure > > > Thanks, > > Jian Qiu > >

Re: Review Request 38454: Fix failed test LimitedCpuIsolatorTest.ROOT_CGROUPS_Pids_and_Tids

tedCpuIsolatorTest.ROOT_CGROUPS_Pids_and_Tids" --gtest_repeat=1000 --gtest_break_on_failure Thanks, Jian Qiu

Re: Review Request 38454: Fix failed test LimitedCpuIsolatorTest.ROOT_CGROUPS_Pids_and_Tids

a25ae97a519feb8ead6177da160df8a276ca15bf Diff: https://reviews.apache.org/r/38454/diff/ Testing (updated) --- ./mesos-tests.sh --gtest_filter="LimitedCpuIsolatorTest.ROOT_CGROUPS_Pids_and_Tids" --gtest_repeat=1000 --gtest_break_on_failure Thanks, Jian Qiu

Re: Review Request 38454: Fix failed test LimitedCpuIsolatorTest.ROOT_CGROUPS_Pids_and_Tids

t; ``` > > > > to test it? Done, thanks for reminding! - Jian --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38454/#review99361 -------

Review Request 38454: Fix failed test LimitedCpuIsolatorTest.ROOT_CGROUPS_Pids_and_Tids

://reviews.apache.org/r/38454/diff/ Testing --- ./mesos-tests.sh --gtest_filter="LimitedCpuIsolatorTest.ROOT_CGROUPS_Pids_and_Tids" Thanks, Jian Qiu

Re: Review Request 38124: Add V1 Support for QuiesceOffers

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38124/#review99358 --- Ship it! Ship It! - Jian Qiu On Sept. 16, 2015, 6:01 a.m

Re: Review Request 38287: Check if the futrue is failed before dispatch in freeze()

/cgroups.cpp 6ef42ed1bc719f334d1ac6e90919a1bc1840d31f Diff: https://reviews.apache.org/r/38287/diff/ Testing --- ./mesos-tests.sh --gtest_filter="CgroupsAnyHierarchyWithCpuMemoryTest.ROOT_CGROUPS_FreezeNonFreezer" --verbose Thanks, Jian Qiu

Re: Review Request 37284: Maintenance Primitives: Added support for Accept / Decline of InverseOffers in master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37284/#review98795 --- Ship it! Ship It! - Jian Qiu On 九月 13, 2015, 8:34 p.m., Joris

Re: Review Request 38287: Check if the futrue is failed before dispatch in freeze()

oop in internal::Freezer::freeze, I think it does not. - Jian --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38287/#review98540 --- On

Re: Review Request 38287: Check if the futrue is failed before dispatch in freeze()

> On 九月 11, 2015, 3:09 a.m., haosdent huang wrote: > > src/linux/cgroups.cpp, line 2440 > > <https://reviews.apache.org/r/38287/diff/1/?file=1067958#file1067958line2440> > > > > Does this fall into a loop? > > Jian Qiu wrote: > Does not quite c

Review Request 38287: Check if the futrue is failed before dispatch in freeze()

Diff: https://reviews.apache.org/r/38287/diff/ Testing --- ./mesos-tests.sh --gtest_filter="CgroupsAnyHierarchyWithCpuMemoryTest.ROOT_CGROUPS_FreezeNonFreezer" --verbose Thanks, Jian Qiu

Review Request 37955: Remove hashmap::existsValue since it is never called

--- make check Thanks, Jian Qiu

Re: Review Request 37180: Maintenance Primitives: Implemented Master::inverseOffer.

g/r/37180/#comment152785> If the allocator calls inverse callback followed by an offer callback, will the two messages be handled in two separate threads of the framework? I think it will be framework's responsibility to ensure data synchronization between the two threads? - Jian Qiu

Re: Review Request 37280: Maintenance Primitives: Added updateInverseOffer to Allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37280/#review96836 --- Ship it! Ship It! - Jian Qiu On 八月 26, 2015, 2:13 a.m., Joris