Re: Review Request 50540: Add systemd watchdog support.

2016-08-18 Thread Lawrence Wu
- wait a bit (30s) to make sure the watchdog has had a chance to kill the service - use systemctl status systemd-test-helper to check that the service is still running - clean up the unit file. Thanks, Lawrence Wu

Re: Review Request 50540: Add systemd watchdog support.

2016-08-18 Thread Lawrence Wu
> > Looks like you haven't checked headers. You need dev headers, right? I'm not too sure, but I think we just need this lib for sd_notify. I tried building this on a machine without the systemd dev headers and it worked, so I don't think dev headers are necessary.

Re: Review Request 50540: Add systemd watchdog support.

2016-08-18 Thread Lawrence Wu
- wait a bit (30s) to make sure the watchdog has had a chance to kill the service - use systemctl status systemd-test-helper to check that the service is still running - clean up the unit file. Thanks, Lawrence Wu

Re: Review Request 50540: Add systemd watchdog support.

2016-08-12 Thread Lawrence Wu
src/tests/linux/systemd_tests.cpp, line 90 > > <https://reviews.apache.org/r/50540/diff/2/?file=1455909#file1455909line90> > > > > ditto done > On Aug. 9, 2016, 6:33 p.m., Ian Downes wrote: > > src/tests/linux/systemd_tests.cpp, lines 101-109 > > <https

Re: Review Request 50540: Add systemd watchdog support.

2016-08-12 Thread Lawrence Wu
the watchdog has had a chance to kill the service - use systemctl status systemd-test-helper to check that the service is still running - clean up the unit file. TODO: create a similar test, but send a SIGSTOP to the service and ensure that it has been killed by watchdog. Thanks, Lawrence Wu

Re: Review Request 50540: Add systemd watchdog support.

2016-07-27 Thread Lawrence Wu
, Lawrence Wu

Review Request 50540: Add systemd watchdog support.

2016-07-27 Thread Lawrence Wu
by watchdog. Thanks, Lawrence Wu

Re: Review Request 50177: Add systemd watchdog support.

2016-07-18 Thread Lawrence Wu
mesos gets owned by watchdog https://reviews.apache.org/media/uploaded/files/2016/07/19/3c73b595-d28e-45d4-adfe-697801ba02cc__Screen_Shot_2016-07-18_at_2.09.31_PM.png Thanks, Lawrence Wu

Review Request 50177: Add systemd watchdog support.

2016-07-18 Thread Lawrence Wu
mesos gets owned by watchdog https://reviews.apache.org/media/uploaded/files/2016/07/19/3c73b595-d28e-45d4-adfe-697801ba02cc__Screen_Shot_2016-07-18_at_2.09.31_PM.png Thanks, Lawrence Wu

Review Request 49906: Add lawrencew to contributors

2016-07-11 Thread Lawrence Wu
--- Add lawrencew to contributors Diffs - docs/contributors.yaml 7272b59bfff1c30958f705b849b75f5cc656321e Diff: https://reviews.apache.org/r/49906/diff/ Testing --- Thanks, Lawrence Wu