Re: Review Request 36909: Call parent SetUp() and TearDown() in MesosZooKeeperTest.

2015-07-29 Thread haosdent huang
> On July 29, 2015, 8:40 p.m., Alexander Rukletsov wrote: > > src/tests/mesos.hpp, line 317 > > > > > > Shouldn't it come after network shutdown? > > https://reviews.apache.org/r/36920/ sorry, my fault - haosd

Re: Review Request 36909: Call parent SetUp() and TearDown() in MesosZooKeeperTest.

2015-07-29 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36909/#review93509 --- src/tests/mesos.hpp (line 317)

Re: Review Request 36909: Call parent SetUp() and TearDown() in MesosZooKeeperTest.

2015-07-29 Thread haosdent huang
> On July 29, 2015, 5:43 p.m., Vinod Kone wrote: > > Aah. Good catch. Thank you! You are welcome. :-) - haosdent --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36909/#review93482 ---

Re: Review Request 36909: Call parent SetUp() and TearDown() in MesosZooKeeperTest.

2015-07-29 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36909/#review93482 --- Ship it! Aah. Good catch. Thank you! - Vinod Kone On July 29, 20

Re: Review Request 36909: Call parent SetUp() and TearDown() in MesosZooKeeperTest.

2015-07-29 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36909/#review93472 --- Patch looks great! Reviews applied: [36909] All tests passed. - M

Re: Review Request 36909: Call parent SetUp() and TearDown() in MesosZooKeeperTest.

2015-07-29 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36909/ --- (Updated July 29, 2015, 1:56 p.m.) Review request for mesos and Vinod Kone. B

Re: Review Request 36909: Call parent SetUp() and TearDown() in MesosZooKeeperTest.

2015-07-29 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36909/ --- (Updated July 29, 2015, 1:53 p.m.) Review request for mesos. Bugs: MESOS-3168

Re: Review Request 36909: Call parent SetUp() and TearDown() in MesosZooKeeperTest.

2015-07-29 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36909/ --- (Updated July 29, 2015, 1:53 p.m.) Review request for mesos. Summary (updated