Re: Review Request 53741: Display maintainance info in the webui.

2017-01-29 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53741/#review163433 --- Patch looks great! Reviews applied: [53741] Passed command: expo

Re: Review Request 53741: Display maintainance info in the webui.

2017-01-29 Thread Tomasz Janiszewski
> On Jan. 25, 2017, 6:16 p.m., haosdent huang wrote: > > Hi, may you mind rebase this. Done. - Tomasz --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53741/#review162986 -

Re: Review Request 53741: Display maintainance info in the webui.

2017-01-29 Thread Tomasz Janiszewski
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53741/ --- (Updated Jan. 29, 2017, 2:48 p.m.) Review request for mesos, haosdent huang and

Re: Review Request 53741: Display maintainance info in the webui.

2017-01-25 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53741/#review162986 --- Hi, may you mind rebase this. - haosdent huang On Nov. 16, 2016

Re: Review Request 53741: Display maintainance info in the webui.

2016-11-23 Thread haosdent huang
> On Nov. 16, 2016, 8:18 a.m., haosdent huang wrote: > > src/webui/master/static/js/controllers.js, line 469 > > > > > > Any reason that remove `pollState();` here? > > Tomasz Janiszewski wrote: > This function

Re: Review Request 53741: Display maintainance info in the webui.

2016-11-16 Thread Tomasz Janiszewski
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53741/ --- (Updated Nov. 16, 2016, 7:54 p.m.) Review request for mesos, haosdent huang and

Re: Review Request 53741: Display maintainance info in the webui.

2016-11-16 Thread Tomasz Janiszewski
> On Nov. 16, 2016, 8:18 a.m., haosdent huang wrote: > > src/webui/master/static/js/controllers.js, line 469 > > > > > > Any reason that remove `pollState();` here? This function was redundant since this page is not

Re: Review Request 53741: Display maintainance info in the webui.

2016-11-16 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53741/#review156037 --- Fix it, then Ship it! Ship It! src/webui/master/static/js/app

Re: Review Request 53741: Display maintainance info in the webui.

2016-11-15 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53741/#review156011 --- Patch looks great! Reviews applied: [53741] Passed command: expo

Re: Review Request 53741: Display maintainance info in the webui.

2016-11-15 Thread Tomasz Janiszewski
> On Nov. 15, 2016, 3:06 a.m., Mesos ReviewBot wrote: > > Patch looks great! > > > > Reviews applied: [53741] > > > > Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' > > COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 > > MESOS_VERBOSE=1'; ./support/docker_build.

Re: Review Request 53741: Display maintainance info in the webui.

2016-11-15 Thread Tomasz Janiszewski
> On Nov. 15, 2016, 5:38 p.m., haosdent huang wrote: > > src/webui/master/static/js/app.js, line 291 > > > > > > Could not get the point why need this, I think `if (scope.columnKey === > > key) {` have cover this?

Re: Review Request 53741: Display maintainance info in the webui.

2016-11-15 Thread Tomasz Janiszewski
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53741/ --- (Updated Nov. 15, 2016, 9:03 p.m.) Review request for mesos, haosdent huang and

Re: Review Request 53741: Display maintainance info in the webui.

2016-11-15 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53741/#review155931 --- src/webui/master/static/js/app.js (lines 7 - 8)

Re: Review Request 53741: Display maintainance info in the webui.

2016-11-14 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53741/#review155882 --- Patch looks great! Reviews applied: [53741] Passed command: expo