Re: Review Request 59013: Implemented passing Image::Secret Puller::pull().

> On May 10, 2017, 6:53 p.m., Chun-Hung Hsiao wrote: > > src/slave/containerizer/mesos/provisioner/docker/puller.hpp > > Lines 65 (patched) > > > > > > Do we need a default value here? It seems that all subclasses

Re: Review Request 59013: Implemented passing Image::Secret Puller::pull().

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59013/#review174527 --- src/slave/containerizer/mesos/provisioner/docker/puller.hpp

Re: Review Request 59013: Implemented passing Image::Secret Puller::pull().

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59013/#review174507 --- Ship it! Ship It! - Chun-Hung Hsiao On May 10, 2017, 12:47

Re: Review Request 59013: Implemented passing Image::Secret Puller::pull().

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59013/ --- (Updated May 10, 2017, 5:47 a.m.) Review request for mesos, Adam B, Chun-Hung

Re: Review Request 59013: Implemented passing Image::Secret Puller::pull().

> On May 8, 2017, 5:22 p.m., Vinod Kone wrote: > > src/slave/containerizer/mesos/provisioner/docker/store.cpp > > Line 235 (original), 243-244 (patched) > > > > > > I'm assuming you need `config` here explicitly and

Re: Review Request 59013: Implemented passing Image::Secret Puller::pull().

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59013/#review174253 --- Ship it!