Re: Review Request 59116: Windows: Updated `support/windows-build.bat`.

2017-05-10 Thread Jeff Coffler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59116/#review174560 --- support/windows-build.bat Line 52 (original), 52 (patched)

Re: Review Request 59116: Windows: Updated `support/windows-build.bat`.

2017-05-10 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59116/#review174562 --- Patch looks great! Reviews applied: [59155, 59156, 59157, 59116]

Re: Review Request 59116: Windows: Updated `support/windows-build.bat`.

2017-05-10 Thread Andrew Schwartzmeyer
> On May 10, 2017, 9:19 p.m., Jeff Coffler wrote: > > support/windows-build.bat > > Line 52 (original), 52 (patched) > > > > > > Is this correct? Did we deprecate older toolsets? I thought that, at > > this point, we

Re: Review Request 59116: Windows: Updated `support/windows-build.bat`.

2017-05-10 Thread Andrew Schwartzmeyer
> On May 10, 2017, 9:21 p.m., Mesos Reviewbot Windows wrote: > > Patch looks great! > > > > Reviews applied: [59155, 59156, 59157, 59116] > > > > Passed command: support\windows-build.bat Hey look at that! Windows Reviewbot works :D - Andrew

Re: Review Request 59116: Windows: Updated `support/windows-build.bat`.

2017-05-10 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59116/#review174598 --- Patch looks great! Reviews applied: [59155, 59156, 59157, 59116]

Re: Review Request 59116: Windows: Updated `support/windows-build.bat`.

2017-05-10 Thread Li Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59116/#review174603 --- Ship it! Ship It! - Li Li On May 10, 2017, 8:40 p.m., Andrew

Re: Review Request 59116: Windows: Updated `support/windows-build.bat`.

2017-05-15 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59116/#review174987 --- Ship it! I can fixup the few comments before committing. supp