Re: Review Request 65045: Tested correct operation handling during master failover.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65045/#review197751 --- Patch looks great! Reviews applied: [65671, 65672, 65044, 65045]

Re: Review Request 65045: Tested correct operation handling during master failover.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65045/#review197747 --- PASS: Mesos patch 65045 was successfully built and tested. Review

Re: Review Request 65045: Tested correct operation handling during master failover.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65045/ --- (Updated Feb. 19, 2018, 12:09 p.m.) Review request for mesos, Benjamin Bannier

Re: Review Request 65045: Tested correct operation handling during master failover.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65045/#review197680 --- Patch looks great! Reviews applied: [65671, 65672, 65044, 65045]

Re: Review Request 65045: Tested correct operation handling during master failover.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65045/#review197674 --- Fix it, then Ship it! src/tests/master_tests.cpp Lines 8803 (p

Re: Review Request 65045: Tested correct operation handling during master failover.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65045/#review196983 --- FAIL: Some of the unit tests failed. Please check the relevant log

Re: Review Request 65045: Tested correct operation handling during master failover.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65045/ --- (Updated Feb. 7, 2018, 11:57 a.m.) Review request for mesos, Benjamin Bannier a

Re: Review Request 65045: Tested correct operation handling during master failover.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65045/#review196885 --- PASS: Mesos patch 65045 was successfully built and tested. Review

Re: Review Request 65045: Tested correct operation handling during master failover.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65045/ --- (Updated Feb. 6, 2018, 11:11 a.m.) Review request for mesos, Benjamin Bannier a

Re: Review Request 65045: Tested correct operation handling during master failover.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65045/#review196745 --- FAIL: Failed to apply the dependent review: 65043. Failed command

Re: Review Request 65045: Tested correct operation handling during master failover.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65045/ --- (Updated Feb. 2, 2018, 2:30 p.m.) Review request for mesos, Benjamin Bannier an

Re: Review Request 65045: Tested correct operation handling during master failover.

> On Feb. 1, 2018, 7:56 a.m., Greg Mann wrote: > > src/tests/master_tests.cpp > > Lines 8899 (patched) > > > > > > Is this necessary? Yes, the operation update will result in a `UPDATE_STATE` that will trigger ano

Re: Review Request 65045: Tested correct operation handling during master failover.

> On Feb. 1, 2018, 7:56 a.m., Greg Mann wrote: > > src/tests/master_tests.cpp > > Lines 8903 (patched) > > > > > > Do we need this, or does framework registration after master failover > > prompt an offer? You're

Re: Review Request 65045: Tested correct operation handling during master failover.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65045/#review196621 --- src/tests/master_tests.cpp Lines 8772 (patched)

Re: Review Request 65045: Tested correct operation handling during master failover.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65045/#review196252 --- PASS: Mesos patch 65045 was successfully built and tested. Review

Re: Review Request 65045: Tested correct operation handling during master failover.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65045/#review196244 --- PASS: Mesos patch 65045 was successfully built and tested. Review

Re: Review Request 65045: Tested correct operation handling during master failover.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65045/ --- (Updated Jan. 25, 2018, 2:10 p.m.) Review request for mesos, Benjamin Bannier a

Re: Review Request 65045: Tested correct operation handling during master failover.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65045/ --- (Updated Jan. 25, 2018, 1:24 p.m.) Review request for mesos, Benjamin Bannier a

Re: Review Request 65045: Tested correct operation handling during master failover.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65045/#review195918 --- This test emitted some gmock warnings for me. Could you get rid of

Re: Review Request 65045: Tested correct operation handling during master failover.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65045/#review195727 --- PASS: Mesos patch 65045 was successfully built and tested. Review

Re: Review Request 65045: Tested correct operation handling during master failover.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65045/ --- (Updated Jan. 18, 2018, 3:11 p.m.) Review request for mesos, Benjamin Bannier a

Re: Review Request 65045: Tested correct operation handling during master failover.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65045/#review195550 --- Ship it! Ship It! - Benjamin Bannier On Jan. 16, 2018, 2:45

Re: Review Request 65045: Tested correct operation handling during master failover.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65045/#review195456 --- PASS: Mesos patch 65045 was successfully built and tested. Review

Re: Review Request 65045: Tested correct operation handling during master failover.

> On Jan. 15, 2018, 11:34 a.m., Benjamin Bannier wrote: > > src/tests/master_tests.cpp > > Lines 8667 (patched) > > > > > > This requires `process/ssl/flags.hpp` to compile with SSL enabled. As the code is now reba

Re: Review Request 65045: Tested correct operation handling during master failover.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65045/ --- (Updated Jan. 16, 2018, 2:45 p.m.) Review request for mesos, Benjamin Bannier a

Re: Review Request 65045: Tested correct operation handling during master failover.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65045/#review195416 --- src/tests/master_tests.cpp Lines 8617 (patched)

Re: Review Request 65045: Tested correct operation handling during master failover.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65045/#review195415 --- src/tests/master_tests.cpp Lines 8667 (patched)

Re: Review Request 65045: Tested correct operation handling during master failover.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65045/#review195032 --- PASS: Mesos patch 65045 was successfully built and tested. Review