Re: Review Request 67914: Updated XFS disk isolator to reclaim project IDs after disk GC.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67914/#review206413 --- Ship it! Ship It! - James Peach On July 24, 2018, 6:19

Re: Review Request 67914: Updated XFS disk isolator to reclaim project IDs after disk GC.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67914/ --- (Updated July 24, 2018, 11:19 a.m.) Review request for mesos and James Peach.

Re: Review Request 67914: Updated XFS disk isolator to reclaim project IDs after disk GC.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67914/#review206368 --- PASS: Mesos patch 67914 was successfully built and tested.

Re: Review Request 67914: Updated XFS disk isolator to reclaim project IDs after disk GC.

> On July 18, 2018, 1:51 p.m., James Peach wrote: > > src/slave/flags.cpp > > Lines 1338 (patched) > > > > > > Rather than introducing a new flag, lets use > > `container_disk_watch_interval` or

Re: Review Request 67914: Updated XFS disk isolator to reclaim project IDs after disk GC.

> On July 23, 2018, 3:22 p.m., James Peach wrote: > > src/slave/containerizer/mesos/isolators/xfs/disk.hpp > > Lines 24 (patched) > > > > > > Let's use a pull gauge here for sampling performance reasons. > > > >

Re: Review Request 67914: Updated XFS disk isolator to reclaim project IDs after disk GC.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67914/ --- (Updated July 23, 2018, 4:21 p.m.) Review request for mesos and James Peach.

Re: Review Request 67914: Updated XFS disk isolator to reclaim project IDs after disk GC.

> On July 23, 2018, 10:22 p.m., James Peach wrote: > > src/slave/containerizer/mesos/isolators/xfs/disk.hpp > > Lines 24 (patched) > > > > > > Let's use a pull gauge here for sampling performance reasons. > > >

Re: Review Request 67914: Updated XFS disk isolator to reclaim project IDs after disk GC.

> On July 18, 2018, 8:51 p.m., James Peach wrote: > > src/slave/containerizer/mesos/isolators/xfs/disk.cpp > > Lines 549 (patched) > > > > > > If possible, I think this is simple enough to inline into the check loop

Re: Review Request 67914: Updated XFS disk isolator to reclaim project IDs after disk GC.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67914/#review206351 --- src/slave/containerizer/mesos/isolators/xfs/disk.hpp Lines 24

Re: Review Request 67914: Updated XFS disk isolator to reclaim project IDs after disk GC.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67914/#review206308 --- Patch looks great! Reviews applied: [67915, 67914] Passed

Re: Review Request 67914: Updated XFS disk isolator to reclaim project IDs after disk GC.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67914/#review206255 --- PASS: Mesos patch 67914 was successfully built and tested.

Re: Review Request 67914: Updated XFS disk isolator to reclaim project IDs after disk GC.

> On July 18, 2018, 1:51 p.m., James Peach wrote: > > src/slave/containerizer/mesos/isolators/xfs/disk.cpp > > Line 495 (original), 504 (patched) > > > > > > I'm a little concerned that we could exhaust the project

Re: Review Request 67914: Updated XFS disk isolator to reclaim project IDs after disk GC.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67914/ --- (Updated July 19, 2018, 4:12 p.m.) Review request for mesos and James Peach.

Re: Review Request 67914: Updated XFS disk isolator to reclaim project IDs after disk GC.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67914/#review206203 --- src/slave/containerizer/mesos/isolators/xfs/disk.cpp Line 495

Re: Review Request 67914: Updated XFS disk isolator to reclaim project IDs after disk GC.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67914/#review206079 --- PASS: Mesos patch 67914 was successfully built and tested.

Re: Review Request 67914: Updated XFS disk isolator to reclaim project IDs after disk GC.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67914/ --- (Updated July 13, 2018, 2:59 p.m.) Review request for mesos and James Peach.