Re: Review Request 70215: Cleanup volume attaching and publishing for SLRP.

2019-03-21 Thread Chun-Hung Hsiao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70215/ --- (Updated March 22, 2019, 6:18 a.m.) Review request for mesos, Benjamin Bannier,

Re: Review Request 70215: Cleanup volume attaching and publishing for SLRP.

2019-03-22 Thread Chun-Hung Hsiao
> On March 19, 2019, 5:06 p.m., Benjamin Bannier wrote: > > src/csi/v0_volume_manager.cpp > > Lines 146 (patched) > > > > > > `s/sequentialized/serialized/` here and below? > > > > _attaching_ to be consiste

Re: Review Request 70215: Cleanup volume attaching and publishing for SLRP.

2019-03-25 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70215/#review213981 --- Fix it, then Ship it! src/resource_provider/storage/provider.c

Re: Review Request 70215: Cleanup volume attaching and publishing for SLRP.

2019-03-26 Thread Chun-Hung Hsiao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70215/ --- (Updated March 27, 2019, 5:58 a.m.) Review request for mesos, Benjamin Bannier,

Re: Review Request 70215: Cleanup volume attaching and publishing for SLRP.

2019-03-28 Thread Chun-Hung Hsiao
> On March 25, 2019, 3:37 p.m., Benjamin Bannier wrote: > > src/resource_provider/storage/provider.cpp > > Line 1670 (original), 1620 (patched) > > > > > > Do we need to `CHECK`? Or can the volume legitimately go aw

Re: Review Request 70215: Cleanup volume attaching and publishing for SLRP.

2019-03-28 Thread Chun-Hung Hsiao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70215/ --- (Updated March 28, 2019, 7:55 a.m.) Review request for mesos, Benjamin Bannier,