Re: Review Request 70533: Implemented the UPDATE_FRAMEWORK call in the V1 API.

> On May 22, 2019, 7:52 p.m., Benjamin Mahler wrote: > > src/master/master.cpp > > Lines 3172-3173 (patched) > > > > > > This is undefined behavior (and may crash, this has caught me before), > > because `call` is

Re: Review Request 70533: Implemented the UPDATE_FRAMEWORK call in the V1 API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70533/#review215466 --- Fix it, then Ship it! Nice and clean patch! There's a bug

Re: Review Request 70533: Implemented the UPDATE_FRAMEWORK call in the V1 API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70533/ --- (Updated May 22, 2019, 1:49 p.m.) Review request for mesos and Benjamin

Re: Review Request 70533: Implemented the UPDATE_FRAMEWORK call in the V1 API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70533/ --- (Updated May 21, 2019, 1:54 p.m.) Review request for mesos and Benjamin

Re: Review Request 70533: Implemented the UPDATE_FRAMEWORK call in the V1 API.

> On April 24, 2019, 7:52 p.m., Benjamin Mahler wrote: > > src/master/master.cpp > > Lines 3237 (patched) > > > > > > What does updateFramework do if the changes are not allowed? Crash? > > > > Seems like

Re: Review Request 70533: Implemented the UPDATE_FRAMEWORK call in the V1 API.

> On May 12, 2019, 5:46 a.m., Benjamin Mahler wrote: > > src/master/master.cpp > > Lines 2877-2880 (original), 2884-2887 (patched) > > > > > > Hm.. why doesn't the broadcast function send it to subscribers too? why

Re: Review Request 70533: Implemented the UPDATE_FRAMEWORK call in the V1 API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70533/ --- (Updated May 17, 2019, 3:18 p.m.) Review request for mesos and Benjamin

Re: Review Request 70533: Implemented the UPDATE_FRAMEWORK call.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70533/#review215205 --- src/master/master.hpp Lines 665-668 (patched)

Re: Review Request 70533: Implemented the UPDATE_FRAMEWORK call.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70533/ --- (Updated May 7, 2019, 1:09 p.m.) Review request for mesos and Benjamin Mahler.

Re: Review Request 70533: Implemented the UPDATE_FRAMEWORK call.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70533/ --- (Updated May 2, 2019, 4:03 p.m.) Review request for mesos and Benjamin Mahler.

Re: Review Request 70533: Implemented the UPDATE_FRAMEWORK call.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70533/ --- (Updated May 2, 2019, 3:58 p.m.) Review request for mesos and Benjamin Mahler.

Re: Review Request 70533: Implemented the UPDATE_FRAMEWORK call.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70533/ --- (Updated April 25, 2019, 8:14 p.m.) Review request for mesos and Benjamin

Re: Review Request 70533: Implemented the UPDATE_FRAMEWORK call.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70533/ --- (Updated April 25, 2019, 8:04 p.m.) Review request for mesos and Benjamin

Re: Review Request 70533: Implemented the UPDATE_FRAMEWORK call.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70533/#review214864 --- src/java/jni/org_apache_mesos_v1_scheduler_V0Mesos.cpp Lines

Re: Review Request 70533: Implemented the UPDATE_FRAMEWORK call.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70533/ --- (Updated April 23, 2019, 7:06 p.m.) Review request for mesos and Benjamin