---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30774/#review86871
---
Just took a cursory glance since this is a huge diff, could it have
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30774/
---
(Updated May 21, 2015, 5:06 a.m.)
Review request for mesos, Adam B, Benjamin
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30774/
---
(Updated May 21, 2015, 9:05 a.m.)
Review request for mesos, Adam B, Benjamin
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30774/
---
(Updated May 19, 2015, 8:58 a.m.)
Review request for mesos, Adam B, Benjamin
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30774/#review83944
---
src/tests/fetcher_cache_tests.cpp
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30774/#review83946
---
- Bernd Mathiske
On May 13, 2015, 3:07 p.m., Bernd Mathiske
On April 29, 2015, 3:41 p.m., Benjamin Hindman wrote:
src/slave/containerizer/fetcher.cpp, lines 408-417
https://reviews.apache.org/r/30774/diff/44/?file=945694#file945694line408
For the future:
auto futures = filter(entries, [](const auto entry) { return
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30774/
---
(Updated May 13, 2015, 3:07 p.m.)
Review request for mesos, Adam B, Benjamin
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30774/
---
(Updated May 4, 2015, 4:29 p.m.)
Review request for mesos, Adam B, Benjamin
On March 19, 2015, 9:40 a.m., Timothy Chen wrote:
src/slave/containerizer/fetcher.cpp, line 379
https://reviews.apache.org/r/30774/diff/38/?file=899705#file899705line379
benh, what do you think of Bernd's contentionBarrier injection?
commonly we always just mock the callback
On March 10, 2015, 8:35 a.m., Benjamin Hindman wrote:
src/launcher/fetcher.cpp, lines 403-404
https://reviews.apache.org/r/30774/diff/33/?file=888350#file888350line403
As mentioned above, it would be great to really capture the
relationship between the FetcherInfo and the
On March 10, 2015, 8:35 a.m., Benjamin Hindman wrote:
src/launcher/fetcher.cpp, lines 364-366
https://reviews.apache.org/r/30774/diff/33/?file=888350#file888350line364
Why are these not CHECKs? Since you're the one setting up the
FetcherInfo it seems like you should know
On April 29, 2015, 3:41 p.m., Benjamin Hindman wrote:
src/slave/containerizer/fetcher.cpp, line 386
https://reviews.apache.org/r/30774/diff/44/?file=945694#file945694line386
Kill the const .
Killed the . Any reason this should not be const?
On April 29, 2015, 3:41 p.m., Benjamin
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30774/
---
(Updated April 30, 2015, 7:40 p.m.)
Review request for mesos, Adam B, Benjamin
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30774/#review82017
---
src/slave/containerizer/fetcher.hpp
15 matches
Mail list logo
