Re: Review Request 31505: Add flow classifiers for fq_codel on egress

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31505/ --- (Updated May 12, 2015, 12:14 a.m.) Review request for mesos, Chi Zhang, Ian Dow

Re: Review Request 31505: Add flow classifiers for fq_codel on egress

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31505/#review83334 --- Patch looks great! Reviews applied: [31502, 31503, 31504, 31505] A

Re: Review Request 31505: Add flow classifiers for fq_codel on egress

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31505/#review83690 --- src/slave/containerizer/isolators/network/port_mapping.hpp

Re: Review Request 31505: Add flow classifiers for fq_codel on egress

> On May 14, 2015, 7:44 p.m., Jie Yu wrote: > > src/slave/containerizer/isolators/network/port_mapping.cpp, line 1767 > > > > > > No need to use `filter::` prefix for `filter::Filter` as it's already > > included. W

Re: Review Request 31505: Add flow classifiers for fq_codel on egress

> On May 14, 2015, 7:44 p.m., Jie Yu wrote: > > src/slave/containerizer/isolators/network/port_mapping.hpp, line 329 > > > > > > Please add some comments about what this is. Consider using hashset > > instead of std::

Re: Review Request 31505: Add flow classifiers for fq_codel on egress

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31505/ --- (Updated May 15, 2015, 9:32 p.m.) Review request for mesos, Chi Zhang, Ian Down

Re: Review Request 31505: Add flow classifiers for fq_codel on egress

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31505/#review83982 --- Patch looks great! Reviews applied: [31502, 31503, 31504, 31505] A

Re: Review Request 31505: Add flow classifiers for fq_codel on egress

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31505/ --- (Updated May 17, 2015, 12:27 a.m.) Review request for mesos, Chi Zhang, Ian Dow

Re: Review Request 31505: Add flow classifiers for fq_codel on egress

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31505/#review84049 --- Patch looks great! Reviews applied: [31502, 31503, 31504, 31505] A

Re: Review Request 31505: Add flow classifiers for fq_codel on egress

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31505/#review84998 --- Two high level comments: 1) We need a slave flag to control if turn

Re: Review Request 31505: Add flow classifiers for fq_codel on egress

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31505/ --- (Updated May 26, 2015, 8:41 p.m.) Review request for mesos, Chi Zhang, Ian Down

Re: Review Request 31505: Add flow classifiers for fq_codel on egress

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31505/#review85268 --- src/slave/containerizer/isolators/network/port_mapping.cpp

Re: Review Request 31505: Add flow classifiers for fq_codel on egress

> On May 26, 2015, 9:54 p.m., Chi Zhang wrote: > > src/slave/containerizer/isolators/network/port_mapping.cpp, lines 1843-1850 > > > > > > this could also happen if we are recovering a container not using this > > fe

Re: Review Request 31505: Add flow classifiers for fq_codel on egress

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31505/#review85328 --- Patch looks great! Reviews applied: [31502, 31503, 31504, 31505] A

Re: Review Request 31505: Add flow classifiers for fq_codel on egress

> On May 22, 2015, 10:09 p.m., Jie Yu wrote: > > Two high level comments: > > > > 1) We need a slave flag to control if turning on this feature or not > > 2) Do you think we should at least add some unit test for this? For > > example, verify that the filters are properly set up? Ping. Did you

Re: Review Request 31505: Add flow classifiers for fq_codel on egress

> On May 22, 2015, 10:09 p.m., Jie Yu wrote: > > Two high level comments: > > > > 1) We need a slave flag to control if turning on this feature or not > > 2) Do you think we should at least add some unit test for this? For > > example, verify that the filters are properly set up? > > Jie Yu wr

Re: Review Request 31505: Add flow classifiers for fq_codel on egress

> On May 22, 2015, 10:09 p.m., Jie Yu wrote: > > Two high level comments: > > > > 1) We need a slave flag to control if turning on this feature or not > > 2) Do you think we should at least add some unit test for this? For > > example, verify that the filters are properly set up? > > Jie Yu wr

Re: Review Request 31505: Add flow classifiers for fq_codel on egress

> On May 22, 2015, 10:09 p.m., Jie Yu wrote: > > Two high level comments: > > > > 1) We need a slave flag to control if turning on this feature or not > > 2) Do you think we should at least add some unit test for this? For > > example, verify that the filters are properly set up? > > Jie Yu wr

Re: Review Request 31505: Add flow classifiers for fq_codel on egress

> On May 22, 2015, 10:09 p.m., Jie Yu wrote: > > Two high level comments: > > > > 1) We need a slave flag to control if turning on this feature or not > > 2) Do you think we should at least add some unit test for this? For > > example, verify that the filters are properly set up? > > Jie Yu wr

Re: Review Request 31505: Add flow classifiers for fq_codel on egress

> On May 22, 2015, 10:09 p.m., Jie Yu wrote: > > Two high level comments: > > > > 1) We need a slave flag to control if turning on this feature or not > > 2) Do you think we should at least add some unit test for this? For > > example, verify that the filters are properly set up? > > Jie Yu wr

Re: Review Request 31505: Add flow classifiers for fq_codel on egress

> On May 22, 2015, 10:09 p.m., Jie Yu wrote: > > Two high level comments: > > > > 1) We need a slave flag to control if turning on this feature or not > > 2) Do you think we should at least add some unit test for this? For > > example, verify that the filters are properly set up? > > Jie Yu wr

Re: Review Request 31505: Add flow classifiers for fq_codel on egress

> On May 22, 2015, 10:09 p.m., Jie Yu wrote: > > Two high level comments: > > > > 1) We need a slave flag to control if turning on this feature or not > > 2) Do you think we should at least add some unit test for this? For > > example, verify that the filters are properly set up? > > Jie Yu wr

Re: Review Request 31505: Add flow classifiers for fq_codel on egress

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31505/ --- (Updated June 1, 2015, 10:45 p.m.) Review request for mesos, Chi Zhang, Ian Dow

Re: Review Request 31505: Add flow classifiers for fq_codel on egress

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31505/#review86133 --- Cong, is this the patch the requires code from 3.2.26 for the first

Re: Review Request 31505: Add flow classifiers for fq_codel on egress

> On June 2, 2015, 12:57 a.m., Chi Zhang wrote: > > Cong, is this the patch the requires code from 3.2.26 for the first time? > > If so, should we add a compile-time flag to config.ac? That way Paul can > > safely back off the code for the "stat string conversion" from the other > > patch you

Re: Review Request 31505: Add flow classifiers for fq_codel on egress

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31505/#review86155 --- Ship it! I added the slave flag for you. Please follow up with tes

Re: Review Request 31505: Add flow classifiers for fq_codel on egress

> On June 2, 2015, 12:57 a.m., Chi Zhang wrote: > > Cong, is this the patch the requires code from 3.2.26 for the first time? > > If so, should we add a compile-time flag to config.ac? That way Paul can > > safely back off the code for the "stat string conversion" from the other > > patch you

Re: Review Request 31505: Add flow classifiers for fq_codel on egress

> On June 2, 2015, 12:57 a.m., Chi Zhang wrote: > > Cong, is this the patch the requires code from 3.2.26 for the first time? > > If so, should we add a compile-time flag to config.ac? That way Paul can > > safely back off the code for the "stat string conversion" from the other > > patch you