Re: Review Request 33295: Added firewall mechanism to control access on libprocess http endpoints.

> On June 9, 2015, 12:32 a.m., Ben Mahler wrote: > > 3rdparty/libprocess/src/tests/process_tests.cpp, line 1930 > > > > > > Any reason you could't use initializer list construction for this? Lets add a `TODO(arojas)

Re: Review Request 33295: Added firewall mechanism to control access on libprocess http endpoints.

> On June 9, 2015, 2:32 a.m., Ben Mahler wrote: > > 3rdparty/libprocess/src/process.cpp, line 1986 > > > > > > We've generally avoided looping using references, although I see why > > you did here. Was there a reaso

Re: Review Request 33295: Added firewall mechanism to control access on libprocess http endpoints.

> On June 9, 2015, 2:32 a.m., Ben Mahler wrote: > > 3rdparty/libprocess/src/tests/process_tests.cpp, line 1921 > > > > > > Just 'pid' will do :) `pid` conflicts with a name before. However, following the parameter n

Re: Review Request 33295: Added firewall mechanism to control access on libprocess http endpoints.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33295/#review87100 --- 3rdparty/libprocess/include/process/firewall.hpp

Re: Review Request 33295: Added firewall mechanism to control access on libprocess http endpoints.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33295/ --- (Updated June 8, 2015, 12:09 p.m.) Review request for mesos, Adam B, Benjamin H

Re: Review Request 33295: Added firewall mechanism to control access on libprocess http endpoints.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33295/ --- (Updated June 8, 2015, 11:54 a.m.) Review request for mesos, Adam B, Benjamin H

Re: Review Request 33295: Added firewall mechanism to control access on libprocess http endpoints.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33295/#review86800 --- Ship it! 3rdparty/libprocess/include/process/firewall.hpp

Re: Review Request 33295: Added firewall mechanism to control access on libprocess http endpoints.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33295/ --- (Updated June 2, 2015, 11:57 a.m.) Review request for mesos, Adam B, Benjamin H

Re: Review Request 33295: Added firewall mechanism to control access on libprocess http endpoints.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33295/#review86169 --- Ship it! Add an @return and fix the nits, and I'm ready to commit t

Re: Review Request 33295: Added firewall mechanism to control access on libprocess http endpoints.

> On June 1, 2015, 1:06 a.m., Adam B wrote: > > 3rdparty/libprocess/include/process/firewall.hpp, lines 54-55 > > > > > > Please capitalize "The" beginning of each @param description. > > Alexander Rojas wrote: > I

Re: Review Request 33295: Added firewall mechanism to control access on libprocess http endpoints.

> On June 1, 2015, 10:06 a.m., Adam B wrote: > > 3rdparty/libprocess/include/process/firewall.hpp, lines 54-55 > > > > > > Please capitalize "The" beginning of each @param description. I do completely agree with you, a

Re: Review Request 33295: Added firewall mechanism to control access on libprocess http endpoints.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33295/ --- (Updated June 1, 2015, 5:52 p.m.) Review request for mesos, Adam B, Benjamin Hi

Re: Review Request 33295: Added firewall mechanism to control access on libprocess http endpoints.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33295/#review85950 --- Looks very close! Just some minor nits and suggested rewordings, plu

Re: Review Request 33295: Added firewall mechanism to control access on libprocess http endpoints.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33295/#review84479 --- Ship it! Just as mentioned we should remember to add this to the li

Re: Review Request 33295: Added firewall mechanism to control access on libprocess http endpoints.

> On May 20, 2015, 9:18 a.m., Joerg Schad wrote: > > 3rdparty/libprocess/include/process/process.hpp, line 36 > > > > > > Do we use this doxygen style anywhere else? Could not find any > > occurence in c++ code. `gr

Re: Review Request 33295: Added firewall mechanism to control access on libprocess http endpoints.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33295/ --- (Updated May 20, 2015, 9:46 a.m.) Review request for mesos, Adam B, Benjamin Hi

Re: Review Request 33295: Added firewall mechanism to control access on libprocess http endpoints.

> On May 20, 2015, 7:18 a.m., Joerg Schad wrote: > > 3rdparty/libprocess/src/process.cpp, line 373 > > > > > > are universal/rvalue refs allowed by our style guide? If so should we > > add it to the styleguide? actua

Re: Review Request 33295: Added firewall mechanism to control access on libprocess http endpoints.

> On May 20, 2015, 7:18 a.m., Joerg Schad wrote: > > Besides the below mentioned points looks good to me! We should just remember adding this to the libprocess user guide. - Joerg --- This is an automatically generated e-mail. To reply

Re: Review Request 33295: Added firewall mechanism to control access on libprocess http endpoints.

> On May 20, 2015, 7:18 a.m., Joerg Schad wrote: > > docs/powered-by-mesos.md, line 28 > > > > > > Is that dropped by a rebase or by you? > > Same below Thanks for fixing this so quickly :-). - Joerg --

Re: Review Request 33295: Added firewall mechanism to control access on libprocess http endpoints.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33295/#review84473 --- 3rdparty/libprocess/include/process/process.hpp

Re: Review Request 33295: Added firewall mechanism to control access on libprocess http endpoints.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33295/ --- (Updated May 20, 2015, 8:39 a.m.) Review request for mesos, Adam B, Benjamin Hi

Re: Review Request 33295: Added firewall mechanism to control access on libprocess http endpoints.

> On April 23, 2015, 2:49 p.m., Till Toenshoff wrote: > > 3rdparty/libprocess/include/process/firewall.hpp, line 37 > > > > > > I forgot the verbally proposed name for this function, but maybe a > > negated result and

Re: Review Request 33295: Added firewall mechanism to control access on libprocess http endpoints.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33295/ --- (Updated May 1, 2015, 7:12 p.m.) Review request for mesos, Adam B, Benjamin Hin

Re: Review Request 33295: Added firewall mechanism to control access on libprocess http endpoints.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33295/ --- (Updated April 30, 2015, 10:13 p.m.) Review request for mesos, Adam B, Benjamin

Re: Review Request 33295: Added firewall mechanism to control access on libprocess http endpoints.

> On April 23, 2015, 2:49 p.m., Till Toenshoff wrote: > > 3rdparty/libprocess/src/process.cpp, line 1993 > > > > > > `<< "': firewall rule forbids connection";` might be a bit more > > mesos'esque. It follows the pa

Re: Review Request 33295: Added firewall mechanism to control access on libprocess http endpoints.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33295/#review81825 --- 3rdparty/libprocess/include/process/process.hpp

Re: Review Request 33295: Added firewall mechanism to control access on libprocess http endpoints.

> On April 23, 2015, 8:19 p.m., Joris Van Remoortere wrote: > > 3rdparty/libprocess/src/process.cpp, lines 2461-2463 > > > > > > For this synchronized block, and above: > > > > In order to ensure we don't end

Re: Review Request 33295: Added firewall mechanism to control access on libprocess http endpoints.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33295/#review81357 --- 3rdparty/libprocess/src/process.cpp

Re: Review Request 33295: Added firewall mechanism to control access on libprocess http endpoints.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33295/#review81327 --- 3rdparty/libprocess/include/process/firewall.hpp

Re: Review Request 33295: Added firewall mechanism to control access on libprocess http endpoints.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33295/#review81334 --- 3rdparty/libprocess/src/process.cpp

Re: Review Request 33295: Added firewall mechanism to control access on libprocess http endpoints.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33295/#review81329 --- Please move the `*` for pointers to the left as per our style guide:

Re: Review Request 33295: Added firewall mechanism to control access on libprocess http endpoints.

> On April 23, 2015, 5:49 a.m., Till Toenshoff wrote: > > 3rdparty/libprocess/include/process/firewall.hpp, line 37 > > > > > > I forgot the verbally proposed name for this function, but maybe a > > negated result and

Re: Review Request 33295: Added firewall mechanism to control access on libprocess http endpoints.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33295/#review80582 --- This review was pending a couple of days in my outbox, hence it may